fix: Reset SLA on issue doesn't work (#38789)
This was broken since last refactor where it was spun off to work with
all types of doctypes but client side code was never adapted.
(cherry picked from commit fa1c7b663c2e3f433190d29017eaebbe15d4c604)
Co-authored-by: Ankush Menat <ankush@frappe.io>
* refactor: use arrow function
(cherry picked from commit 1763824e5f7ccaefb83aea84db47c92f9e4c9417)
* refactor: use DocType `Fetch From` instead of `frm.add_fetch`
(cherry picked from commit 01044ca8e95ec4e84e63fcfe4928ca111cf3a75b)
* refactor: use `frm.set_query` to add filters
(cherry picked from commit 640dfab827f2e83b9c3ae7ff839c6f94b63b71b2)
* refactor: don't use `cur_frm`
(cherry picked from commit 9fadf5f42678736567160bb2b06619383146d4ca)
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
- This contains little to no information and practically no one uses this.
- Also causes a lot of problem by adding way too many feeds in activity
log to the point where activity page doesn't even load.
Warn: Just used regex to replace all usage.
```regex
s/frappe.db.set(\(.*\),\(.*\),\(.*\))/\1.db_set(\2, \3)/g
```
Required after: https://github.com/frappe/frappe/pull/18815
* refactor: use CURRENT_DATE instead of CURDATE()
* style: reformat to black spec
* refactor: use QB for auto_close queries
Co-authored-by: Ankush Menat <ankush@frappe.io>
