Sagar Vora
c00d0a3e24
fix: better validation for Integration Request ( #28186 )
2021-11-16 20:31:18 +05:30
Marica
0c9acc799b
Merge pull request #28228 from marination/se-required-items-from-jc
...
fix: Pull only Items that are in Job Card in a Stock Entry against Job Card
2021-11-16 18:37:32 +05:30
Marica
612bb5c749
Merge branch 'develop' into se-required-items-from-jc
2021-11-16 18:03:40 +05:30
Marica
6bd0c1dbf1
Merge pull request #28269 from marination/pr-return-ux
...
refactor: (ux) Accepted/Rejected/Received Qty UX
2021-11-16 18:00:42 +05:30
Subin Tom
a1807a2f98
fix: POS idx issue in taxes table while merging ( #28389 )
2021-11-16 17:46:26 +05:30
Marica
4afcbfdc08
Merge branch 'develop' into pr-return-ux
2021-11-16 15:15:48 +05:30
marination
a5f8274d79
fix: test_job_card_partial_material_transfer
test
...
- Use a specific BOM for JC tests
- Utility to create said BOM
- Sider: unused variable
2021-11-16 15:13:19 +05:30
marination
293f6cbafd
fix: Sider, Linter and Server Side Test
...
- Fix Server side PR test
- linter: re-arrange imports
- sider: avoid single line multi statement
- Code cleanup: Improve code readability and avoid horizontal scroll in test_purchase_receipt
- Removed unused variables in test_purchase_receipt
2021-11-16 14:36:15 +05:30
Ahmed Shareef
952fc87c99
refactor: fix help section background in dark mode ( #28406 )
2021-11-16 14:30:13 +05:30
rohitwaghchaure
aaf0e4e709
Merge pull request #28398 from rohitwaghchaure/fix-pricing-rule-creation-against-promotional-scheme
...
fix: Pricing Rule not created against the Promotional Scheme
2021-11-16 13:54:26 +05:30
Kenneth Sequeira
f786a596f8
chore: add docker pull count to readme ( #28405 )
2021-11-16 12:01:26 +05:30
marination
e9c75d6eea
test: Purchase Invoice Received Qty
2021-11-16 11:55:34 +05:30
Rohit Waghchaure
d82910b08a
fix: Pricing Rule not created against the Promotional Scheme
2021-11-16 10:27:59 +05:30
Ankush Menat
ed99aca36f
test: basic test for serialize reco cancel
2021-11-16 10:00:18 +05:30
Ankush Menat
8c85012a70
fix: can not cancel stock reconciliation with sr no
2021-11-16 10:00:18 +05:30
Rohan
043e3255d6
fix: remove item-item group name validation ( #28392 )
2021-11-15 19:41:17 +05:30
Deepesh Garg
ce06aaa0ae
Merge pull request #27735 from GangaManoj/fix-so-cancellation-message
...
fix: Sales Order cancellation message
2021-11-15 18:51:30 +05:30
Ankush Menat
54184e54ed
fix: patch for naming series property setter
2021-11-15 18:18:22 +05:30
Ankush Menat
7fcaeca403
fix: don't make naming series mandatory for items
...
Item variants are an exception, hence this needs to be checked
conditionally.
2021-11-15 18:18:22 +05:30
marination
05ec7cce82
test: Purchase Receipt Received Qty
2021-11-15 17:49:14 +05:30
marination
afe1c45f7f
fix: Sider + Fields UX
...
- remove extra space (sider)
- PR: Bring rejected qty in grid view
- PI: Rename `Stock Qty` to `Accepted Qty in Stock UOM`
- PI: Move `Accepted Qty in Stock UOM` under Stock UOM
2021-11-15 17:17:29 +05:30
Sagar Sharma
2eccb7a1ca
fix: Work order creation from sales order ( #28388 )
...
* fix: Work order creation from sales order
* chore: formatting
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2021-11-15 16:08:15 +05:30
marination
bb561ba7a8
fix: Server side test
...
- make `tests_that_skip_setup` a tuple (added comma)
- remove manual teardown in `test_job_card_material_transfer_correctness` to avoid premature committing
- transfer_material_against = "Job Card" while making BOM with mulitple operations
2021-11-15 15:21:20 +05:30
Conor
03370c63c5
chore: minor typo correction in CONTRIBUTING ( #28386 )
2021-11-14 09:46:31 +05:30
Ankush Menat
c0f06bc8e3
fix: validate hmac unconditionally ( #28372 )
2021-11-12 14:45:51 +05:30
Sagar Vora
6d3e9bce5f
fix(M-Pesa): validate type before executing get_doc
( #28369 )
2021-11-12 14:24:33 +05:30
Sagar Vora
24b048925b
fix(WooCommerce): always expect signature in webhook requests ( #28367 )
2021-11-12 14:08:02 +05:30
Sagar Sharma
a424310581
fix: Collapse Scrap Items in Job Card ( #28362 )
2021-11-12 13:50:30 +05:30
Deepesh Garg
829f92f10a
Merge pull request #28363 from deepeshgarg007/default_party_account
...
fix: Default party account getting overriden in invoices
2021-11-12 13:04:21 +05:30
Deepesh Garg
88648570d7
fix: Default party account getting overriden in invoices
2021-11-12 12:39:30 +05:30
Sagar Sharma
944bf8da71
fix: Unable to edit supplier scorecard criteria name once created ( #28348 )
2021-11-11 19:49:41 +05:30
rohitwaghchaure
0157da57b5
Merge pull request #28308 from rohitwaghchaure/commision-rate-not-fetch-from-sales-person
...
fix: commission rate not fetch from sales person
2021-11-11 19:11:31 +05:30
Saqib
ecbe4b16b8
perf(minor): general ledger report ( #27987 )
2021-11-11 13:55:21 +05:30
Deepesh Garg
fdb8e1855d
Merge pull request #28334 from deepeshgarg007/gstr_1_duplicate_items
...
fix(India): Sales Invoice with duplicate items not showing correct taxable value
2021-11-11 11:38:58 +05:30
Marica
18f9e3558e
Merge branch 'develop' into se-required-items-from-jc
2021-11-11 11:14:37 +05:30
Deepesh Garg
0dca97eb9f
fix(India): Sales Invoice with duplicate items not showing correct taxable value
2021-11-10 21:07:48 +05:30
Ankush Menat
c96b5492db
fix: reload doctype forcefully
2021-11-10 19:41:55 +05:30
Ankush Menat
b728597ef4
fix: use hotfix branches for patch tests
2021-11-10 19:41:55 +05:30
Saqib
6d05bb5274
fix(pos): get mode of payments query ( #28321 )
2021-11-10 13:06:55 +05:30
Ankush Menat
12e81df2b7
fix: default value for allow neg stock in repost_item_valuation
...
Negative stock can be toggled back after queuing transactions, this
causes failure when repost is executed.
Now allow_negative_stock stock is set at time of queuing the repost job.
This means setting changes done afterwards won't affect already
submitted reposts.
2021-11-10 13:05:14 +05:30
Anuja Pawar
2f004693c3
fix(Bank Reconciliation): get credit amount for bank account of type liability
2021-11-10 12:36:54 +05:30
Ankush Menat
e498389b00
fix: ignore cancelled entries in incorrect balance qty report
2021-11-10 12:09:51 +05:30
Rohit Waghchaure
4d4bfa2333
fix: commision rate not fetch from sales person
2021-11-10 00:00:38 +05:30
marination
1eb3ca2b86
fix: (travis) Production Plan Summary Report breaks if no WO
...
- `get_cached_value` throws a DoesNotExistError if non-existent value, used `get_value` instead
- accomodate production plan items that dont have WO/PO against them as well (blank values)
- added some None value handling to avoid AttributeError
2021-11-09 23:07:28 +05:30
Anupam Kumar
6954dd6329
feat: Competitor Tagging in Opportunity and Quotation ( #28050 )
...
* feat: Competitor Tagging in Opportunity and Quotation
* fix: review changes
* fix: linter issue
* fix: section label
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
2021-11-09 19:36:27 +05:30
Ankush Menat
ccf84ae88a
fix: patch to update job card status
2021-11-09 18:04:50 +05:30
Ankush Menat
fdfa39c231
fix: avoid mutating iterator while iterating over it
2021-11-09 18:04:50 +05:30
Ankush Menat
37799fe3dd
fix: use completion qty instead of transfer quantity for JC status
2021-11-09 18:04:50 +05:30
Marica
031178224f
Merge branch 'develop' into se-required-items-from-jc
2021-11-09 17:33:20 +05:30
Wolfram Schmidt
6907ad8adb
fix: add Email option to contact email field ( #28296 )
...
* Update warranty_claim.json
Added the Email in option field of Contact Email so you are able to create a notification mapping to this field as reciever.
* Update warranty_claim.json
2021-11-09 17:32:57 +05:30