fix: validate hmac unconditionally (#28372)

This commit is contained in:
Ankush Menat 2021-11-12 14:45:51 +05:30 committed by GitHub
parent 6d3e9bce5f
commit c0f06bc8e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -23,7 +23,6 @@ def validate_webhooks_request(doctype, hmac_key, secret_key='secret'):
)
if frappe.request.data and \
frappe.get_request_header(hmac_key) and \
not sig == bytes(frappe.get_request_header(hmac_key).encode()):
frappe.throw(_("Unverified Webhook Data"))
frappe.set_user(settings.modified_by)