Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

codacy fixes

Browse Source
This commit is contained in:
Ben Cornwell-Mott 2017-07-25 05:44:55 -07:00 committed by Rushabh Mehta
parent 94c6b7409b
commit e92b4737e3
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/hr/doctype/training_event/test_training_event.js
View File

@ -19,8 +19,8 @@ QUnit.test("test: Training Event", function (assert) {
() => cur_frm.set_value("send_email", 0),
() => frappe.click_button('Add Row'),
() => {
cur_frm.fields_dict.employees.grid.grid_rows[0].doc.attendance = "Optional";
},
cur_frm.fields_dict.employees.grid.grid_rows[0].doc.attendance = "Optional";
},
() => frappe.click_button('Save'),
() => frappe.timeout(1),
() => frappe.click_button('Submit'),

16
erpnext/hr/doctype/training_event/training_event.js
View File

@ -22,7 +22,7 @@ frappe.ui.form.on('Training Event', {
var params = getSearchParameters();
if (params.hasOwnProperty('employee') && params.hasOwnProperty('status')) {
var newTemp = frm.doc.employees.filter(function(obj) {
return obj.name == params.employee
return obj.name == params.employee;
});
if (newTemp) {
newTemp[0].status = params.status;
@ -42,12 +42,12 @@ function getSearchParameters() {
}
function transformToAssocArray( prmstr ) {
var params = {};
var prmarr = prmstr.split("&");
for ( var i = 0; i < prmarr.length; i++) {
var tmparr = prmarr[i].split("=");
params[tmparr[0]] = tmparr[1];
}
return params;
var params = {};
var prmarr = prmstr.split("&");
for ( var i = 0; i < prmarr.length; i++) {
var tmparr = prmarr[i].split("=");
params[tmparr[0]] = tmparr[1];
}
return params;
}

2
erpnext/hr/doctype/training_event/training_event.py
View File

@ -64,7 +64,7 @@ class TrainingEvent(Document):
if email:
make(subject = subject, content=message,recipients=email,
sender=sender,attachments = attachments, send_email=True,
doctype=self.doctype, name=self.name)["name"]
doctype=self.doctype, name=self.name)
frappe.msgprint(_("Email sent to {0}").format(data.employee_name))
def get_attachments(self):