From e92b4737e340eb4234462e3e3361209f8b0dc780 Mon Sep 17 00:00:00 2001 From: Ben Cornwell-Mott Date: Tue, 25 Jul 2017 05:44:55 -0700 Subject: [PATCH] codacy fixes --- .../training_event/test_training_event.js | 4 ++-- .../hr/doctype/training_event/training_event.js | 16 ++++++++-------- .../hr/doctype/training_event/training_event.py | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/erpnext/hr/doctype/training_event/test_training_event.js b/erpnext/hr/doctype/training_event/test_training_event.js index c8310947c1..62264f3692 100644 --- a/erpnext/hr/doctype/training_event/test_training_event.js +++ b/erpnext/hr/doctype/training_event/test_training_event.js @@ -19,8 +19,8 @@ QUnit.test("test: Training Event", function (assert) { () => cur_frm.set_value("send_email", 0), () => frappe.click_button('Add Row'), () => { - cur_frm.fields_dict.employees.grid.grid_rows[0].doc.attendance = "Optional"; - }, + cur_frm.fields_dict.employees.grid.grid_rows[0].doc.attendance = "Optional"; + }, () => frappe.click_button('Save'), () => frappe.timeout(1), () => frappe.click_button('Submit'), diff --git a/erpnext/hr/doctype/training_event/training_event.js b/erpnext/hr/doctype/training_event/training_event.js index 86a4eaf0ae..24760b058d 100644 --- a/erpnext/hr/doctype/training_event/training_event.js +++ b/erpnext/hr/doctype/training_event/training_event.js @@ -22,7 +22,7 @@ frappe.ui.form.on('Training Event', { var params = getSearchParameters(); if (params.hasOwnProperty('employee') && params.hasOwnProperty('status')) { var newTemp = frm.doc.employees.filter(function(obj) { - return obj.name == params.employee + return obj.name == params.employee; }); if (newTemp) { newTemp[0].status = params.status; @@ -42,12 +42,12 @@ function getSearchParameters() { } function transformToAssocArray( prmstr ) { - var params = {}; - var prmarr = prmstr.split("&"); - for ( var i = 0; i < prmarr.length; i++) { - var tmparr = prmarr[i].split("="); - params[tmparr[0]] = tmparr[1]; - } - return params; + var params = {}; + var prmarr = prmstr.split("&"); + for ( var i = 0; i < prmarr.length; i++) { + var tmparr = prmarr[i].split("="); + params[tmparr[0]] = tmparr[1]; + } + return params; } diff --git a/erpnext/hr/doctype/training_event/training_event.py b/erpnext/hr/doctype/training_event/training_event.py index f2860c78ca..c35f595048 100644 --- a/erpnext/hr/doctype/training_event/training_event.py +++ b/erpnext/hr/doctype/training_event/training_event.py @@ -64,7 +64,7 @@ class TrainingEvent(Document): if email: make(subject = subject, content=message,recipients=email, sender=sender,attachments = attachments, send_email=True, - doctype=self.doctype, name=self.name)["name"] + doctype=self.doctype, name=self.name) frappe.msgprint(_("Email sent to {0}").format(data.employee_name)) def get_attachments(self):