zeripath
fb5f7791ef
Prevent off-by-one error on comments on newly appended lines ( #18029 )
...
* Prevent off-by-one error on comments on newly appended lines
There was a bug in CutDiffAroundLine whereby if a file without a terminal new line
has a patch which appends lines to it and a comment is placed on one of those lines
the comment diff will be a line out of place.
This fixes CutDiffAroundLine to simply ignore the missing terminal newline - however,
we should really improve this rendering to add a marker to say that there was a
previously missing terminal newline.
Fix #17875
Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-12-20 02:15:49 +00:00
..
2021-11-30 20:06:32 +00:00
2021-09-20 20:46:51 +01:00
2021-12-16 19:01:14 +00:00
2021-09-22 13:38:34 +08:00
2021-11-30 20:06:32 +00:00
2021-08-24 11:47:09 -05:00
2021-11-30 20:06:32 +00:00
2021-09-22 13:38:34 +08:00
2021-10-24 22:12:43 +01:00
2021-08-24 11:47:09 -05:00
2021-11-30 20:06:32 +00:00
2021-08-24 11:47:09 -05:00
2021-10-08 15:08:22 +02:00
2021-11-30 20:06:32 +00:00
2021-11-17 20:34:35 +08:00
2020-12-17 22:00:47 +08:00
2021-05-12 01:11:42 -04:00
2021-07-02 21:23:37 +02:00
2021-12-02 15:28:08 +08:00
2021-12-20 02:15:49 +00:00
2021-12-20 02:15:49 +00:00
2021-06-23 17:08:26 -04:00
2021-06-25 17:54:08 +01:00
2021-10-13 14:20:11 -04:00
2021-09-22 13:38:34 +08:00
2021-10-08 15:08:22 +02:00
2021-10-08 15:08:22 +02:00
2021-10-08 15:08:22 +02:00
2021-06-26 13:28:55 +02:00
2021-10-15 19:41:34 +01:00
2021-10-08 15:08:22 +02:00
2021-10-08 15:08:22 +02:00
2021-08-09 16:24:34 +01:00
2020-12-17 22:00:47 +08:00
2021-08-24 11:47:09 -05:00
2021-08-24 11:47:09 -05:00
2021-08-24 11:47:09 -05:00
2021-08-24 11:47:09 -05:00
2019-03-27 17:33:00 +08:00
2021-12-02 15:28:08 +08:00
2021-11-30 20:06:32 +00:00
2021-08-24 11:47:09 -05:00
2021-09-09 21:13:36 +01:00
2021-11-30 20:06:32 +00:00
2021-11-30 20:06:32 +00:00
2021-12-16 19:01:14 +00:00
2021-11-30 20:06:32 +00:00
2021-08-24 11:47:09 -05:00
2021-08-24 11:47:09 -05:00
2021-09-22 13:38:34 +08:00
2020-12-17 22:00:47 +08:00
2021-12-08 19:08:16 +00:00
2021-12-08 19:08:16 +00:00
2021-12-08 19:08:16 +00:00
2021-12-08 19:08:16 +00:00
2021-11-30 20:06:32 +00:00
2021-12-16 19:01:14 +00:00
2021-08-09 14:08:51 -04:00
2021-11-30 20:06:32 +00:00
2021-08-24 11:47:09 -05:00
2021-11-17 20:34:35 +08:00
2021-12-19 05:19:25 +01:00
2021-11-30 20:06:32 +00:00
2019-03-27 17:33:00 +08:00
2021-11-30 20:06:32 +00:00
2021-11-17 20:37:00 +00:00
2021-11-30 20:06:32 +00:00
2021-09-20 20:46:51 +01:00
2020-12-17 22:00:47 +08:00
2021-11-30 20:06:32 +00:00
2021-08-24 11:47:09 -05:00
2021-12-02 15:28:08 +08:00
2019-11-13 07:01:19 +00:00
2020-12-17 22:00:47 +08:00
2020-01-20 12:07:30 +02:00
2021-11-30 20:06:32 +00:00
2021-09-10 19:30:37 +02:00
2021-11-30 20:06:32 +00:00
2021-11-17 20:34:35 +08:00
2021-11-30 20:06:32 +00:00
2021-05-09 17:20:33 +02:00
2021-11-30 20:06:32 +00:00
2021-11-30 20:06:32 +00:00
2021-11-30 20:06:32 +00:00
2021-12-02 15:28:08 +08:00
2021-08-24 11:47:09 -05:00
2021-08-24 11:47:09 -05:00
2020-12-17 22:00:47 +08:00
2021-08-24 11:47:09 -05:00
2021-08-24 11:47:09 -05:00
2020-12-17 22:00:47 +08:00
2020-09-07 20:08:10 -04:00
2021-10-17 20:47:12 +01:00
2020-12-22 21:44:25 +01:00
2021-05-12 01:11:42 -04:00
2021-08-24 11:47:09 -05:00
2021-08-24 11:47:09 -05:00
2020-12-17 22:00:47 +08:00
2021-08-24 11:47:09 -05:00
2020-12-17 22:00:47 +08:00
2021-08-24 11:47:09 -05:00
2021-08-24 11:47:09 -05:00
2021-05-10 03:27:03 +02:00
2021-08-24 11:47:09 -05:00
2021-11-30 20:06:32 +00:00
2021-07-20 15:16:20 +02:00
2020-05-14 18:55:43 -04:00
2021-11-16 18:18:25 +00:00