Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
f9c3459831
githaven/routers/web/repo
History
wxiaoguang ee242a08e9
Refactor issue template parsing and fix API endpoint (#29069) 
The old code `GetTemplatesFromDefaultBranch(...) ([]*api.IssueTemplate,
map[string]error)` doesn't really follow Golang's habits, then the
second returned value might be misused. For example, the API function
`GetIssueTemplates` incorrectly checked the second returned value and
always responds 500 error.

This PR refactors GetTemplatesFromDefaultBranch to
ParseTemplatesFromDefaultBranch and clarifies its behavior, and fixes the
API endpoint bug, and adds some tests.

And by the way, add proper prefix `X-` for the header generated in
`checkDeprecatedAuthMethods`, because non-standard HTTP headers should
have `X-` prefix, and it is also consistent with the new code in
`GetIssueTemplates`
2024-02-12 05:04:10 +00:00
..
actions Display friendly error message (#29105) 2024-02-08 22:01:19 +00:00
setting Move some repository transfer functions to service layer (#28855) 2024-02-05 06:17:23 +00:00
activity.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
blame.go Use information from previous blame parts (#28572) 2023-12-21 22:48:18 +01:00
branch.go Adjust object format interface (#28469) 2023-12-17 11:56:08 +00:00
cherry_pick.go Upgrade to golangci-lint@v1.55.0 (#27756) 2023-10-24 02:54:59 +00:00
commit.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
compare.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
download.go Less naked returns (#25713) 2023-07-07 05:31:56 +00:00
editor_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
editor.go Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
find.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
githttp_test.go Fix http protocol auth (#27875) 2023-11-02 22:14:33 +08:00
githttp.go Some refactor for git http (#28995) 2024-01-31 15:23:22 +00:00
helper_test.go Make web context initialize correctly for different cases (#26726) 2023-08-25 19:07:42 +08:00
helper.go Improve tree not found page (#26570) 2023-09-29 07:42:39 +00:00
issue_content_history.go Fix missing check (#28406) 2023-12-10 21:37:10 +02:00
issue_dependency.go Upgrade to golangci-lint@v1.55.0 (#27756) 2023-10-24 02:54:59 +00:00
issue_label_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
issue_label.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_lock.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_pin.go Fix missing check (#28406) 2023-12-10 21:37:10 +02:00
issue_stopwatch.go Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
issue_watch.go Introduce htmx and use it to avoid full page load on Subscribe and Follow (#28908) 2024-01-30 15:45:54 +01:00
issue.go Refactor issue template parsing and fix API endpoint (#29069) 2024-02-12 05:04:10 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
middlewares.go Improve user experience for outdated comments (#29050) 2024-02-08 01:50:48 +00:00
migrate.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
milestone.go Refactor issue template parsing and fix API endpoint (#29069) 2024-02-12 05:04:10 +00:00
packages.go Fix the display of org level badges (#26504) 2023-09-06 14:38:14 +08:00
patch.go Upgrade to golangci-lint@v1.55.0 (#27756) 2023-10-24 02:54:59 +00:00
projects_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
projects.go Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
pull_review_test.go Improve user experience for outdated comments (#29050) 2024-02-08 01:50:48 +00:00
pull_review.go Improve user experience for outdated comments (#29050) 2024-02-08 01:50:48 +00:00
pull.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
release_test.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
release.go Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
render.go Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
repo.go Don't do a full page load when clicking Watch or Star (#29001) 2024-02-05 09:56:20 +00:00
search.go Refactor indexer (#25174) 2023-06-23 12:37:56 +00:00
topic.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
treelist.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view.go Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
wiki_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
wiki.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00