Gusted ebe569a268
Set correct PR status on 3way on conflict checking (#19457)
* Set correct PR status on 3way on conflict checking

- When 3-way merge is enabled for conflict checking, it has a new
interesting behavior that it doesn't return any error when it found a
conflict, so we change the condition to not check for the error, but
instead check if conflictedfiles is populated, this fixes a issue
whereby PR status wasn't correctly on conflicted PR's.
- Refactor the mergeable property(which was incorrectly set and lead me this
bug) to be more maintainable.
- Add a dedicated test for conflicting checking, so it should prevent
future issues with this.

* Fix linter
2022-04-21 22:55:45 +01:00
..
2022-01-20 18:46:10 +01:00
2022-03-13 17:40:47 +01:00
2022-01-20 18:46:10 +01:00
2022-04-01 02:15:46 +02:00
2022-01-20 18:46:10 +01:00
2022-01-20 18:46:10 +01:00
2020-10-02 23:37:53 -04:00
2022-01-20 18:46:10 +01:00
2022-03-18 20:17:57 +01:00
2022-01-20 18:46:10 +01:00
2022-01-19 19:31:39 -05:00
2022-01-20 18:46:10 +01:00
2022-01-20 18:46:10 +01:00
2022-04-19 12:55:35 -04:00
2022-01-20 18:46:10 +01:00
2022-01-20 18:46:10 +01:00
2022-03-30 16:42:47 +08:00
2022-01-20 18:46:10 +01:00
2021-12-20 04:41:31 +00:00
2020-04-05 07:20:50 +01:00
2022-01-20 18:46:10 +01:00