Gusted
ebe569a268
Set correct PR status on 3way on conflict checking ( #19457 )
...
* Set correct PR status on 3way on conflict checking
- When 3-way merge is enabled for conflict checking, it has a new
interesting behavior that it doesn't return any error when it found a
conflict, so we change the condition to not check for the error, but
instead check if conflictedfiles is populated, this fixes a issue
whereby PR status wasn't correctly on conflicted PR's.
- Refactor the mergeable property(which was incorrectly set and lead me this
bug) to be more maintainable.
- Add a dedicated test for conflicting checking, so it should prevent
future issues with this.
* Fix linter
2022-04-21 22:55:45 +01:00
..
2022-01-20 18:46:10 +01:00
2021-09-09 21:13:36 +01:00
2022-04-14 21:58:21 +08:00
2022-03-13 17:40:47 +01:00
2022-01-20 18:46:10 +01:00
2022-04-01 02:15:46 +02:00
2022-04-02 00:34:57 +08:00
2022-02-26 16:48:23 +00:00
2022-03-31 17:20:39 +08:00
2022-04-21 17:17:57 +02:00
2022-04-21 22:55:45 +01:00
2022-01-20 18:46:10 +01:00
2022-04-01 10:55:30 +08:00
2022-01-20 18:46:10 +01:00
2022-03-31 19:01:43 +02:00
2022-01-26 12:10:10 +08:00
2022-04-20 17:52:16 +02:00
2022-04-01 10:55:30 +08:00
2022-03-31 19:01:43 +02:00
2020-10-02 23:37:53 -04:00
2022-01-20 18:46:10 +01:00
2022-03-18 20:17:57 +01:00
2022-01-20 18:46:10 +01:00
2022-01-19 19:31:39 -05:00
2022-04-14 21:58:21 +08:00
2022-04-01 16:47:50 +08:00
2022-03-23 12:54:07 +08:00
2022-03-31 19:01:43 +02:00
2022-04-03 17:46:48 +08:00
2022-01-20 18:46:10 +01:00
2022-03-17 18:08:35 +01:00
2022-04-02 00:34:57 +08:00
2022-04-14 21:58:21 +08:00
2022-01-20 18:46:10 +01:00
2022-04-19 12:55:35 -04:00
2022-04-03 17:46:48 +08:00
2021-06-07 07:27:09 +02:00
2021-09-22 13:38:34 +08:00
2022-03-31 19:01:43 +02:00
2022-03-31 19:01:43 +02:00
2021-08-19 16:41:20 -04:00
2022-01-23 20:19:49 +08:00
2022-04-02 15:59:04 +08:00
2021-09-22 13:38:34 +08:00
2022-01-20 18:46:10 +01:00
2022-04-14 21:58:21 +08:00
2022-02-04 18:03:15 +01:00
2022-01-20 18:46:10 +01:00
2022-04-10 19:57:36 +08:00
2022-03-31 19:01:43 +02:00
2022-03-30 16:42:47 +08:00
2022-04-20 09:20:53 +01:00
2021-09-22 13:38:34 +08:00
2022-04-02 00:34:57 +08:00
2022-04-01 16:47:50 +08:00
2022-03-30 03:13:41 +08:00
2022-04-03 17:46:48 +08:00
2022-04-03 17:46:48 +08:00
2022-01-20 18:46:10 +01:00
2022-01-20 18:46:10 +01:00
2021-12-20 04:41:31 +00:00
2021-12-23 16:27:33 +00:00
2020-04-05 07:20:50 +01:00
2022-04-02 00:34:57 +08:00
2022-01-20 18:46:10 +01:00
2022-04-08 13:21:05 +08:00