githaven/templates/repo/issue/labels
delvh e95b42e187
Improve accessibility when (re-)viewing files (#24817)
Visually, nothing should have changed.
Changes include
- Convert most `<a [no href]>` to `<button>` when (re-)viewing files:
- `<a [no href]>` are, by HTML definition, not a link and hence cannot
be focused
- `<a class="ui button">` can now be clicked (again?) using
<kbd>Enter</kbd>
- Previously, the installed keypress handler on `.ui.button` elements
disabled it for links somehow
- The `(un)escape file`, the `expand section` and the `expand/collapse
file` buttons can now be focused (and subsequently clicked using only
the keyboard)
- You can now press <kbd>Space</kbd> on a focused `View file` checkbox
to mark the file as viewed.
- previously, this was impossible as this checkbox listened on the wrong
event listener

The `add code comment` button has been left inaccessible for now as it
requires quite a bit of extra logic so that it is unhidden when it is
focused (you can otherwise focus it without seeing it as you are not
hovering on the corresponding line).

---------

Co-authored-by: silverwind <me@silverwind.io>
2023-05-21 20:47:41 +00:00
..
edit_delete_label.tmpl Remove font-awesome and fomantic icon module (#24471) 2023-05-01 13:25:54 -04:00
label_list.tmpl Start cleaning the messy ".ui.left / .ui.right", improve label list page, fix stackable menu (#24393) 2023-04-29 07:35:59 -04:00
label_load_template.tmpl Make label templates have consistent behavior and priority (#23749) 2023-04-10 16:44:02 +08:00
label_new.tmpl Remove "inverted" class on creating new label and cancel buttons (#24030) 2023-04-10 20:00:30 +08:00
label.tmpl Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
labels_selector_field.tmpl Improve accessibility when (re-)viewing files (#24817) 2023-05-21 20:47:41 +00:00
labels_sidebar.tmpl Refactor ctx in templates (#23105) 2023-03-02 11:44:06 -06:00