githaven/comment.yml at e5160185ed65fd1c2bcb2fc7dc7e0b5514ddb299 - githaven - GitHaven

Shiloh/githaven

Lunny Xiao 45277486c2

Fix bug hidden on CI and make ci failed if tests failure (#29254 )

The tests on migration tests failed but CI reports successfully


https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141

This PR will fix the bug on migration v283 and also the CI hidden
behaviour.

The reason is on the Makefile

`GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will
return the error exit code.

But 

`for pkg in $(shell $(GO) list
code.gitea.io/gitea/models/migrations/...); do \
GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test
$(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \
	done`

will not work.

This also fix #29602

2024-03-07 17:43:32 +01:00

4 lines

65 B

YAML

Raw Blame History

	`-`
	`id: 1`
	`commit_sha: 19fe5caf872476db265596eaac1dc35ad1c6422d`