45277486c2
The tests on migration tests failed but CI reports successfully https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141 This PR will fix the bug on migration v283 and also the CI hidden behaviour. The reason is on the Makefile `GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test $(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will return the error exit code. But `for pkg in $(shell $(GO) list code.gitea.io/gitea/models/migrations/...); do \ GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test $(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \ done` will not work. This also fix #29602
48 lines
1.3 KiB
Go
48 lines
1.3 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_22 //nolint
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"xorm.io/xorm"
|
|
"xorm.io/xorm/schemas"
|
|
)
|
|
|
|
func AddCombinedIndexToIssueUser(x *xorm.Engine) error {
|
|
type OldIssueUser struct {
|
|
IssueID int64
|
|
UID int64
|
|
Cnt int64
|
|
}
|
|
|
|
var duplicatedIssueUsers []OldIssueUser
|
|
if err := x.SQL("select * from (select issue_id, uid, count(1) as cnt from issue_user group by issue_id, uid) a where a.cnt > 1").
|
|
Find(&duplicatedIssueUsers); err != nil {
|
|
return err
|
|
}
|
|
for _, issueUser := range duplicatedIssueUsers {
|
|
if x.Dialect().URI().DBType == schemas.MSSQL {
|
|
if _, err := x.Exec(fmt.Sprintf("delete from issue_user where id in (SELECT top %d id FROM issue_user WHERE issue_id = ? and uid = ?)", issueUser.Cnt-1), issueUser.IssueID, issueUser.UID); err != nil {
|
|
return err
|
|
}
|
|
} else {
|
|
var ids []int64
|
|
if err := x.SQL("SELECT id FROM issue_user WHERE issue_id = ? and uid = ? limit ?", issueUser.IssueID, issueUser.UID, issueUser.Cnt-1).Find(&ids); err != nil {
|
|
return err
|
|
}
|
|
if _, err := x.Table("issue_user").In("id", ids).Delete(); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
type IssueUser struct {
|
|
UID int64 `xorm:"INDEX unique(uid_to_issue)"` // User ID.
|
|
IssueID int64 `xorm:"INDEX unique(uid_to_issue)"`
|
|
}
|
|
|
|
return x.Sync(&IssueUser{})
|
|
}
|