Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
ca905b82df
githaven/options/locale
History
Hester Gong ca905b82df
Append (comment) when a link points at a comment rather than the whole issue (#23734) 
Close #23671 

For the feature mentioned above, this PR append ' (comment)' to the
rendered html if it is a hashcomment.
After the PR, type in the following

```
pull request from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2

pull request from this repo:
http://localhost:3000/aaa/testA/pulls/2

issue comment from this repo:
http://localhost:3000/aaa/testA/issues/1#issuecomment-18

http://localhost:3000/aaa/testA/pulls/2#issue-9

issue comment from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2#issuecomment-24

http://localhost:3000/testOrg/testOrgRepo/pulls/2#issue
```
Gives:
<img width="687" alt="截屏2023-03-27 13 53 06"
src="https://user-images.githubusercontent.com/17645053/227852387-2b218e0d-3468-4d90-ad81-d702ddd17fd2.png">



Other than the above feature, this PR also includes two other changes:

1 Right now, the render of links from file changed tab in pull request
might not be very proper, for example, if type in the following. (not
sure if this is an issue or design, if not an issue, I will revert the
changes). example on
[try.gitea.io](https://try.gitea.io/HesterG/testrepo/pulls/1)
```
https://try.gitea.io/HesterG/testrepo/pulls/1/files#issuecomment-162725
https://try.gitea.io/HesterG/testrepo/pulls/1/files
```
it will render the following 
<img width="899" alt="截屏2023-03-24 15 41 37"
src="https://user-images.githubusercontent.com/17645053/227456117-5eccedb7-9118-4540-929d-aee9a76de852.png">

In this PR, skip processing the link into a ref issue if it is a link
from files changed tab in pull request

After:
type in following
```
hash comment on files changed tab:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files#issuecomment-24

files changed link:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files
```
Gives

<img width="708" alt="截屏2023-03-27 22 09 02"
src="https://user-images.githubusercontent.com/17645053/227964273-5dc06c50-3713-489c-b05d-d95367d0ab0f.png">

2 Right now, after editing the comment area, there will not be tippys
attached to `ref-issue`; and no tippy attached on preview as well.
example:

https://user-images.githubusercontent.com/17645053/227850540-5ae34e2d-b1d7-4d0d-9726-7701bf825d1f.mov

In this PR, in frontend, make sure tippy is added after editing the
comment, and to the comment on preview tab
After:

https://user-images.githubusercontent.com/17645053/227853777-06f56b4c-1148-467c-b6f7-f79418e67504.mov
2023-04-03 16:02:57 +08:00
..
locale_cs-CZ.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_de-DE.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_el-GR.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_en-US.ini Append (comment) when a link points at a comment rather than the whole issue (#23734) 2023-04-03 16:02:57 +08:00
locale_es-ES.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_fa-IR.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_fi-FI.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_fr-FR.ini [skip ci] Updated translations via Crowdin 2023-04-03 00:06:56 +00:00
locale_hu-HU.ini [skip ci] Updated translations via Crowdin 2023-03-26 00:16:31 +00:00
locale_id-ID.ini [skip ci] Updated translations via Crowdin 2023-03-26 00:16:31 +00:00
locale_is-IS.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_it-IT.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_ja-JP.ini [skip ci] Updated translations via Crowdin 2023-03-31 00:07:06 +00:00
locale_ko-KR.ini [skip ci] Updated translations via Crowdin 2023-03-26 00:16:31 +00:00
locale_lv-LV.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_nl-NL.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_pl-PL.ini [skip ci] Updated translations via Crowdin 2023-04-03 00:06:56 +00:00
locale_pt-BR.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_pt-PT.ini [skip ci] Updated translations via Crowdin 2023-04-02 00:06:59 +00:00
locale_ru-RU.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_si-LK.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_sk-SK.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_sv-SE.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_tr-TR.ini [skip ci] Updated translations via Crowdin 2023-04-03 00:06:56 +00:00
locale_uk-UA.ini [skip ci] Updated translations via Crowdin 2023-03-30 00:06:54 +00:00
locale_zh-CN.ini [skip ci] Updated translations via Crowdin 2023-04-02 00:06:59 +00:00
locale_zh-HK.ini [skip ci] Updated translations via Crowdin 2023-03-25 00:16:30 +00:00
locale_zh-TW.ini [skip ci] Updated translations via Crowdin 2023-04-03 00:06:56 +00:00
TRANSLATORS Fix missing left and right carets in TRANSLATORS (#21397) 2022-10-10 10:36:37 -04:00