c53ad052d8
Some bugs caused by less unit tests in fundamental packages. This PR refactor `setting` package so that create a unit test will be easier than before. - All `LoadFromXXX` files has been splited as two functions, one is `InitProviderFromXXX` and `LoadCommonSettings`. The first functions will only include the code to create or new a ini file. The second function will load common settings. - It also renames all functions in setting from `newXXXService` to `loadXXXSetting` or `loadXXXFrom` to make the function name less confusing. - Move `XORMLog` to `SQLLog` because it's a better name for that. Maybe we should finally move these `loadXXXSetting` into the `XXXInit` function? Any idea? --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: delvh <dev.lh@web.de>
44 lines
916 B
Go
44 lines
916 B
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
ini "gopkg.in/ini.v1"
|
|
)
|
|
|
|
func Test_loadMailerFrom(t *testing.T) {
|
|
iniFile := ini.Empty()
|
|
kases := map[string]*Mailer{
|
|
"smtp.mydomain.com": {
|
|
SMTPAddr: "smtp.mydomain.com",
|
|
SMTPPort: "465",
|
|
},
|
|
"smtp.mydomain.com:123": {
|
|
SMTPAddr: "smtp.mydomain.com",
|
|
SMTPPort: "123",
|
|
},
|
|
":123": {
|
|
SMTPAddr: "127.0.0.1",
|
|
SMTPPort: "123",
|
|
},
|
|
}
|
|
for host, kase := range kases {
|
|
t.Run(host, func(t *testing.T) {
|
|
iniFile.DeleteSection("mailer")
|
|
sec := iniFile.Section("mailer")
|
|
sec.NewKey("ENABLED", "true")
|
|
sec.NewKey("HOST", host)
|
|
|
|
// Check mailer setting
|
|
loadMailerFrom(iniFile)
|
|
|
|
assert.EqualValues(t, kase.SMTPAddr, MailService.SMTPAddr)
|
|
assert.EqualValues(t, kase.SMTPPort, MailService.SMTPPort)
|
|
})
|
|
}
|
|
}
|