ca46385637
* Use PathUnescape instead of QueryUnescape when working with branch names Currently branch names with a '+' fail in certain situations because QueryUnescape replaces the + character with a blank space. Using PathUnescape should be better since it is defined as: // PathUnescape is identical to QueryUnescape except that it does not // unescape '+' to ' ' (space). Fixes #6333 * Change error to match new function name * Add new util function PathEscapeSegments This function simply runs PathEscape on each segment of a path without touching the forward slash itself. We want to use this instead of PathEscape/QueryEscape in most cases because a forward slash is a valid name for a branch etc... and we don't want that escaped in a URL. Putting this in new file url.go and also moving a couple similar functions into that file as well. * Use EscapePathSegments where appropriate Replace various uses of EscapePath/EscapeQuery with new EscapePathSegments. Also remove uncessary uses of various escape/unescape functions when the text had already been escaped or was not escaped. * Reformat comment to make drone build happy * Remove no longer used url library * Requested code changes |
||
---|---|---|
.. | ||
activity.go | ||
attachment.go | ||
branch.go | ||
commit.go | ||
download.go | ||
editor_test.go | ||
editor.go | ||
http.go | ||
issue_dependency.go | ||
issue_label_test.go | ||
issue_label.go | ||
issue_lock.go | ||
issue_stopwatch.go | ||
issue_timetrack.go | ||
issue_watch.go | ||
issue.go | ||
main_test.go | ||
middlewares.go | ||
milestone.go | ||
pull_review.go | ||
pull.go | ||
release_test.go | ||
release.go | ||
repo.go | ||
search.go | ||
setting_protected_branch.go | ||
setting.go | ||
settings_test.go | ||
topic.go | ||
view.go | ||
webhook.go | ||
wiki_test.go | ||
wiki.go |