Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
aa45777c92
githaven/modules/lfs
History
sillyguodong 51ab495198
escape filename when assemble URL (#22850) 
Fixes: #22843 

### Cause:

affdd40296/services/repository/files/content.go (L161)

Previously, we did not escape the **"%"** that might be in "treePath"
when call "url.parse()".


![image](https://user-images.githubusercontent.com/33891828/218066318-5a909e50-2a17-46e6-b32f-684b2aa4b91f.png)

This function will check whether "%" is the beginning of an escape
character. Obviously, the "%" in the example (hello%mother.txt) is not
that. So, the function will return a error.

### Solution:
We can escape "treePath" by call "url.PathEscape()" function firstly.

### Screenshot:

![image](https://user-images.githubusercontent.com/33891828/218069781-1a030f8b-18d0-4804-b0f8-73997849ef43.png)

---------

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Andrew Thornton <art27@cantab.net>
2023-02-12 09:31:14 +08:00
..
client_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
client.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
content_store.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
endpoint_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
endpoint.go escape filename when assemble URL (#22850) 2023-02-12 09:31:14 +08:00
filesystem_client.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
http_client_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
http_client.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
LICENSE Git LFS support v2 (#122) 2016-12-26 09:16:37 +08:00
pointer_scanner_gogit.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pointer_scanner_nogogit.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pointer_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pointer.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
shared.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
transferadapter_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
transferadapter.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00