48d4580dd5
Follow #30495 "HasAccess" behavior wasn't clear, to make it clear: * Use a new name `HasAnyUnitAccess`, it will be easier to review related code and permission problems. * Separate everyone access mode to a separate field, then all calls to HasAccess are reverted to old behavior before #30495. * Add new tests. --------- Co-authored-by: Giteabot <teabot@gitea.io>
127 lines
4.6 KiB
Go
127 lines
4.6 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package access_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
perm_model "code.gitea.io/gitea/models/perm"
|
|
access_model "code.gitea.io/gitea/models/perm/access"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAccessLevel(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
user5 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 5})
|
|
user29 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 29})
|
|
// A public repository owned by User 2
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
assert.False(t, repo1.IsPrivate)
|
|
// A private repository owned by Org 3
|
|
repo3 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})
|
|
assert.True(t, repo3.IsPrivate)
|
|
|
|
// Another public repository
|
|
repo4 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 4})
|
|
assert.False(t, repo4.IsPrivate)
|
|
// org. owned private repo
|
|
repo24 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 24})
|
|
|
|
level, err := access_model.AccessLevel(db.DefaultContext, user2, repo1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeOwner, level)
|
|
|
|
level, err = access_model.AccessLevel(db.DefaultContext, user2, repo3)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeOwner, level)
|
|
|
|
level, err = access_model.AccessLevel(db.DefaultContext, user5, repo1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeRead, level)
|
|
|
|
level, err = access_model.AccessLevel(db.DefaultContext, user5, repo3)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeNone, level)
|
|
|
|
// restricted user has no access to a public repo
|
|
level, err = access_model.AccessLevel(db.DefaultContext, user29, repo1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeNone, level)
|
|
|
|
// ... unless he's a collaborator
|
|
level, err = access_model.AccessLevel(db.DefaultContext, user29, repo4)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeWrite, level)
|
|
|
|
// ... or a team member
|
|
level, err = access_model.AccessLevel(db.DefaultContext, user29, repo24)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, perm_model.AccessModeRead, level)
|
|
}
|
|
|
|
func TestHasAccess(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user1 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 5})
|
|
// A public repository owned by User 2
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
assert.False(t, repo1.IsPrivate)
|
|
// A private repository owned by Org 3
|
|
repo2 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})
|
|
assert.True(t, repo2.IsPrivate)
|
|
|
|
has, err := access_model.HasAnyUnitAccess(db.DefaultContext, user1.ID, repo1)
|
|
assert.NoError(t, err)
|
|
assert.True(t, has)
|
|
|
|
_, err = access_model.HasAnyUnitAccess(db.DefaultContext, user1.ID, repo2)
|
|
assert.NoError(t, err)
|
|
|
|
_, err = access_model.HasAnyUnitAccess(db.DefaultContext, user2.ID, repo1)
|
|
assert.NoError(t, err)
|
|
|
|
_, err = access_model.HasAnyUnitAccess(db.DefaultContext, user2.ID, repo2)
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestRepository_RecalculateAccesses(t *testing.T) {
|
|
// test with organization repo
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})
|
|
assert.NoError(t, repo1.LoadOwner(db.DefaultContext))
|
|
|
|
_, err := db.GetEngine(db.DefaultContext).Delete(&repo_model.Collaboration{UserID: 2, RepoID: 3})
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, access_model.RecalculateAccesses(db.DefaultContext, repo1))
|
|
|
|
access := &access_model.Access{UserID: 2, RepoID: 3}
|
|
has, err := db.GetEngine(db.DefaultContext).Get(access)
|
|
assert.NoError(t, err)
|
|
assert.True(t, has)
|
|
assert.Equal(t, perm_model.AccessModeOwner, access.Mode)
|
|
}
|
|
|
|
func TestRepository_RecalculateAccesses2(t *testing.T) {
|
|
// test with non-organization repo
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 4})
|
|
assert.NoError(t, repo1.LoadOwner(db.DefaultContext))
|
|
|
|
_, err := db.GetEngine(db.DefaultContext).Delete(&repo_model.Collaboration{UserID: 4, RepoID: 4})
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, access_model.RecalculateAccesses(db.DefaultContext, repo1))
|
|
|
|
has, err := db.GetEngine(db.DefaultContext).Get(&access_model.Access{UserID: 4, RepoID: 4})
|
|
assert.NoError(t, err)
|
|
assert.False(t, has)
|
|
}
|