ee242a08e9
The old code `GetTemplatesFromDefaultBranch(...) ([]*api.IssueTemplate, map[string]error)` doesn't really follow Golang's habits, then the second returned value might be misused. For example, the API function `GetIssueTemplates` incorrectly checked the second returned value and always responds 500 error. This PR refactors GetTemplatesFromDefaultBranch to ParseTemplatesFromDefaultBranch and clarifies its behavior, and fixes the API endpoint bug, and adds some tests. And by the way, add proper prefix `X-` for the header generated in `checkDeprecatedAuthMethods`, because non-standard HTTP headers should have `X-` prefix, and it is also consistent with the new code in `GetIssueTemplates`
56 lines
1.8 KiB
Go
56 lines
1.8 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"net/url"
|
|
"testing"
|
|
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAPIIssueTemplateList(t *testing.T) {
|
|
onGiteaRun(t, func(*testing.T, *url.URL) {
|
|
var issueTemplates []*api.IssueTemplate
|
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{Name: "user2"})
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{OwnerName: "user2", Name: "repo1"})
|
|
|
|
// no issue template
|
|
req := NewRequest(t, "GET", "/api/v1/repos/user2/repo1/issue_templates")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
issueTemplates = nil
|
|
DecodeJSON(t, resp, &issueTemplates)
|
|
assert.Empty(t, issueTemplates)
|
|
|
|
// one correct issue template and some incorrect issue templates
|
|
err := createOrReplaceFileInBranch(user, repo, ".gitea/ISSUE_TEMPLATE/tmpl-ok.md", repo.DefaultBranch, `----
|
|
name: foo
|
|
about: bar
|
|
----
|
|
`)
|
|
assert.NoError(t, err)
|
|
|
|
err = createOrReplaceFileInBranch(user, repo, ".gitea/ISSUE_TEMPLATE/tmpl-err1.yml", repo.DefaultBranch, `name: '`)
|
|
assert.NoError(t, err)
|
|
|
|
err = createOrReplaceFileInBranch(user, repo, ".gitea/ISSUE_TEMPLATE/tmpl-err2.yml", repo.DefaultBranch, `other: `)
|
|
assert.NoError(t, err)
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/repos/user2/repo1/issue_templates")
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
issueTemplates = nil
|
|
DecodeJSON(t, resp, &issueTemplates)
|
|
assert.Len(t, issueTemplates, 1)
|
|
assert.Equal(t, "foo", issueTemplates[0].Name)
|
|
assert.Equal(t, "error occurs when parsing issue template: count=2", resp.Header().Get("X-Gitea-Warning"))
|
|
})
|
|
}
|