githaven/templates/repo/issue
delvh e95b42e187
Improve accessibility when (re-)viewing files (#24817)
Visually, nothing should have changed.
Changes include
- Convert most `<a [no href]>` to `<button>` when (re-)viewing files:
- `<a [no href]>` are, by HTML definition, not a link and hence cannot
be focused
- `<a class="ui button">` can now be clicked (again?) using
<kbd>Enter</kbd>
- Previously, the installed keypress handler on `.ui.button` elements
disabled it for links somehow
- The `(un)escape file`, the `expand section` and the `expand/collapse
file` buttons can now be focused (and subsequently clicked using only
the keyboard)
- You can now press <kbd>Space</kbd> on a focused `View file` checkbox
to mark the file as viewed.
- previously, this was impossible as this checkbox listened on the wrong
event listener

The `add code comment` button has been left inaccessible for now as it
requires quite a bit of extra logic so that it is unhidden when it is
focused (you can otherwise focus it without seeing it as you are not
hovering on the corresponding line).

---------

Co-authored-by: silverwind <me@silverwind.io>
2023-05-21 20:47:41 +00:00
..
fields Support markdown editor for issue template (#24400) 2023-05-08 22:22:52 +00:00
labels Improve accessibility when (re-)viewing files (#24817) 2023-05-21 20:47:41 +00:00
milestone Improve milestone filter on issues page (#22423) 2023-04-30 09:12:49 -04:00
view_content Clean up various avatar dimensions (#24701) 2023-05-14 14:15:59 +00:00
branch_selector_field.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
choose.tmpl Implement Issue Config (#20956) 2023-03-28 14:22:07 -04:00
comment_tab.tmpl Improve markdown editor: width, height, preferred (#23895) 2023-04-07 13:03:29 -04:00
label_precolors.tmpl Fix purple color in suggested label colors (#18241) 2022-01-11 12:11:40 -06:00
labels.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
list.tmpl Support no label/assignee filter and batch clearing labels/assignees (#24707) 2023-05-17 17:21:35 +08:00
milestone_issues.tmpl Notification list enhancements, fix striped tables on dark theme (#24639) 2023-05-10 21:59:58 +00:00
milestone_new.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
milestones.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
navbar.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
new_form.tmpl Support markdown editor for issue template (#24400) 2023-05-08 22:22:52 +00:00
new.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
openclose.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
search.tmpl Improve "goto issue by number" button (#24577) 2023-05-10 15:50:58 +00:00
view_content.tmpl Clean up various avatar dimensions (#24701) 2023-05-14 14:15:59 +00:00
view_title.tmpl Improve accessibility when (re-)viewing files (#24817) 2023-05-21 20:47:41 +00:00
view.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00