e95b42e187
Visually, nothing should have changed. Changes include - Convert most `<a [no href]>` to `<button>` when (re-)viewing files: - `<a [no href]>` are, by HTML definition, not a link and hence cannot be focused - `<a class="ui button">` can now be clicked (again?) using <kbd>Enter</kbd> - Previously, the installed keypress handler on `.ui.button` elements disabled it for links somehow - The `(un)escape file`, the `expand section` and the `expand/collapse file` buttons can now be focused (and subsequently clicked using only the keyboard) - You can now press <kbd>Space</kbd> on a focused `View file` checkbox to mark the file as viewed. - previously, this was impossible as this checkbox listened on the wrong event listener The `add code comment` button has been left inaccessible for now as it requires quite a bit of extra logic so that it is unhidden when it is focused (you can otherwise focus it without seeing it as you are not hovering on the corresponding line). --------- Co-authored-by: silverwind <me@silverwind.io> |
||
---|---|---|
.. | ||
blob_excerpt.tmpl | ||
box.tmpl | ||
comment_form_datahandler.tmpl | ||
comment_form.tmpl | ||
comments.tmpl | ||
compare.tmpl | ||
conversation.tmpl | ||
csv_diff.tmpl | ||
escape_title.tmpl | ||
image_diff.tmpl | ||
new_comment.tmpl | ||
new_review.tmpl | ||
options_dropdown.tmpl | ||
section_code.tmpl | ||
section_split.tmpl | ||
section_unified.tmpl | ||
stats.tmpl | ||
whitespace_dropdown.tmpl |