* API: orgEditTeam make Fields optional * add TestCase * Update integrations/api_team_test.go * suggestions from lafriks use len() to check if string is empty Co-Authored-By: Lauris BH <lauris@nix.lv> * change ... * use Where not ID to get mssql * add return and code format * fix test * fix test ... null pointer exept * update specific colums * only specific colums too Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
		
			
				
	
	
		
			161 lines
		
	
	
		
			6.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			161 lines
		
	
	
		
			6.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2017 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package integrations
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"net/http"
 | |
| 	"sort"
 | |
| 	"testing"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models"
 | |
| 	"code.gitea.io/gitea/modules/convert"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestAPITeam(t *testing.T) {
 | |
| 	defer prepareTestEnv(t)()
 | |
| 
 | |
| 	teamUser := models.AssertExistsAndLoadBean(t, &models.TeamUser{}).(*models.TeamUser)
 | |
| 	team := models.AssertExistsAndLoadBean(t, &models.Team{ID: teamUser.TeamID}).(*models.Team)
 | |
| 	user := models.AssertExistsAndLoadBean(t, &models.User{ID: teamUser.UID}).(*models.User)
 | |
| 
 | |
| 	session := loginUser(t, user.Name)
 | |
| 	token := getTokenForLoggedInUser(t, session)
 | |
| 	req := NewRequestf(t, "GET", "/api/v1/teams/%d?token="+token, teamUser.TeamID)
 | |
| 	resp := session.MakeRequest(t, req, http.StatusOK)
 | |
| 
 | |
| 	var apiTeam api.Team
 | |
| 	DecodeJSON(t, resp, &apiTeam)
 | |
| 	assert.EqualValues(t, team.ID, apiTeam.ID)
 | |
| 	assert.Equal(t, team.Name, apiTeam.Name)
 | |
| 
 | |
| 	// non team member user will not access the teams details
 | |
| 	teamUser2 := models.AssertExistsAndLoadBean(t, &models.TeamUser{ID: 3}).(*models.TeamUser)
 | |
| 	user2 := models.AssertExistsAndLoadBean(t, &models.User{ID: teamUser2.UID}).(*models.User)
 | |
| 
 | |
| 	session = loginUser(t, user2.Name)
 | |
| 	token = getTokenForLoggedInUser(t, session)
 | |
| 	req = NewRequestf(t, "GET", "/api/v1/teams/%d?token="+token, teamUser.TeamID)
 | |
| 	_ = session.MakeRequest(t, req, http.StatusForbidden)
 | |
| 
 | |
| 	req = NewRequestf(t, "GET", "/api/v1/teams/%d", teamUser.TeamID)
 | |
| 	_ = session.MakeRequest(t, req, http.StatusUnauthorized)
 | |
| 
 | |
| 	// Get an admin user able to create, update and delete teams.
 | |
| 	user = models.AssertExistsAndLoadBean(t, &models.User{ID: 1}).(*models.User)
 | |
| 	session = loginUser(t, user.Name)
 | |
| 	token = getTokenForLoggedInUser(t, session)
 | |
| 
 | |
| 	org := models.AssertExistsAndLoadBean(t, &models.User{ID: 6}).(*models.User)
 | |
| 
 | |
| 	// Create team.
 | |
| 	teamToCreate := &api.CreateTeamOption{
 | |
| 		Name:                    "team1",
 | |
| 		Description:             "team one",
 | |
| 		IncludesAllRepositories: true,
 | |
| 		Permission:              "write",
 | |
| 		Units:                   []string{"repo.code", "repo.issues"},
 | |
| 	}
 | |
| 	req = NewRequestWithJSON(t, "POST", fmt.Sprintf("/api/v1/orgs/%s/teams?token=%s", org.Name, token), teamToCreate)
 | |
| 	resp = session.MakeRequest(t, req, http.StatusCreated)
 | |
| 	DecodeJSON(t, resp, &apiTeam)
 | |
| 	checkTeamResponse(t, &apiTeam, teamToCreate.Name, teamToCreate.Description, teamToCreate.IncludesAllRepositories,
 | |
| 		teamToCreate.Permission, teamToCreate.Units)
 | |
| 	checkTeamBean(t, apiTeam.ID, teamToCreate.Name, teamToCreate.Description, teamToCreate.IncludesAllRepositories,
 | |
| 		teamToCreate.Permission, teamToCreate.Units)
 | |
| 	teamID := apiTeam.ID
 | |
| 
 | |
| 	// Edit team.
 | |
| 	editDescription := "team 1"
 | |
| 	editFalse := false
 | |
| 	teamToEdit := &api.EditTeamOption{
 | |
| 		Name:                    "teamone",
 | |
| 		Description:             &editDescription,
 | |
| 		Permission:              "admin",
 | |
| 		IncludesAllRepositories: &editFalse,
 | |
| 		Units:                   []string{"repo.code", "repo.pulls", "repo.releases"},
 | |
| 	}
 | |
| 
 | |
| 	req = NewRequestWithJSON(t, "PATCH", fmt.Sprintf("/api/v1/teams/%d?token=%s", teamID, token), teamToEdit)
 | |
| 	resp = session.MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiTeam)
 | |
| 	checkTeamResponse(t, &apiTeam, teamToEdit.Name, *teamToEdit.Description, *teamToEdit.IncludesAllRepositories,
 | |
| 		teamToEdit.Permission, teamToEdit.Units)
 | |
| 	checkTeamBean(t, apiTeam.ID, teamToEdit.Name, *teamToEdit.Description, *teamToEdit.IncludesAllRepositories,
 | |
| 		teamToEdit.Permission, teamToEdit.Units)
 | |
| 
 | |
| 	// Edit team Description only
 | |
| 	editDescription = "first team"
 | |
| 	teamToEditDesc := api.EditTeamOption{Description: &editDescription}
 | |
| 	req = NewRequestWithJSON(t, "PATCH", fmt.Sprintf("/api/v1/teams/%d?token=%s", teamID, token), teamToEditDesc)
 | |
| 	resp = session.MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiTeam)
 | |
| 	checkTeamResponse(t, &apiTeam, teamToEdit.Name, *teamToEditDesc.Description, *teamToEdit.IncludesAllRepositories,
 | |
| 		teamToEdit.Permission, teamToEdit.Units)
 | |
| 	checkTeamBean(t, apiTeam.ID, teamToEdit.Name, *teamToEditDesc.Description, *teamToEdit.IncludesAllRepositories,
 | |
| 		teamToEdit.Permission, teamToEdit.Units)
 | |
| 
 | |
| 	// Read team.
 | |
| 	teamRead := models.AssertExistsAndLoadBean(t, &models.Team{ID: teamID}).(*models.Team)
 | |
| 	req = NewRequestf(t, "GET", "/api/v1/teams/%d?token="+token, teamID)
 | |
| 	resp = session.MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiTeam)
 | |
| 	checkTeamResponse(t, &apiTeam, teamRead.Name, *teamToEditDesc.Description, teamRead.IncludesAllRepositories,
 | |
| 		teamRead.Authorize.String(), teamRead.GetUnitNames())
 | |
| 
 | |
| 	// Delete team.
 | |
| 	req = NewRequestf(t, "DELETE", "/api/v1/teams/%d?token="+token, teamID)
 | |
| 	session.MakeRequest(t, req, http.StatusNoContent)
 | |
| 	models.AssertNotExistsBean(t, &models.Team{ID: teamID})
 | |
| }
 | |
| 
 | |
| func checkTeamResponse(t *testing.T, apiTeam *api.Team, name, description string, includesAllRepositories bool, permission string, units []string) {
 | |
| 	assert.Equal(t, name, apiTeam.Name, "name")
 | |
| 	assert.Equal(t, description, apiTeam.Description, "description")
 | |
| 	assert.Equal(t, includesAllRepositories, apiTeam.IncludesAllRepositories, "includesAllRepositories")
 | |
| 	assert.Equal(t, permission, apiTeam.Permission, "permission")
 | |
| 	sort.StringSlice(units).Sort()
 | |
| 	sort.StringSlice(apiTeam.Units).Sort()
 | |
| 	assert.EqualValues(t, units, apiTeam.Units, "units")
 | |
| }
 | |
| 
 | |
| func checkTeamBean(t *testing.T, id int64, name, description string, includesAllRepositories bool, permission string, units []string) {
 | |
| 	team := models.AssertExistsAndLoadBean(t, &models.Team{ID: id}).(*models.Team)
 | |
| 	assert.NoError(t, team.GetUnits(), "GetUnits")
 | |
| 	checkTeamResponse(t, convert.ToTeam(team), name, description, includesAllRepositories, permission, units)
 | |
| }
 | |
| 
 | |
| type TeamSearchResults struct {
 | |
| 	OK   bool        `json:"ok"`
 | |
| 	Data []*api.Team `json:"data"`
 | |
| }
 | |
| 
 | |
| func TestAPITeamSearch(t *testing.T) {
 | |
| 	defer prepareTestEnv(t)()
 | |
| 
 | |
| 	user := models.AssertExistsAndLoadBean(t, &models.User{ID: 2}).(*models.User)
 | |
| 	org := models.AssertExistsAndLoadBean(t, &models.User{ID: 3}).(*models.User)
 | |
| 
 | |
| 	var results TeamSearchResults
 | |
| 
 | |
| 	session := loginUser(t, user.Name)
 | |
| 	req := NewRequestf(t, "GET", "/api/v1/orgs/%s/teams/search?q=%s", org.Name, "_team")
 | |
| 	resp := session.MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &results)
 | |
| 	assert.NotEmpty(t, results.Data)
 | |
| 	assert.Equal(t, 1, len(results.Data))
 | |
| 	assert.Equal(t, "test_team", results.Data[0].Name)
 | |
| 
 | |
| 	// no access if not organization member
 | |
| 	user5 := models.AssertExistsAndLoadBean(t, &models.User{ID: 5}).(*models.User)
 | |
| 	session = loginUser(t, user5.Name)
 | |
| 	req = NewRequestf(t, "GET", "/api/v1/orgs/%s/teams/search?q=%s", org.Name, "team")
 | |
| 	resp = session.MakeRequest(t, req, http.StatusForbidden)
 | |
| 
 | |
| }
 |