wxiaoguang
26ee66327f
Split issue edit code from repo-legacy.js into its own file ( #30419 )
...
Follow Split `index.js` to separate files (#17315 )
It's time to move some code away from the messy "legacy" file.
2024-04-12 02:22:59 +08:00
Zettat123
0fe9f93eb4
Check the token's owner and repository when registering a runner ( #30406 )
...
Fix #30378
2024-04-11 16:01:44 +08:00
yp05327
96d31fe0a8
Avoid user does not exist error when detecting schedule actions when the commit author is an external user ( #30357 )
...
When repo is a mirror, and commit author is an external user, then
`GetUserByEmail` will return error.
reproduce/test:
- mirror Gitea to your instance
- disable action and enable it again, this will trigger
`DetectAndHandleSchedules`
ps: also follow #24706 , it only fixed normal runs, not scheduled runs.
2024-04-11 15:11:32 +08:00
Lunny Xiao
f3cc00626b
Update actions variables documents ( #30394 )
...
Fix #30393
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Zettat123 <zettat123@gmail.com>
2024-04-11 11:57:03 +08:00
silverwind
50dbed6527
Fix author name alignment in commits table ( #30396 )
...
Fixes https://github.com/go-gitea/gitea/issues/30129 by introducing a
wrapper div with flexbox that collapses any inter-tag whitespace within.
View diff with whitespace hidden.
Author names aligned:
<img width="172" alt="Screenshot 2024-04-10 at 19 41 27"
src="https://github.com/go-gitea/gitea/assets/115237/d761e8f2-0e67-4f84-8d37-9ed73850470a ">
Vertically centered on expand:
<img width="466" alt="Screenshot 2024-04-10 at 19 43 02"
src="https://github.com/go-gitea/gitea/assets/115237/decd68b3-19b5-4cfa-a505-b358e4a0715b ">
Ellipsis works:
<img width="344" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/6f8624a2-f8b6-4f3e-ac98-c44dd0cdfca5 ">
2024-04-11 03:16:44 +00:00
silverwind
e6d3f9fc07
Upgrade golangci-lint to v1.57.2 ( #30401 )
...
Update and adapt to one setting
[deprecation](https://github.com/golangci/golangci-lint/pull/4509 ).
2024-04-11 02:40:03 +00:00
Lunny Xiao
f0bfad29ea
Replace MSSQL driver with a better maintained version ( #30390 )
...
As the latest tag of `github.com/denisenkom/go-mssqldb` is in 2022, but
as a fork of it, `github.com/microsoft/go-mssqldb` has more activities
than the original repository. We can convert the driver to the fork.
Since the interface of Go database driver are the same, it should have
no any affect for the end users.
2024-04-11 01:12:40 +00:00
GiteaBot
17c7ebb327
[skip ci] Updated translations via Crowdin
2024-04-11 00:24:56 +00:00
silverwind
e7ecdba493
Minor color tweaks ( #30397 )
...
New approach to color shades: Stem all colors off the body color
`#1b1f23` using [this](https://pinetools.com/darken-color ) and
[this](https://pinetools.com/lighten-color ) tool. The differences are
very subtle, but it will give a more consistent color scheme until
https://github.com/go-gitea/gitea/issues/30160 .
<img width="1342" alt="Screenshot 2024-04-10 at 20 44 16"
src="https://github.com/go-gitea/gitea/assets/115237/75b65797-2521-46ea-91d8-d76f77b591b1 ">
2024-04-10 22:29:05 +02:00
Rafael
c1f76aea45
Use raw Wiki links for non-renderable Wiki files ( #30273 )
...
In Wiki pages, short-links created to local Wiki files were always
expanded as regular Wiki Links. In particular, if a link wanted to point
to a file that Gitea doesn't know how to render (e.g, a .zip file), a
user following the link would be silently redirected to the Wiki's home
page.
This change makes short-links* in Wiki pages be expanded to raw wiki
links, so these local wiki files may be accessed without manually
accessing their URL.
* only short-links ending in a file extension that isn't renderable are
affected.
Closes #27121 .
Signed-off-by: Rafael Girão <rafael.s.girao@tecnico.ulisboa.pt>
Co-authored-by: silverwind <me@silverwind.io>
2024-04-10 17:49:57 +00:00
silverwind
50099d7af4
Various improvements for long file and commit names ( #30374 )
...
Fixes: https://github.com/go-gitea/gitea/issues/29438
This contains numerous enhancements for how large commit messages and
large filenames render. Another notable change is that the file path is
no longer cut off by backend at 30 chars, but rendered in full with
wrapping.
<img width="1329" alt="Screenshot 2024-04-09 at 21 53 57"
src="https://github.com/go-gitea/gitea/assets/115237/5ccbb3d6-643a-4f60-ba79-3572b36d5182 ">
<hr>
<img width="711" alt="Screenshot 2024-04-09 at 21 44 24"
src="https://github.com/go-gitea/gitea/assets/115237/6ffe8fbb-407c-4aa7-b591-3d80daea7d57 ">
<hr>
<img width="439" alt="Screenshot 2024-04-09 at 21 19 03"
src="https://github.com/go-gitea/gitea/assets/115237/1ec7f6e9-2fd8-4841-87eb-6ca02ab9cd61 ">
<hr>
<img width="444" alt="Screenshot 2024-04-09 at 21 18 52"
src="https://github.com/go-gitea/gitea/assets/115237/70931b9e-5841-477e-b3bc-98f8d2662964 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io>
2024-04-10 06:13:22 +00:00
silverwind
6cac11cb1b
Fix line height on inline code preview ( #30372 )
...
Fixes https://github.com/go-gitea/gitea/issues/30353 .
I don't know what causes `code-inner` to not inherit `line-height` from
its direct parent `.lines-code` but instead from grandparent `.markup`
even thought MDN tells me it's
[inherited](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#formal_definition ).
This causes no negative impact on other code views, so I think it's the
best solution.
2024-04-10 05:44:48 +00:00
Lunny Xiao
b09687f1d1
Refactor more filterslice ( #30370 )
2024-04-10 04:18:41 +00:00
Jason Song
310e2517e5
Fix ambiguous id when fetch Actions tasks ( #30382 )
...
Fix regression of #30331 .
```txt
time="2024-04-10T02:23:49Z" level=error msg="failed to fetch task" func="[fetchTask]" file="[poller.go:91]" error="unknown: rpc error: code = Internal desc = pick task: CreateTaskForRunner: Error 1052 (23000): Column 'id' in field list is ambiguous"
```
2024-04-10 02:57:43 +00:00
silverwind
fec754258c
Fix floated list items ( #30377 )
...
Fixes https://github.com/go-gitea/gitea/issues/30365 , regression from
https://github.com/go-gitea/gitea/pull/30281
2024-04-10 10:16:55 +08:00
Lunny Xiao
63c80aeb29
Fix actions design about default actions download url ( #30360 )
...
Fix #30359
2024-04-09 16:39:38 +00:00
oliverpool
d547b53cca
Add container.FilterSlice function ( #30339 )
...
Many places have the following logic:
```go
func (jobs ActionJobList) GetRunIDs() []int64 {
ids := make(container.Set[int64], len(jobs))
for _, j := range jobs {
if j.RunID == 0 {
continue
}
ids.Add(j.RunID)
}
return ids.Values()
}
```
this introduces a `container.FilterMapUnique` function, which reduces
the code above to:
```go
func (jobs ActionJobList) GetRunIDs() []int64 {
return container.FilterMapUnique(jobs, func(j *ActionRunJob) (int64, bool) {
return j.RunID, j.RunID != 0
})
}
```
2024-04-09 20:27:30 +08:00
silverwind
8d14266269
Fix label-list rendering in timeline, decrease gap ( #30342 )
...
Not sure exactly when this regressed, but has been a while I think.
Before:
<img width="895" alt="Screenshot 2024-04-08 at 22 46 50"
src="https://github.com/go-gitea/gitea/assets/115237/9b1788f8-017e-4fe1-8ab9-938e0d76fb41 ">
After:
<img width="689" alt="Screenshot 2024-04-08 at 23 00 58"
src="https://github.com/go-gitea/gitea/assets/115237/90193df9-5c24-4a1a-96fe-3d4e8392063c ">
Co-authored-by: Giteabot <teabot@gitea.io>
2024-04-09 08:30:21 +02:00
Lunny Xiao
263a716cb5
Performance optimization for git push ( #30104 )
...
Agit returned result should be from `ProcReceive` hook but not
`PostReceive` hook. Then for all non-agit pull requests, it will not
check the pull requests for every pushing `refs/pull/%d/head`.
2024-04-09 03:43:17 +00:00
silverwind
72dc75e594
Reduce checkbox size to 15px ( #30346 )
...
16 seems to big, 14 too small. Let's do 15. Alignment:
<img width="181" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/f2988611-dee2-492e-a18f-dc5ab3a1cd6c ">
2024-04-09 03:09:43 +00:00
GiteaBot
d7013c26c8
[skip ci] Updated translations via Crowdin
2024-04-09 00:24:26 +00:00
Lunny Xiao
908426aa0f
Fix missed doer ( #30231 )
...
Fix #29879
Co-authored-by: Giteabot <teabot@gitea.io>
2024-04-08 21:26:41 +00:00
Michael Kriese
ff7aab4403
Add optional doctor storage init ( #30330 )
...
Add optional storage init to doctor
2024-04-08 20:59:09 +00:00
yp05327
d872ce006c
Avoid running action when action unit is disabled after workflows detected ( #30331 )
...
Fix #30243
We only checking unit disabled when detecting workflows, but not in
runner `FetchTask`.
So if a workflow was detected when action unit is enabled, but disabled
later, `FetchTask` will still return these detected actions.
Global setting: repo.ENABLED and repository.`DISABLED_REPO_UNITS` will
not effect this.
2024-04-08 22:08:26 +08:00
yp05327
7d66b9ea65
Avoid showing Failed to change the default wiki branch if repo has no wiki when saving repo settings ( #30329 )
2024-04-08 19:43:23 +08:00
wxiaoguang
074a3e05f6
Fix oauth2 builtin application logic ( #30304 )
...
Fix #29074 (allow to disable all builtin apps) and don't make the doctor
command remove the builtin apps.
By the way, rename refobject and joincond to camel case.
2024-04-08 04:13:34 +00:00
GiteaBot
0c7b0c5aca
[skip ci] Updated licenses and gitignores
2024-04-08 00:25:35 +00:00
KN4CK3R
8498e67309
Some NuGet package enhancements ( #30280 )
...
Fixes #30265
1. Read second type of dependencies
2. Render `Description` and `ReleaseNotes`
old:
new:
The NuGet spec does not specify what kind of text can be stored in the
description but we can best guess markdown. The official NuGet registry
just [converts the newlines to html
lines](https://www.nuget.org/packages/rb.Firefox#readme-body-tab ).
3. Extract and render the readme. This is the new and better place to
store larger text than in the description. The content is markdown.
---------
Co-authored-by: Benjamin Heemann <benjamin.heemann@raith.de>
2024-04-07 16:46:59 +00:00
silverwind
36887ed392
Fix and rewrite contrast color calculation, fix project-related bugs ( #30237 )
...
1. The previous color contrast calculation function was incorrect at
least for the `#84b6eb` where it output low-contrast white instead of
black. I've rewritten these functions now to accept hex colors and to
match GitHub's calculation and to output pure white/black for maximum
contrast. Before and after:
<img width="94" alt="Screenshot 2024-04-02 at 01 53 46"
src="https://github.com/go-gitea/gitea/assets/115237/00b39e15-a377-4458-95cf-ceec74b78228 "><img
width="90" alt="Screenshot 2024-04-02 at 01 51 30"
src="https://github.com/go-gitea/gitea/assets/115237/1677067a-8d8f-47eb-82c0-76330deeb775 ">
2. Fix project-related issues:
- Expose the new `ContrastColor` function as template helper and use it
for project cards, replacing the previous JS solution which eliminates a
flash of wrong color on page load.
- Fix a bug where if editing a project title, the counter would get
lost.
- Move `rgbToHex` function to color utils.
@HesterG fyi
---------
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Giteabot <teabot@gitea.io>
2024-04-07 16:19:25 +00:00
silverwind
019857a701
Add --page-spacing variable, fix admin dashboard notice ( #30302 )
...
Fixes https://github.com/go-gitea/gitea/issues/30293 and introduce the
`--page-spacing` variable which holds the spacing between the elements
on the page. This is working vertically for all pages, including ones
that have fomantic grid, and horizontally for all that use
`flex-container`.
The `.page-content > :first-child:not(.secondary-nav)` selector uses
margin which in some cases enables to adjacent margins to overlap, which
is nice.
<img width="1320" alt="Screenshot 2024-04-06 at 01 35 19"
src="https://github.com/go-gitea/gitea/assets/115237/3e81e707-e9ff-4b7f-a211-3d98f4f85353 ">
---
<img width="1327" alt="Screenshot 2024-04-06 at 01 35 45"
src="https://github.com/go-gitea/gitea/assets/115237/aad196c0-9e21-4c06-ae59-7e33a76c61e1 ">
---
<img width="1321" alt="Screenshot 2024-04-06 at 01 35 31"
src="https://github.com/go-gitea/gitea/assets/115237/785f6c5d-08b6-4e66-aa16-aeca7cfed3ad ">
2024-04-07 15:45:36 +00:00
silverwind
0178eaec25
Action view mobile improvements and fixes ( #30309 )
...
Fix the action issue in https://github.com/go-gitea/gitea/issues/30303 ,
specifically:
- Use opaque step header hover background to avoid transparency issue
- Un-sticky the `action-view-left` on mobile, it would otherwise overlap
into right view
- Improve commit summary, let it wrap
- Fix and comment z-indexes
- Tweak width for run-list-item-right so it wastes less space on desktop
- Synced latest changes to console colors from dark to light theme
<img width="467" alt="Screenshot 2024-04-06 at 18 58 15"
src="https://github.com/go-gitea/gitea/assets/115237/8ad26b72-6cd9-4522-8ad1-6fd86b2d0d53 ">
2024-04-07 12:41:42 +00:00
silverwind
644ade5ae6
Fix checkboxes on mobile view, remove some dead css ( #30308 )
...
Fix the checkbox issues in
https://github.com/go-gitea/gitea/issues/30303 which were existing
problems with these selectors, but made visible with
https://github.com/go-gitea/gitea/pull/30162 .
There is a lot of dead/useless CSS in `form.css`, I only fixed the two
problems and remove CSS that was definitely not in use or needed.
<img width="369" alt="Screenshot 2024-04-06 at 18 00 08"
src="https://github.com/go-gitea/gitea/assets/115237/720f178b-1b22-48d4-8704-becb8ce66129 ">
<img width="405" alt="Screenshot 2024-04-06 at 18 00 28"
src="https://github.com/go-gitea/gitea/assets/115237/61c0f8ec-34af-46c5-a3fa-7c5c4d30c7d2 ">
Co-authored-by: Giteabot <teabot@gitea.io>
2024-04-07 14:36:33 +02:00
wxiaoguang
83f83019ef
Clean up log messages ( #30313 )
...
`log.Xxx("%v")` is not ideal, this PR adds necessary context messages.
Remove some unnecessary logs.
Co-authored-by: Giteabot <teabot@gitea.io>
2024-04-07 19:17:06 +08:00
silverwind
94aad35a12
Fix right-aligned input icons ( #30301 )
...
Fix regression from https://github.com/go-gitea/gitea/pull/30194 where
right-aligned items would not display correctly.
Before and After:
<img width="285" alt="Screenshot 2024-04-06 at 01 12 11"
src="https://github.com/go-gitea/gitea/assets/115237/f9168db5-0f69-4b5d-ba17-b60145ac4a09 ">
<img width="285" alt="Screenshot 2024-04-06 at 01 11 49"
src="https://github.com/go-gitea/gitea/assets/115237/639ab6ed-d018-4e3a-9980-1f079e4ebe9d ">
Frontpage search tweaked to accommodate (which was the reason for the
changes that broken above):
<img width="445" alt="Screenshot 2024-04-06 at 01 11 34"
src="https://github.com/go-gitea/gitea/assets/115237/1919220b-390e-463a-8e3d-33a3556bf111 ">
<img width="438" alt="Screenshot 2024-04-06 at 01 11 39"
src="https://github.com/go-gitea/gitea/assets/115237/fd94f8e4-1d56-4b04-99e3-1cd240bd7ab4 ">
2024-04-07 16:53:28 +08:00
wxiaoguang
bbe5cd7c92
Refactor startup deprecation messages ( #30305 )
...
It doesn't change logic, it only does:
1. Rename the variable and function names
2. Use more consistent format when mentioning config section&key
3. Improve some messages
2024-04-07 01:11:25 +00:00
GiteaBot
48223909be
[skip ci] Updated translations via Crowdin
2024-04-07 00:27:31 +00:00
silverwind
649aada366
Remove fomantic list module ( #30281 )
...
Likely still some unnecessary CSS but any combinations with the `ui
list` classes are covered. There was only on instance of `horizontal
list` which I removed. It was this part of the commit page:
<img width="396" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/c49ec4f5-93c3-41d6-a907-cdbedf8abc44 ">
2024-04-06 21:33:45 +00:00
silverwind
662eb4b085
Markup color and font size fixes ( #30282 )
...
1. Distinguish inline an block code with new CSS variable
`--color-markup-code-inline`
2. Various color tweaks, better contrast from background
<img width="447" alt="Screenshot 2024-04-05 at 00 51 00"
src="https://github.com/go-gitea/gitea/assets/115237/93e069f4-6807-4f2c-9331-2d69730919d4 ">
<img width="456" alt="Screenshot 2024-04-05 at 00 50 44"
src="https://github.com/go-gitea/gitea/assets/115237/0dc9c745-c531-40fa-94ec-b0ba10bd7ccf ">
2024-04-06 23:06:27 +02:00
wxiaoguang
7396172a02
Fix code block style for code preview ( #30298 )
...
Fix #30292
To avoid unnecessary style overriding, use "div" instead of "code"
2024-04-06 20:07:08 +08:00
silverwind
9c1f4dae2e
Always use octicon-eye on watch button ( #30288 )
...
This might appear odd but I think it's the right thing to do: On Github,
the "Watch" button always has the open eye icon:
<img width="177" alt="Screenshot 2024-04-05 at 08 26 48"
src="https://github.com/go-gitea/gitea/assets/115237/0c1188d1-145b-4c6d-909f-2e1460499941 ">
<img width="179" alt="Screenshot 2024-04-05 at 08 26 40"
src="https://github.com/go-gitea/gitea/assets/115237/e29d91fa-f122-4e10-9589-f79c1d612cf9 ">
On Gitea, while watching, the icon is this and this sometimes confuses
me slightly, being used to above:
<img width="158" alt="Screenshot 2024-04-05 at 08 29 08"
src="https://github.com/go-gitea/gitea/assets/115237/3301021b-744e-409f-a9d8-887ec2772fdc ">
After this PR, both states will use the same icon:
<img width="145" alt="Screenshot 2024-04-05 at 08 26 27"
src="https://github.com/go-gitea/gitea/assets/115237/8addfa5b-c009-4bdb-bfa1-4f3dfaffa4cd ">
<img width="161" alt="Screenshot 2024-04-05 at 08 26 33"
src="https://github.com/go-gitea/gitea/assets/115237/cef383e6-2cc0-460f-a4d3-83ebb321debe ">
2024-04-06 08:25:39 +00:00
wxiaoguang
b2b49c9bde
Fix view commit link ( #30297 )
...
Fix #30098
2024-04-06 02:03:07 +08:00
silverwind
556099fa72
Add gap to commit status details ( #30284 )
...
Before:
<img width="162" alt="Screenshot 2024-04-05 at 02 25 27"
src="https://github.com/go-gitea/gitea/assets/115237/9f786811-3e45-4b3c-aaf9-e1d2cad284d2 ">
After:
<img width="172" alt="Screenshot 2024-04-05 at 02 27 25"
src="https://github.com/go-gitea/gitea/assets/115237/f5254877-9e0d-44cb-9605-ba15c75872bb ">
2024-04-05 11:11:26 +00:00
silverwind
5dabc679aa
Update JS dependencies and add new eslint rules ( #30279 )
...
- Run `make update-js`
- Added new eslint rules
- Tested webpack build and swagger ui
2024-04-05 03:35:37 +00:00
silverwind
95504045cc
Upgrade golang.org/x/net to v0.24.0 ( #30283 )
...
Result of `go get -u golang.org/x/net; make tidy`.
This is related to the following vulncheck warning:
```
There are 2 vulnerabilities in modules that you require that are
neither imported nor called. You may not need to take any action.
See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck for details.
Vulnerability #1 : GO-2024-2687
HTTP/2 CONTINUATION flood in net/http
More info: https://pkg.go.dev/vuln/GO-2024-2687
Module: golang.org/x/net
Found in: golang.org/x/net@v0.22.0
Fixed in: golang.org/x/net@v0.23.0
Vulnerability #2 : GO-2022-0470
No access control in github.com/blevesearch/bleve and bleve/v2
More info: https://pkg.go.dev/vuln/GO-2022-0470
Module: github.com/blevesearch/bleve/v2
Found in: github.com/blevesearch/bleve/v2@v2.3.10
Fixed in: N/A
```
2024-04-05 02:45:59 +00:00
sebastian-sauer
07bcfc171b
Commit-Dropdown: Show Author of commit if available ( #30272 )
...
As in commits page we show the author of the commit in the commits
dropdown and not the committer.
Commits Page:
and the same contents in our dropdown:
fixes #29588
2024-04-05 00:51:53 +00:00
GiteaBot
83c5072077
[skip ci] Updated translations via Crowdin
2024-04-05 00:24:29 +00:00
GiteaBot
663acd0b46
[skip ci] Updated translations via Crowdin
2024-04-04 00:24:47 +00:00
Knud Hollander
39e64e094f
update mailer example config, remove deprecated HOST ( #30267 )
2024-04-03 19:16:02 -04:00
Yakov
609a627a44
Add [other].SHOW_FOOTER_POWERED_BY setting to hide Powered by ( #30253 )
...
This allows you to hide the "Powered by" text in footer via
`SHOW_FOOTER_POWERED_BY` flag in configuration.
---------
Co-authored-by: silverwind <me@silverwind.io>
2024-04-03 16:01:50 +00:00
guangwu
0ceecfc11a
fix: close file in the Upload func ( #30262 )
2024-04-03 10:58:13 -04:00
