githaven

Shiloh/githaven

Fork 1

Commit Graph

Author	SHA1	Message	Date
wxiaoguang	43c7a2e7b1	Refactor names (#31405 ) This PR only does "renaming": * `Route` should be `Router` (and chi router is also called "router") * `Params` should be `PathParam` (to distingush it from URL query param, and to match `FormString`) * Use lower case for private functions to avoid exposing or abusing	2024-06-19 06:32:45 +08:00
wxiaoguang	bffbbf5470	Improve oauth2 client "preferred username field" logic and the error handling (#30622 ) Follow #30454 And fix #24957 When using "preferred_username", if no such field, `extractUserNameFromOAuth2` (old `getUserName`) shouldn't return an error. All other USERNAME options do not return such error. And fine tune some logic and error messages, make code more stable and more friendly to end users.	2024-04-25 11:22:32 +00:00
wxiaoguang	df1268ca08	Make "/user/login" page redirect if the current user has signed in (#29583 ) Fix #29582 and maybe more. Maybe fix #29116	2024-03-05 02:12:03 +00:00

Author

SHA1

Message

Date

wxiaoguang

43c7a2e7b1

Refactor names (#31405 )

This PR only does "renaming":

* `Route` should be `Router` (and chi router is also called "router")
* `Params` should be `PathParam` (to distingush it from URL query param, and to match `FormString`)
* Use lower case for private functions to avoid exposing or abusing

2024-06-19 06:32:45 +08:00

wxiaoguang

bffbbf5470

Improve oauth2 client "preferred username field" logic and the error handling (#30622 )

Follow #30454
And fix #24957

When using "preferred_username", if no such field,
`extractUserNameFromOAuth2` (old `getUserName`) shouldn't return an
error. All other USERNAME options do not return such error.

And fine tune some logic and error messages, make code more stable and
more friendly to end users.

2024-04-25 11:22:32 +00:00

wxiaoguang

df1268ca08

Make "/user/login" page redirect if the current user has signed in (#29583 )

Fix #29582 and maybe more.
Maybe fix #29116

2024-03-05 02:12:03 +00:00

3 Commits