Hide code links on release page if user cannot read code (#29064)
On the release list page, if the user doesn't have the permission to read code, the code links will lead to 404 pages or api errors: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a74fbc63-6dd6-43c6-853c-28acdbfdcb4e"> After this PR: <img width="1297" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/a626373d-c2df-40a9-8fed-1b12ff6bc56f"> And this PR also removed some dead code. After #23465, the tag list page has an independent template, and all `IsTag` in the release list template are always false.
This commit is contained in:
		
							parent
							
								
									f69914dd0b
								
							
						
					
					
						commit
						f9072dbf3c
					
				| @ -8,8 +8,8 @@ | |||||||
| 			{{range $idx, $release := .Releases}} | 			{{range $idx, $release := .Releases}} | ||||||
| 				<li class="ui grid"> | 				<li class="ui grid"> | ||||||
| 					<div class="ui four wide column meta"> | 					<div class="ui four wide column meta"> | ||||||
| 							<a class="muted" href="{{if not .Sha1}}#{{else}}{{$.RepoLink}}/src/tag/{{.TagName | PathEscapeSegments}}{{end}}" rel="nofollow">{{svg "octicon-tag" 16 "gt-mr-2"}}{{.TagName}}</a> | 							<a class="muted" href="{{if not (and .Sha1 ($.Permission.CanRead $.UnitTypeCode))}}#{{else}}{{$.RepoLink}}/src/tag/{{.TagName | PathEscapeSegments}}{{end}}" rel="nofollow">{{svg "octicon-tag" 16 "gt-mr-2"}}{{.TagName}}</a> | ||||||
| 							{{if .Sha1}} | 							{{if and .Sha1 ($.Permission.CanRead $.UnitTypeCode)}} | ||||||
| 								<a class="muted gt-mono" href="{{$.RepoLink}}/src/commit/{{.Sha1}}" rel="nofollow">{{svg "octicon-git-commit" 16 "gt-mr-2"}}{{ShortSha .Sha1}}</a> | 								<a class="muted gt-mono" href="{{$.RepoLink}}/src/commit/{{.Sha1}}" rel="nofollow">{{svg "octicon-git-commit" 16 "gt-mr-2"}}{{ShortSha .Sha1}}</a> | ||||||
| 								{{template "repo/branch_dropdown" dict "root" $ "release" .}} | 								{{template "repo/branch_dropdown" dict "root" $ "release" .}} | ||||||
| 							{{end}} | 							{{end}} | ||||||
| @ -22,36 +22,18 @@ | |||||||
| 										<span class="ui yellow label">{{ctx.Locale.Tr "repo.release.draft"}}</span> | 										<span class="ui yellow label">{{ctx.Locale.Tr "repo.release.draft"}}</span> | ||||||
| 									{{else if .IsPrerelease}} | 									{{else if .IsPrerelease}} | ||||||
| 										<span class="ui orange label">{{ctx.Locale.Tr "repo.release.prerelease"}}</span> | 										<span class="ui orange label">{{ctx.Locale.Tr "repo.release.prerelease"}}</span> | ||||||
| 									{{else if not .IsTag}} | 									{{else}} | ||||||
| 										<span class="ui green label">{{ctx.Locale.Tr "repo.release.stable"}}</span> | 										<span class="ui green label">{{ctx.Locale.Tr "repo.release.stable"}}</span> | ||||||
| 									{{end}} | 									{{end}} | ||||||
| 								</h4> | 								</h4> | ||||||
| 								<div> | 								<div> | ||||||
| 									{{if and $.CanCreateRelease (not .IsTag)}} | 									{{if $.CanCreateRelease}} | ||||||
| 										<a class="muted" data-tooltip-content="{{ctx.Locale.Tr "repo.release.edit"}}" href="{{$.RepoLink}}/releases/edit/{{.TagName | PathEscapeSegments}}" rel="nofollow"> | 										<a class="muted" data-tooltip-content="{{ctx.Locale.Tr "repo.release.edit"}}" href="{{$.RepoLink}}/releases/edit/{{.TagName | PathEscapeSegments}}" rel="nofollow"> | ||||||
| 											{{svg "octicon-pencil"}} | 											{{svg "octicon-pencil"}} | ||||||
| 										</a> | 										</a> | ||||||
| 									{{end}} | 									{{end}} | ||||||
| 								</div> | 								</div> | ||||||
| 							</div> | 							</div> | ||||||
| 						{{if .IsTag}} |  | ||||||
| 							<p class="text grey"> |  | ||||||
| 								{{if gt .Publisher.ID 0}} |  | ||||||
| 								<span class="author"> |  | ||||||
| 									{{ctx.AvatarUtils.Avatar .Publisher 20 "gt-mr-2"}} |  | ||||||
| 									<a href="{{.Publisher.HomeLink}}">{{.Publisher.Name}}</a> |  | ||||||
| 								</span> |  | ||||||
| 								<span class="released"> |  | ||||||
| 									{{ctx.Locale.Tr "repo.tagged_this"}} |  | ||||||
| 								</span> |  | ||||||
| 								{{if .CreatedUnix}} |  | ||||||
| 									<span class="time">{{TimeSinceUnix .CreatedUnix ctx.Locale}}</span> |  | ||||||
| 								{{end}} |  | ||||||
| 								| |  | ||||||
| 								{{end}} |  | ||||||
| 								<span class="ahead"><a href="{{$.RepoLink}}/compare/{{.TagName | PathEscapeSegments}}...{{.TargetBehind | PathEscapeSegments}}">{{ctx.Locale.Tr "repo.release.ahead.commits" .NumCommitsBehind | Str2html}}</a> {{ctx.Locale.Tr "repo.tag.ahead.target" .TargetBehind}}</span> |  | ||||||
| 							</p> |  | ||||||
| 						{{else}} |  | ||||||
| 							<p class="text grey"> | 							<p class="text grey"> | ||||||
| 								<span class="author"> | 								<span class="author"> | ||||||
| 								{{if .OriginalAuthor}} | 								{{if .OriginalAuthor}} | ||||||
| @ -69,11 +51,10 @@ | |||||||
| 								{{if .CreatedUnix}} | 								{{if .CreatedUnix}} | ||||||
| 									<span class="time">{{TimeSinceUnix .CreatedUnix ctx.Locale}}</span> | 									<span class="time">{{TimeSinceUnix .CreatedUnix ctx.Locale}}</span> | ||||||
| 								{{end}} | 								{{end}} | ||||||
| 								{{if not .IsDraft}} | 								{{if and (not .IsDraft) ($.Permission.CanRead $.UnitTypeCode)}} | ||||||
| 									| <span class="ahead"><a href="{{$.RepoLink}}/compare/{{.TagName | PathEscapeSegments}}...{{.TargetBehind | PathEscapeSegments}}">{{ctx.Locale.Tr "repo.release.ahead.commits" .NumCommitsBehind | Str2html}}</a> {{ctx.Locale.Tr "repo.release.ahead.target" .TargetBehind}}</span> | 									| <span class="ahead"><a href="{{$.RepoLink}}/compare/{{.TagName | PathEscapeSegments}}...{{.TargetBehind | PathEscapeSegments}}">{{ctx.Locale.Tr "repo.release.ahead.commits" .NumCommitsBehind | Str2html}}</a> {{ctx.Locale.Tr "repo.release.ahead.target" .TargetBehind}}</span> | ||||||
| 								{{end}} | 								{{end}} | ||||||
| 							</p> | 							</p> | ||||||
| 						{{end}} |  | ||||||
| 							<div class="markup desc"> | 							<div class="markup desc"> | ||||||
| 								{{Str2html .Note}} | 								{{Str2html .Note}} | ||||||
| 							</div> | 							</div> | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user