Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix createElementFromAttrs bug (#31751)

Browse Source 
The "false" value was not handled correctly, it would cause bugs in the
future (fortunately, this behavior is not used in code yet).
This commit is contained in:
wxiaoguang 2024-08-02 03:06:03 +08:00 committed by GitHub
parent d1283524b1
commit e3678356e1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web_src/js/utils/dom.test.ts
View File

@ -10,7 +10,9 @@ test('createElementFromAttrs', () => {
class: 'cls-1 cls-2', class: 'cls-1 cls-2',
'data-foo': 'the-data', 'data-foo': 'the-data',
disabled: true, disabled: true,
checked: false,
required: null, required: null,
tabindex: 0,
}); });
expect(el.outerHTML).toEqual('<button id="the-id" class="cls-1 cls-2" data-foo="the-data" disabled=""></button>'); expect(el.outerHTML).toEqual('<button id="the-id" class="cls-1 cls-2" data-foo="the-data" disabled="" tabindex="0"></button>');
}); });

2
web_src/js/utils/dom.ts
View File

@ -297,7 +297,7 @@ export function createElementFromAttrs(tagName, attrs) {
const el = document.createElement(tagName); const el = document.createElement(tagName);
for (const [key, value] of Object.entries(attrs)) { for (const [key, value] of Object.entries(attrs)) {
if (value === undefined || value === null) continue; if (value === undefined || value === null) continue;
if (value === true) { if (typeof value === 'boolean') {
el.toggleAttribute(key, value); el.toggleAttribute(key, value);
} else { } else {
el.setAttribute(key, String(value)); el.setAttribute(key, String(value));