Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Improve wiki user title test (#24559)

Browse Source 
The `..` should be covered by TestUserTitleToWebPath.

Otherwise, if the random string is "..", it causes unnecessary failure
in TestUserWebGitPathConsistency
This commit is contained in:
wxiaoguang 2023-05-06 19:24:18 +08:00 committed by GitHub
parent bc888e5f92
commit db582d97ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
services/wiki/wiki_test.go
View File

@ -34,6 +34,9 @@ func TestUserTitleToWebPath(t *testing.T) {
UserTitle string
}
for _, test := range []test{
{"unnamed", ""},
{"unnamed", "."},
{"unnamed", ".."},
{"wiki-name", "wiki name"},
{"title.md.-", "title.md"},
{"wiki-name.-", "wiki-name"},
@ -118,7 +121,7 @@ func TestUserWebGitPathConsistency(t *testing.T) {
}
userTitle := strings.TrimSpace(string(b[:l]))
if userTitle == "" || userTitle == "." {
if userTitle == "" || userTitle == "." || userTitle == ".." {
continue
}
webPath := UserTitleToWebPath("", userTitle)