Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Make GetRepositoryByName more safer (#31712)

Browse Source 
Fix #31708
This commit is contained in:
Lunny Xiao 2024-07-29 09:32:54 +08:00 committed by GitHub
parent 88decb6913
commit d109923ed8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
models/repo/repo.go
View File

@ -745,17 +745,18 @@ func GetRepositoryByOwnerAndName(ctx context.Context, ownerName, repoName string
// GetRepositoryByName returns the repository by given name under user if exists. // GetRepositoryByName returns the repository by given name under user if exists.
func GetRepositoryByName(ctx context.Context, ownerID int64, name string) (*Repository, error) { func GetRepositoryByName(ctx context.Context, ownerID int64, name string) (*Repository, error) {
repo := &Repository{ var repo Repository
OwnerID: ownerID, has, err := db.GetEngine(ctx).
LowerName: strings.ToLower(name), Where("`owner_id`=?", ownerID).
} And("`lower_name`=?", strings.ToLower(name)).
has, err := db.GetEngine(ctx).Get(repo) NoAutoCondition().
Get(&repo)
if err != nil { if err != nil {
return nil, err return nil, err
} else if !has { } else if !has {
return nil, ErrRepoNotExist{0, ownerID, "", name} return nil, ErrRepoNotExist{0, ownerID, "", name}
} }
return repo, err return &repo, err
} }
// getRepositoryURLPathSegments returns segments (owner, reponame) extracted from a url // getRepositoryURLPathSegments returns segments (owner, reponame) extracted from a url