Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add more packages to denylist (#22412)

Browse Source 
After this, we can remove
[`denylist_imports`](https://gitea.com/gitea/gitea-vet/src/branch/master/checks/denylisted-imports.go#L13)
in gitea-vet
([gitea-vet/pulls/23](https://gitea.com/gitea/gitea-vet/pulls/23)).

```go
deniedImports   = []string{"io/ioutil", "encoding/json", "gitea.com/gitea/go-crypto"}
```

However, we needn't keep `gitea.com/gitea/go-crypto` any longer, it's
gone and can't be imported again.

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
This commit is contained in:
Jason Song 2023-01-12 23:35:53 +08:00 committed by GitHub
parent 9ffaf19d89
commit c86be819bb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.golangci.yml
View File

@ -76,13 +76,14 @@ linters-settings:
extra-rules: true extra-rules: true
lang-version: "1.19" lang-version: "1.19"
depguard: depguard:
# TODO: use depguard to replace import checks in gitea-vet
list-type: denylist list-type: denylist
# Check the list against standard lib. # Check the list against standard lib.
include-go-root: true include-go-root: true
packages-with-error-message: packages-with-error-message:
- encoding/json: "use gitea's modules/json instead of encoding/json" - encoding/json: "use gitea's modules/json instead of encoding/json"
- github.com/unknwon/com: "use gitea's util and replacements" - github.com/unknwon/com: "use gitea's util and replacements"
- io/ioutil: "use os or io instead"
- golang.org/x/exp: "it's experimental and unreliable."
issues: issues:
max-issues-per-linter: 0 max-issues-per-linter: 0