Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Drop IDOrderDesc for listing Actions task and always order by id DESC (#31150)

Browse Source 
Close #31066

Just follow what `FindRunOptions` and `FindScheduleOptions` do.
This commit is contained in:
Jason Song 2024-05-31 10:30:02 +08:00 committed by GitHub
parent 1137a0357e
commit 572fa55fbc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
models/actions/task_list.go
View File

@ -54,7 +54,6 @@ type FindTaskOptions struct {
UpdatedBefore timeutil.TimeStamp UpdatedBefore timeutil.TimeStamp
StartedBefore timeutil.TimeStamp StartedBefore timeutil.TimeStamp
RunnerID int64 RunnerID int64
IDOrderDesc bool
} }
func (opts FindTaskOptions) ToConds() builder.Cond { func (opts FindTaskOptions) ToConds() builder.Cond {
@ -84,8 +83,5 @@ func (opts FindTaskOptions) ToConds() builder.Cond {
} }
func (opts FindTaskOptions) ToOrders() string { func (opts FindTaskOptions) ToOrders() string {
if opts.IDOrderDesc { return "`id` DESC"
return "`id` DESC"
}
return ""
} }

5
routers/web/shared/actions/runners.go
View File

@ -79,9 +79,8 @@ func RunnerDetails(ctx *context.Context, page int, runnerID, ownerID, repoID int
Page: page, Page: page,
PageSize: 30, PageSize: 30,
}, },
Status: actions_model.StatusUnknown, // Unknown means all Status: actions_model.StatusUnknown, // Unknown means all
IDOrderDesc: true, RunnerID: runner.ID,
RunnerID: runner.ID,
} }
tasks, count, err := db.FindAndCount[actions_model.ActionTask](ctx, opts) tasks, count, err := db.FindAndCount[actions_model.ActionTask](ctx, opts)