Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Only update poster in issue/comment list if it has been loaded (#31216)

Browse Source 
Previously, all posters were updated, even if they were not part of
posterMaps. In that case, a ghost user was erroneously inserted.

Fixes #31213.
This commit is contained in:
Max Wipfli 2024-06-02 04:32:20 +02:00 committed by GitHub
parent ab458ce10b
commit 3cc7f763c3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
models/issues/comment_list.go
View File

@ -32,7 +32,9 @@ func (comments CommentList) LoadPosters(ctx context.Context) error {
}
for _, comment := range comments {
comment.Poster = getPoster(comment.PosterID, posterMaps)
if comment.Poster == nil {
comment.Poster = getPoster(comment.PosterID, posterMaps)
}
}
return nil
}

4
models/issues/issue_list.go
View File

@ -87,7 +87,9 @@ func (issues IssueList) LoadPosters(ctx context.Context) error {
}
for _, issue := range issues {
issue.Poster = getPoster(issue.PosterID, posterMaps)
if issue.Poster == nil {
issue.Poster = getPoster(issue.PosterID, posterMaps)
}
}
return nil
}