Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add permission check for moving issue action in project view page (#24589)

Browse Source 
Fix #22954
Only users who have write permission can move issues in the project view page.
This commit is contained in:
yp05327 2023-05-09 13:50:16 +09:00 committed by GitHub
parent d5b2bf9044
commit 2ee72d011f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
templates/projects/view.tmpl
View File

@ -73,7 +73,7 @@
</div> </div>
<div class="ui container fluid padded" id="project-board"> <div class="ui container fluid padded" id="project-board">
<div class="board"> <div class="board {{if .CanWriteProjects}}sortable{{end}}">
{{range $board := .Boards}} {{range $board := .Boards}}
<div class="ui segment board-column" style="background: {{.Color}} !important;" data-id="{{.ID}}" data-sorting="{{.Sorting}}" data-url="{{$.Link}}/{{.ID}}"> <div class="ui segment board-column" style="background: {{.Color}} !important;" data-id="{{.ID}}" data-sorting="{{.Sorting}}" data-url="{{$.Link}}/{{.ID}}">

5
web_src/css/features/projects.css
View File

@ -6,6 +6,10 @@
margin: 0 0.5em; margin: 0 0.5em;
} }
.board.sortable .board-card {
cursor: move;
}
.board-column { .board-column {
background-color: var(--color-project-board-bg) !important; background-color: var(--color-project-board-bg) !important;
border: 1px solid var(--color-secondary) !important; border: 1px solid var(--color-secondary) !important;
@ -80,7 +84,6 @@
.board-card { .board-card {
margin: 4px 2px !important; margin: 4px 2px !important;
border-radius: 5px !important; border-radius: 5px !important;
cursor: move;
width: calc(100% - 4px) !important; width: calc(100% - 4px) !important;
padding: 0.5rem !important; padding: 0.5rem !important;
min-height: auto !important; min-height: auto !important;

2
web_src/js/features/repo-projects.js
View File

@ -36,7 +36,7 @@ function moveIssue({item, from, to, oldIndex}) {
} }
async function initRepoProjectSortable() { async function initRepoProjectSortable() {
const els = document.querySelectorAll('#project-board > .board'); const els = document.querySelectorAll('#project-board > .board.sortable');
if (!els.length) return; if (!els.length) return;
const {Sortable} = await import(/* webpackChunkName: "sortable" */'sortablejs'); const {Sortable} = await import(/* webpackChunkName: "sortable" */'sortablejs');