Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove jQuery from the webhook editor (#29211)

Browse Source 
- Switched to plain JavaScript
- Tested the webhook editing functionality and it works as before

# Demo using JavaScript without jQuery

![action](https://github.com/go-gitea/gitea/assets/20454870/b24c264d-d5e5-4954-8789-e72564a99027)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Yarden Shoham 2024-02-17 15:17:04 +02:00 committed by GitHub
parent c282d378bd
commit 27192bc321
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 27 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
web_src/js/features/comp/WebHookEditor.js
View File

@ -1,43 +1,41 @@
import $ from 'jquery'; import {POST} from '../../modules/fetch.js';
import {hideElem, showElem, toggleElem} from '../../utils/dom.js'; import {hideElem, showElem, toggleElem} from '../../utils/dom.js';
const {csrfToken} = window.config;
export function initCompWebHookEditor() { export function initCompWebHookEditor() {
if ($('.new.webhook').length === 0) { if (!document.querySelectorAll('.new.webhook').length) {
return; return;
} }
$('.events.checkbox input').on('change', function () { for (const input of document.querySelectorAll('.events.checkbox input')) {
if ($(this).is(':checked')) { input.addEventListener('change', function () {
showElem($('.events.fields')); if (this.checked) {
} showElem('.events.fields');
}); }
$('.non-events.checkbox input').on('change', function () { });
if ($(this).is(':checked')) { }
hideElem($('.events.fields'));
} for (const input of document.querySelectorAll('.non-events.checkbox input')) {
}); input.addEventListener('change', function () {
if (this.checked) {
hideElem('.events.fields');
}
});
}
const updateContentType = function () { const updateContentType = function () {
const visible = $('#http_method').val() === 'POST'; const visible = document.getElementById('http_method').value === 'POST';
toggleElem($('#content_type').parent().parent(), visible); toggleElem(document.getElementById('content_type').parentNode.parentNode, visible);
}; };
updateContentType(); updateContentType();
$('#http_method').on('change', () => {
updateContentType(); document.getElementById('http_method').addEventListener('change', updateContentType);
});
// Test delivery // Test delivery
$('#test-delivery').on('click', function () { document.getElementById('test-delivery')?.addEventListener('click', async function () {
const $this = $(this); this.classList.add('loading', 'disabled');
$this.addClass('loading disabled'); await POST(this.getAttribute('data-link'));
$.post($this.data('link'), { setTimeout(() => {
_csrf: csrfToken window.location.href = this.getAttribute('data-redirect');
}).done( }, 5000);
setTimeout(() => {
window.location.href = $this.data('redirect');
}, 5000)
);
}); });
} }