Shiloh/githaven
Shiloh/githaven
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add mssql migration tests (#6852)

Browse Source
This commit is contained in:
zeripath 2019-05-06 00:42:29 +01:00 committed by Lauris BH
parent 722a2bd7ec
commit 0081cd8dfe
5 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
integrations/migration-test/gitea-v1.5.3.mssql.sql.gz Normal file
View File

Binary file not shown.

BIN
integrations/migration-test/gitea-v1.6.4.mssql.sql.gz Normal file
View File

Binary file not shown.

BIN
integrations/migration-test/gitea-v1.7.0.mssql.sql.gz Normal file
View File

Binary file not shown.

14
integrations/migration-test/migration_test.go
View File

@ -13,6 +13,7 @@ import (
"path" "path"
"regexp" "regexp"
"sort" "sort"
"strings"
"testing" "testing"
"code.gitea.io/gitea/integrations" "code.gitea.io/gitea/integrations"
@ -120,8 +121,7 @@ func readSQLFromFile(version string) (string, error) {
if err != nil { if err != nil {
return "", err return "", err
} }
return string(base.RemoveBOMIfPresent(bytes)), nil
return string(bytes), nil
} }
func restoreOldDB(t *testing.T, version string) bool { func restoreOldDB(t *testing.T, version string) bool {
@ -199,11 +199,11 @@ func restoreOldDB(t *testing.T, version string) bool {
_, err = db.Exec("DROP DATABASE IF EXISTS gitea") _, err = db.Exec("DROP DATABASE IF EXISTS gitea")
assert.NoError(t, err) assert.NoError(t, err)
_, err = db.Exec("CREATE DATABASE gitea") statements := strings.Split(data, "\nGO\n")
assert.NoError(t, err) for _, statement := range statements {
_, err = db.Exec(statement)
_, err = db.Exec(data) assert.NoError(t, err, "Failure whilst running: %s\nError: %v", statement, err)
assert.NoError(t, err) }
db.Close() db.Close()
} }
return true return true

2
models/migrations/migrations.go
View File

@ -264,7 +264,7 @@ Please try to upgrade to a lower version (>= v0.6.0) first, then upgrade to curr
return err return err
} }
for i, m := range migrations[v-minDBVersion:] { for i, m := range migrations[v-minDBVersion:] {
log.Info("Migration: %s", m.Description()) log.Info("Migration[%d]: %s", v+int64(i), m.Description())
if err = m.Migrate(x); err != nil { if err = m.Migrate(x); err != nil {
return fmt.Errorf("do migrate: %v", err) return fmt.Errorf("do migrate: %v", err)
} }