Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
20de27d480
brotherton-erpnext/erpnext/accounts/doctype
History
Devin Slauenwhite 20de27d480
fix(accounts): validate payment entry references with latest data. (#31166) 
* test: payment entry over allocation.

* fix: validate allocated_amount against latest outstanding amount.

* fix: payment entry get outstanding documents for advance payments

* fix: only fetch latest outstanding_amount.

* fix: throw if reference is allocated

* test: throw error if a reference has been partially allocated after inital creation.

* chore: test name

* fix: remove unused part of test

* chore: linter

* chore: more user friendly error messages

* fix: only validate outstanding amount if partly paid and don't filter by cost center

* chore: minor refactor for doc.cost_center

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>

---------

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-06-13 19:06:53 +05:30
..
account feat(accounts): add Portuguese SNC CoA (#35486) 2023-06-01 15:38:18 +05:30
account_closing_balance fix: Ignore permissions while submitting account closing balance record (#35536) 2023-06-02 16:57:00 +05:30
accounting_dimension fix: enqueue_after_commit wherever it makes sense (#35588) 2023-06-07 11:58:36 +05:30
accounting_dimension_detail chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
accounting_dimension_filter fix: Label for applicable dimension table 2022-11-14 20:39:40 +05:30
accounting_period test: Matching Loan Repayment query in Bank Reco 2022-07-08 19:28:38 +05:30
accounts_settings refactor!: Remove custom cashflow report mapper (#35523) 2023-06-02 17:48:59 +05:30
advance_tax fix(refactor): Advance tds allocation to purchase invoice 2021-11-25 15:42:30 +05:30
advance_taxes_and_charges fix: Add tests 2021-11-25 23:58:16 +05:30
allowed_dimension chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
allowed_to_transact_with chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
applicable_on_account chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
bank feat: bank reconciliation and plaid changes (#33986) 2023-02-19 11:50:17 +05:30
bank_account perf: use get_cached_value instead of db.get_value in accounts module 2022-11-03 13:38:48 +05:30
bank_account_subtype chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
bank_account_type chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
bank_clearance fix: pass translated label to change button type (#35564) 2023-06-07 21:49:02 +05:30
bank_clearance_detail chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
bank_guarantee fix: check type for reference name 2022-11-13 19:58:49 +05:30
bank_reconciliation_tool fix: pass translated label to change button type (#35564) 2023-06-07 21:49:02 +05:30
bank_statement_import refactor: use job_id instead of job_name (#35242) 2023-05-10 13:26:10 +05:30
bank_transaction fix: v14, Bank Reconcile Tools not cover case JV debit bank (#35000) 2023-04-25 21:34:28 +05:30
bank_transaction_mapping chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
bank_transaction_payments chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
budget fix: Error while validating budget (#35487) 2023-05-31 10:51:33 +05:30
budget_account chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
campaign_item chore: Clean up imports (#27302) 2021-09-02 16:44:59 +05:30
cashier_closing style: format code with black 2022-03-28 18:52:46 +05:30
cashier_closing_payments chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
chart_of_accounts_importer fix: Column value mismatch in COA blank template (#34658) 2023-03-31 11:10:50 +05:30
cheque_print_template style: format code with black 2022-03-28 18:52:46 +05:30
closed_document chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
cost_center fix: abbreviation issue on renaming cost center 2022-09-15 12:09:18 +05:30
cost_center_allocation fix(patch): validation error on cost center allocation migration 2023-01-27 12:08:18 +05:30
cost_center_allocation_percentage fix: Allocation percentage fieldtype changed to percent 2022-02-01 22:26:39 +05:30
coupon_code Merge remote-tracking branch 'upstream/develop' into remove-india 2022-06-19 22:57:22 +05:30
currency_exchange_settings feat: disable currency exchange api. (#33593) 2023-01-16 21:00:10 +05:30
currency_exchange_settings_details fix: pre-commit issues 2021-11-04 05:25:48 +00:00
currency_exchange_settings_result fix: pre-commit issues 2021-11-04 05:25:48 +00:00
customer_group_item chore: Clean up imports (#27302) 2021-09-02 16:44:59 +05:30
customer_item chore: Clean up imports (#27302) 2021-09-02 16:44:59 +05:30
discounted_invoice chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
dunning fix: set Phone and Email option in doctypes (#35549) 2023-06-11 19:34:41 +05:30
dunning_letter_text chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
dunning_type chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
exchange_rate_revaluation fix: allow user to set rounding loss allowance for accounts balance 2023-06-12 22:05:08 +05:30
exchange_rate_revaluation_account refactor: Exchange rate revaluation to handle accounts with zero account balance (#33165) 2023-01-02 14:33:14 +05:30
finance_book style: format code with black 2022-03-28 18:52:46 +05:30
fiscal_year refactor: Use db.set_single_value (#35668) 2023-06-13 17:30:38 +05:30
fiscal_year_company chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
gl_entry refactor: Exchange rate revaluation to handle accounts with zero account balance (#33165) 2023-01-02 14:33:14 +05:30
invoice_discounting style: format code with black 2022-03-28 18:52:46 +05:30
item_tax_template perf: use get_cached_value instead of db.get_value in accounts module 2022-11-03 13:38:48 +05:30
item_tax_template_detail chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
journal_entry refactor: Use db.set_single_value (#35668) 2023-06-13 17:30:38 +05:30
journal_entry_account fix: Reference due date field type in Journal Entry Accounts table 2022-10-26 20:21:36 +05:30
journal_entry_template fix: Naming series error in Journal Entry template (#35084) 2023-05-01 10:50:51 +05:30
journal_entry_template_account chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
ledger_merge refactor: use job_id instead of job_name (#35242) 2023-05-10 13:26:10 +05:30
ledger_merge_accounts fix: import issue and minor fixes 2021-12-10 10:27:15 +00:00
loyalty_point_entry style: format code with black 2022-03-28 18:52:46 +05:30
loyalty_point_entry_redemption chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
loyalty_program style: format code with black 2022-03-28 18:52:46 +05:30
loyalty_program_collection chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
mode_of_payment perf: use get_cached_value instead of db.get_value in accounts module 2022-11-03 13:38:48 +05:30
mode_of_payment_account chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
monthly_distribution style: format code with black 2022-03-28 18:52:46 +05:30
monthly_distribution_percentage chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
opening_invoice_creation_tool refactor: use job_id instead of job_name (#35242) 2023-05-10 13:26:10 +05:30
opening_invoice_creation_tool_item fix: Opening invoice tool field placement 2022-03-21 19:34:57 +05:30
party_account fix: Ignore user perm for party account company 2022-04-04 12:32:33 +05:30
party_link style: format code with black 2022-03-28 18:52:46 +05:30
payment_entry fix(accounts): validate payment entry references with latest data. (#31166) 2023-06-13 19:06:53 +05:30
payment_entry_deduction fix: Set deduction amount in company currency on Doctype 2023-03-06 17:45:26 +05:30
payment_entry_reference perf: add indexes on payment entry reference (#33288) 2022-12-12 12:58:11 +05:30
payment_gateway_account refactor: make payments app a soft dependency (#33245) 2022-12-08 16:40:13 +05:30
payment_ledger_entry perf: use get_cached_value instead of db.get_value in accounts module 2022-11-03 13:38:48 +05:30
payment_order refactor: use db independent offset syntax (#31345) 2022-06-14 10:49:07 +05:30
payment_order_reference chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
payment_reconciliation fix: attribute error on payment reconciliation tool 2023-06-13 09:32:24 +05:30
payment_reconciliation_allocation fix: Exchange gain and loss booking on multi-currency invoice reconciliation (#32900) 2023-01-03 16:55:15 +05:30
payment_reconciliation_invoice fix: Exchange gain and loss booking on multi-currency invoice reconciliation (#32900) 2023-01-03 16:55:15 +05:30
payment_reconciliation_payment fix: Exchange gain and loss booking on multi-currency invoice reconciliation (#32900) 2023-01-03 16:55:15 +05:30
payment_request fix: Unable to create payment request against purchase invoice (#34762) 2023-04-06 12:40:58 +05:30
payment_schedule fix: fetch description only if empty on the payment schedule 2022-09-16 14:14:14 +05:30
payment_term style: format code with black 2022-03-28 18:52:46 +05:30
payment_terms_template style: format code with black 2022-03-28 18:52:46 +05:30
payment_terms_template_detail chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
period_closing_voucher fix: enqueue_after_commit wherever it makes sense (#35588) 2023-06-07 11:58:36 +05:30
pos_closing_entry fix: check for duplicate in pos closing and pos merge log entry 2023-02-21 17:50:57 +05:30
pos_closing_entry_detail chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pos_closing_entry_taxes chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pos_customer_group chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pos_field chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pos_invoice refactor: Use db.set_single_value (#35668) 2023-06-13 17:30:38 +05:30
pos_invoice_item refactor: added new file serial batch bundle 2023-06-02 17:14:14 +05:30
pos_invoice_merge_log fix: travis for POS merge invoice and putaway rule 2023-06-02 17:14:18 +05:30
pos_invoice_reference fix(pos): cannot close the pos if sr. no. is sold & returned 2022-03-24 16:22:36 +05:30
pos_item_group chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pos_opening_entry style: format code with black 2022-03-28 18:52:46 +05:30
pos_opening_entry_detail chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pos_payment_method chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pos_profile fix(pos): error while consolidating pos invoices 2022-08-10 14:17:28 +05:30
pos_profile_user chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pos_search_fields chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pos_settings chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pricing_rule feat: auto create serial and batch bundle 2023-06-02 17:14:16 +05:30
pricing_rule_brand chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pricing_rule_detail chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pricing_rule_item_code chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
pricing_rule_item_group chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
process_deferred_accounting test: pda document submission and cancellation 2022-09-02 12:34:02 +05:30
process_payment_reconciliation chore: convert throw to msgprint 2023-05-08 16:42:12 +05:30
process_payment_reconciliation_log feat: Reconcile Payments in background (#34596) 2023-04-22 17:24:35 +05:30
process_payment_reconciliation_log_allocations feat: Reconcile Payments in background (#34596) 2023-04-22 17:24:35 +05:30
process_statement_of_accounts chore: fix travis 2023-06-08 15:11:46 +05:30
process_statement_of_accounts_customer fix: Updates in process statement of Accounts (#35064) 2023-05-01 13:09:47 +05:30
promotional_scheme fix: promotional scheme min and max amount configuration 2022-09-12 16:53:52 +05:30
promotional_scheme_price_discount fix: Pricing Rule not created against the Promotional Scheme 2021-11-16 10:27:59 +05:30
promotional_scheme_product_discount chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
psoa_cost_center chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
psoa_project chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
purchase_invoice refactor: Use db.set_single_value (#35668) 2023-06-13 17:30:38 +05:30
purchase_invoice_advance chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
purchase_invoice_item fix: travis for sales and purchase invoice 2023-06-02 17:14:17 +05:30
purchase_taxes_and_charges chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
purchase_taxes_and_charges_template feat: show title field for Purchase Taxes and Charges 2022-05-16 16:19:32 +02:00
repost_payment_ledger Merge pull request #33663 from ruthra-kumar/attribute_error_on_repost_ple_tool 2023-01-16 09:36:22 +05:30
repost_payment_ledger_items feat: Repost Payment Ledger entries for vouchers 2022-11-08 07:47:47 +05:30
sales_invoice refactor: Use db.set_single_value (#35668) 2023-06-13 17:30:38 +05:30
sales_invoice_advance chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
sales_invoice_item refactor: added new file serial batch bundle 2023-06-02 17:14:14 +05:30
sales_invoice_payment chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
sales_invoice_timesheet chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
sales_partner_item chore: Clean up imports (#27302) 2021-09-02 16:44:59 +05:30
sales_taxes_and_charges chore: Update allow on submit for Sales Invoice fields 2022-10-17 16:48:13 +05:30
sales_taxes_and_charges_template perf: use get_cached_value instead of db.get_value in accounts module 2022-11-03 13:38:48 +05:30
share_balance chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
share_transfer fix: share_transfer display wrong currency symbo 2023-05-14 08:06:58 +05:30
share_type style: format code with black 2022-03-28 18:52:46 +05:30
shareholder style: format code with black 2022-03-28 18:52:46 +05:30
shipping_rule style: format code with black 2022-03-28 18:52:46 +05:30
shipping_rule_condition chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
shipping_rule_country chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
south_africa_vat_account chore: Clean up imports (#27302) 2021-09-02 16:44:59 +05:30
subscription Subscription Cost center value is fixed to Default value(Bug fix) 2022-12-11 08:51:34 +00:00
subscription_invoice chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
subscription_plan refactor: make payments app a soft dependency (#33245) 2022-12-08 16:40:13 +05:30
subscription_plan_detail chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
subscription_settings chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
supplier_group_item chore: Clean up imports (#27302) 2021-09-02 16:44:59 +05:30
supplier_item chore: Clean up imports (#27302) 2021-09-02 16:44:59 +05:30
tax_category style: format code with black 2022-03-28 18:52:46 +05:30
tax_rule refactor: Use db.set_single_value (#35668) 2023-06-13 17:30:38 +05:30
tax_withheld_vouchers fix: use hash based naming for tax withheld vouchers child table (#33643) 2023-01-20 18:53:39 +05:30
tax_withholding_account chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30
tax_withholding_category fix: incorrect TCS amount while customer has advance payment (#35397) 2023-06-10 20:55:30 +05:30
tax_withholding_rate fix: threshold fields shows incorrect currency 2022-01-13 12:06:03 +05:30
territory_item chore: Clean up imports (#27302) 2021-09-02 16:44:59 +05:30
__init__.py chore: remove utf-8 compat code 2021-11-05 11:16:29 +05:30