Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: check type for reference name

Browse Source
This commit is contained in:
Sagar Vora 2022-11-13 19:58:49 +05:30
parent a2260a3dc2
commit b06345af46
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/accounts/doctype/bank_guarantee/bank_guarantee.py
View File

@ -22,15 +22,18 @@ class BankGuarantee(Document):
@frappe.whitelist()
def get_voucher_details(bank_guarantee_type, reference_name):
def get_voucher_details(bank_guarantee_type: str, reference_name: str):
if not isinstance(reference_name, str):
raise TypeError("reference_name must be a string")
fields_to_fetch = ["grand_total"]
doctype = "Sales Order" if bank_guarantee_type == "Receiving" else "Purchase Order"
if doctype == "Sales Order":
if bank_guarantee_type == "Receiving":
doctype = "Sales Order"
fields_to_fetch.append("customer")
fields_to_fetch.append("project")
else:
doctype = "Purchase Order"
fields_to_fetch.append("supplier")
return frappe.db.get_value(doctype, reference_name, fields_to_fetch, as_dict=True)