- Hidden column should note be considered in the report
- Remove hardcoded currency formatting
- Remove duplicate letterhead in the report
(print_template already adds one)
- Remove extra quotes from Total Amount text
* Add master data to export
* add SQL statements to get customers and suppliers
* make data category a string
* fix SQL error
* fix SQL errors
* unique column names
* add encoding of constants
* get customer primary address and contact
* fix typo
* fix typo
* binary response
* add filename
* add filecontent
* rename account columns
* exclude account groups
* use compression, close file before transfer
* fix StringIO
* add basic tests
* fix assertion, merge test methods
* fix indentation
* relative import of constants
* fix path
* import os
* Add default currency to test company
* root accounts with parent = null
* move account-related things to setup()
* add: test headers
* company and filters become class properties
* add: test csv creation
* (fix): add missing account
* (fix): remove wrong space
* add items to sales invoice
* refactor: create test data
* fix: create cost center
* fix: doctype Accoutn
* fix: make sure account belongs to company
* fix: remove customer group and territory, save on a new line
* create default warehouses
* fix: make Item myself
* fix: item defaults are a list
* fix: use my own warehouse
* fix: use my own expense account
* fix: let you take care of the Sales Invoice Item
* fix: import zipfile
* add TODOs
* fix: workaround for pandas bug
* SQL: utf-8 everywhere to make conversion in tests unnecessary
* tests: zipfile must be encoded string
* fix(tests): invalid start byte
* fix(test): give is_zipfile() the file-like object it expects
* fix(test): fix encoding of colums
* fix(get_transactions): as_dict is 1 by default
* fix(tests): allow empty data
* refactor: rename columns in get_account_names
* fix(pandas): keep sorting columns
* fix: "lineterminator" must be a string
* fix(test): check if cost center exists
* fix: credit limit became a child table
* fix: save company after creation
* insert instead of save
* tests: setup_fiscal_year
* fix(test): import cstr
* fix(tests): fiscal year
* fix: can't concat str to bytes
* fix: make csv-encoding work for py2 and py3
* fix(test): use frappe.as_unicode instead of unicode
* fix: use BytesIO instead of StringIO for py3 compatibility
* fix(tests): use BytesIO instead of StringIO for py3 compatibility
* fix: pending on review date (#19609)
* fix: On Specific case if no item code in name
* fix: pending on review date
* feat: fetch leave approver from both employee and department approvers (#19613)
* fix: fetch leave approvers from both department and employee master
* fix: creaate a set of approvers
* fix(expense claim): fetch outstanding documents based on party account type
* fix: not able to select item in sales order
* fix: code cleanup
* fix: asset movement ux fixes (#19641)
* fix: Multiple fixes related to landed cost accounting (#19656)
* fix: last purchase rate greater than selling price
* Fixed Asset Refactor Review fixes (#19665)
* fix: fixed asset item creation ux fixes
* fix: auto creation of asset ux fixes
* fix: [LCV] incorrect condition when checking assets linked with PR
* fix: bulk update assets
* refac: remove company level cwip enabling
* cwip can be enabled only on category level
* fix: #19649
* fix: remove asset movement mandatory fields
* fix: label for reference doctype
* fix: Remove redundant purchase orders and unwanted condition
* fix: [WIP] Purchase receipt value
* fix: Add raw material cost based on transfered raw material
* fix: get_qty_to_be_received
* fix: Remove debugger statement
* fix: Reset rm_supp_cost before setting subcontracted raw_materials
* test: Fix and modify tests for backflush_based_on_stock_entry
* fix: Add non stock items to Purchase Receipt from Purchase Order
* fix: Ignore valuation rate check for non stock raw material
* fix: Rename check all rows
* fix: Remove amount from test
* test: Fix item rate error
* fix: handling of serial nos in backflush
* fix: Add serial no. of raw materials
* fix: [WIP] Handle Batch nos for purchase reciept backflushed raw material
* fix: Raw material batch number selection in purchase receipt
* Update test_purchase_order.py
account_groups = [accounts[d]["account_type"] for d in accounts if accounts[d]['is_group'] not in ('', 1)]
- if accounts[d]['is_group'] not in ('', 1) is wrong because it returns false even if the account is a group.
- should be if accounts[d]['is_group'] not in ('', 0)
However, the correction provided here:
account_groups = [accounts[d]["account_type"] for d in accounts if accounts[d]['is_group'] == 1]
is more consistent with the prior statement that extracts ledger (and not group) accounts.
account_types = [accounts[d]["account_type"] for d in accounts if not accounts[d]['is_group'] == 1]
