Ankush Menat
7e555d3d8c
fix: item price query for postgres
...
postgres doesn't like bad type comparisons and doesn't have `isnull`
funciton
2022-04-26 11:47:02 +05:30
Ankush Menat
7d2587c0a9
fix: nullish check and table name
2022-04-26 11:03:32 +05:30
Ankush Menat
0fdfc1e76e
fix: only query fields that exist
2022-04-26 11:03:32 +05:30
Ankush Menat
ce75fe0ec4
fix: out of range date value
2022-04-26 11:03:32 +05:30
Ankush Menat
cdac2b8c63
fix: ignore duplicate fixtures
2022-04-26 11:03:32 +05:30
Ankush Menat
e1c1687661
refactor: use db agnostic CombineDatetime
2022-04-26 11:03:32 +05:30
Deepesh Garg
d3582ea399
fix: Allow multi-currency opening invoices
2022-04-25 18:18:39 +05:30
Deepesh Garg
4ffea617ef
Merge pull request #30754 from deepeshgarg007/round_off_account_cost_center
...
fix: First preference to parent cost center rather than round off cost center
2022-04-25 17:06:19 +05:30
Deepesh Garg
3fa1c63479
test: Unit test for round off entry dimensions
2022-04-25 16:29:26 +05:30
Deepesh Garg
b1158bcb7c
Merge pull request #30799 from nextchamp-saqib/einv-cess-fix
...
fix(india): cess value not considered while validating e-invoice totals
2022-04-25 14:39:15 +05:30
Deepesh Garg
f064e0b15e
Merge pull request #30642 from rahib-hassan/separate-discount-account
...
feat: separate discount accounting for buying and selling
2022-04-25 14:07:20 +05:30
Saqib Ansari
8e6c7a6bf7
fix(india): cess value not considered while validating e-invoice totals
2022-04-25 14:02:46 +05:30
Deepesh Garg
02aaa6546c
chore: Remove dead code
2022-04-25 12:42:06 +05:30
Deepesh Garg
22bc107d70
Merge pull request #30778 from deepeshgarg007/accpunting_dimension_validate_ignore_new
...
fix: Do not validate while creating accounting dimension
2022-04-25 12:30:51 +05:30
rahib-hassan
6c86067d90
Merge branch 'develop' into separate-discount-account
2022-04-25 12:17:50 +05:30
Ankush Menat
d6a43a39ae
test: tie breaking in SLEs ( #30796 )
...
[skip ci]
2022-04-25 11:46:01 +05:30
Deepesh Garg
618fa0e8ea
Merge branch 'develop' into accpunting_dimension_validate_ignore_new
2022-04-24 20:55:50 +05:30
Deepesh Garg
afc6aa88f0
Merge pull request #30763 from deepeshgarg007/loan_reconciliation
...
fix: Add loan doctypes in bank clearance
2022-04-24 20:55:29 +05:30
Deepesh Garg
c515abc392
test: Remove teardown method
2022-04-24 19:20:29 +05:30
Deepesh Garg
c312cd3725
fix: Check if accounting dimension exists
2022-04-24 18:11:32 +05:30
Deepesh Garg
783793deac
Merge branch 'develop' of https://github.com/frappe/erpnext into round_off_account_cost_center
2022-04-23 21:40:38 +05:30
Deepesh Garg
015812b0b8
fix: Add accounting dimensions for round off GL Entry
2022-04-23 21:40:08 +05:30
Deepesh Garg
d4d83f4bb6
test: Fixes in test case
2022-04-23 12:33:35 +05:30
Deepesh Garg
0eacc99ab7
test: Fixes in test case
2022-04-23 12:08:30 +05:30
Rucha Mahabal
deed9702cf
Merge pull request #30780 from ruchamahabal/promotion-enhancements
2022-04-22 22:33:39 +05:30
Rucha Mahabal
8e5327a0e0
fix: clear property child table on changing employee
2022-04-22 21:33:24 +05:30
Rucha Mahabal
9d158088ee
chore: remove unused Employee Transfer Property doctype
2022-04-22 20:20:12 +05:30
Rucha Mahabal
cfa4dfe7a8
fix: reset old CTC on promotion cancellation
2022-04-22 20:20:04 +05:30
Rucha Mahabal
9b93c63830
fix: tests
2022-04-22 17:54:32 +05:30
Wolfram Schmidt
43c1d63ab2
fix translation ( #30781 )
...
fixed the short word for March in german language
2022-04-22 17:32:34 +05:30
Rucha Mahabal
788e0a1c6c
chore: format employee_property_update.js
2022-04-22 17:25:37 +05:30
Rucha Mahabal
ed04241cf4
Merge branch 'develop' into promotion-enhancements
2022-04-22 16:38:01 +05:30
Rucha Mahabal
833a33a94b
test: employee property update via Employee Promotion
2022-04-22 16:28:25 +05:30
Rucha Mahabal
a93867de19
feat: add CTC fields in Employee master and Promotion
2022-04-22 16:28:14 +05:30
marination
8d632e9b9c
style: Re-run pre-commit
2022-04-22 16:27:29 +05:30
marination
b848e61954
fix: Skip unpublished Variants with published templates in shopping cart quote validation
2022-04-22 16:25:56 +05:30
Devin Slauenwhite
53d8168dea
fix: linter format string after translation
2022-04-22 16:25:28 +05:30
Devin Slauenwhite
ea6d6e31b3
fix: linter trilaing whitespace
2022-04-22 16:25:21 +05:30
Devin Slauenwhite
48da3b4482
fix: sider issues
2022-04-22 16:23:18 +05:30
Devin Slauenwhite
b88d5d135e
fix(test): validate exception without website item
2022-04-22 16:23:07 +05:30
Devin Slauenwhite
86832fb7fe
test: assert error if quotation contains non website item
2022-04-22 16:22:58 +05:30
Devin Slauenwhite
678a1179d4
fix: shopping cart quotation without website item
2022-04-22 16:22:32 +05:30
Deepesh Garg
9bb132fdd3
fix: Do not validate while creating accounting dimension
2022-04-22 13:39:43 +05:30
Vladislav
e088e65871
fix: update translation ( #30725 )
...
* Update ru.csv
* Update ru.csv
* Update ru.csv
* Update ru.csv
* Update ru.csv
* Update ru.csv
* Update ru.csv
* Update ru.csv
* Update ru.csv
2022-04-22 11:00:57 +05:30
Deepesh Garg
81b3342480
Merge pull request #30757 from nextchamp-saqib/einv-401-fix
...
fix(india): 401 & 403 client error while generating IRN
2022-04-21 18:55:26 +05:30
Deepesh Garg
8a8476bb5c
test: Add test coverage for bank clearance
2022-04-21 18:53:18 +05:30
Ankush Menat
d5ab626a31
Merge pull request #30726 from ankush/dependent_gle_reposting
...
fix: dependent gle reposting
2022-04-21 18:06:40 +05:30
Ankush Menat
ee3036651a
fix: batch_no filtering not working when batch no is also a number in scientific notation ( #30770 )
...
[skip ci]
2022-04-21 16:34:31 +05:30
rahib-hassan
78c8e46511
Merge branch 'develop' into separate-discount-account
2022-04-21 15:06:58 +05:30
Deepesh Garg
c42547d40f
fix: Use parent cost center for Sales and Purchase Invoice
2022-04-21 13:26:44 +05:30
Marica
87f1617780
Merge branch 'develop' into field-filters-e-com
2022-04-21 12:32:33 +05:30
marination
c5d4bed932
test: setup e commerce settings before running invalid filtrs test
2022-04-21 12:29:30 +05:30
Rucha Mahabal
c3dc5d5ce7
fix: property addition not working for select fields
2022-04-21 08:17:00 +05:30
rahib-hassan
02e17dbded
fix: removed manual enable-discount-account method
2022-04-21 02:42:42 +05:30
rahib-hassan
2c78cc2014
fix: removed manual rollback - enable discount account
2022-04-21 02:40:59 +05:30
Deepesh Garg
3d0e68acaa
fix: select doctype as payment_document
2022-04-20 19:49:53 +05:30
Deepesh Garg
c3e27b5556
fix: Loan doctypes in bank reconciliation
2022-04-20 19:07:53 +05:30
marination
8981405a62
test: Field filter validation and Custom field as field filter
...
- Test to block Item fields (which aren’t in Website Item) in E Commerce Settings as filters
- Removed unnecessary function and setup in E Commerce Settings test
- Removed commented useless test
- Test to check custom field as filter
2022-04-20 18:50:47 +05:30
marination
6d750e185e
fix: Handle Multiselect field mapping separately
...
- Map Multiselect child table to Website Item (copy rows)
2022-04-20 17:40:03 +05:30
rahib-hassan
13092bcc2d
fix: enable discount roll_back
2022-04-20 16:46:29 +05:30
rahib-hassan
1e143e7479
fix: use @change_settings to enable_discount_account
2022-04-20 16:06:55 +05:30
rahib-hassan
f3fa6ac4c2
fix: account setting seperation gl discount account creation
2022-04-20 16:01:12 +05:30
Rucha Mahabal
5411e69553
fix: filters not working in Shift Assignment Calendar view ( #30752 )
2022-04-20 14:56:06 +05:30
Saqib Ansari
ee8047aba3
fix(india): 401 & 403 client error while generating IRN
2022-04-20 14:14:29 +05:30
rahib-hassan
f058755ad3
fix: test cases updated
2022-04-20 13:24:15 +05:30
HENRY Florian
143786aaa0
fix: Must not be able to start Job Card if it is related to Work Order that is not started yet ( #29072 )
...
* fix: Cannot start Job strat if related to Work Order not started yet
* fix: Cannot start Job strat if related to Work Order not started yet
* test
* test
* fix siders
* PR review
* chore: Code cleanup
- Better short circuit for if condition (make it such that both conditions dont always have to be computed)
- Remove `r.message` extraction by avoiding `then()`
* chore: Remove unnecessary json change
Co-authored-by: marination <maricadsouza221197@gmail.com>
2022-04-20 12:29:52 +05:30
marination
5660b335ba
fix: Mistyped variable name in patch
2022-04-20 12:25:59 +05:30
Deepesh Garg
0ac11a5b30
fix: First preference to parent cost center rather than round off cost center
2022-04-20 12:18:11 +05:30
Ankush Menat
9734329094
test: discard local future SLE cache between tests
2022-04-19 17:40:28 +05:30
Ankush Menat
700e864d90
fix: sort stock vouchers before reposting GLE
2022-04-19 17:40:26 +05:30
Ankush Menat
b24920c0e9
fix: correct sorting while updating bin
2022-04-19 17:38:36 +05:30
Ankush Menat
d2882ea436
test: use disposable item codes in tests
...
dependency causes flake
2022-04-19 17:38:36 +05:30
Ankush Menat
8f519545b0
test: repost queue progress
2022-04-19 17:38:36 +05:30
Ankush Menat
ecdb49314f
fix: dependent GLE reposting
2022-04-19 17:38:36 +05:30
Ankush Menat
a2af2daca7
test: dependent GL entry reposting
2022-04-19 17:38:36 +05:30
Ankush Menat
afc5a55a23
refactor: repost error handling
2022-04-19 17:38:36 +05:30
FinByz Tech Pvt. Ltd
54a05075f3
fix(india): transporter name is null while generating e-way bill ( #30736 )
...
(cherry picked from commit 6291b28c37f02380001ab68b3a660b2804383ab2)
2022-04-19 10:57:59 +00:00
Rucha Mahabal
789fa31b82
Merge branch 'develop' into shift-type-null-in-employee-checkin
2022-04-19 13:39:32 +05:30
Rucha Mahabal
3cddc1e97e
test: shift fetching when assignment has an end date
2022-04-19 13:39:03 +05:30
Rucha Mahabal
98cccf221e
fix: shift fetching fails in Employee Checkin if shift assignment has an end date
...
Co-authored-by: Ejaaz Khan <ejaazrkhan@gmail.com>
2022-04-19 13:17:36 +05:30
Rucha Mahabal
7c547f152f
fix(patch): check if column is present while fixing reverse linking ( #30737 )
2022-04-19 12:18:46 +05:30
marination
d0cd194398
chore: Patch to copy custom fields (field filters) from Item to Website Item
2022-04-18 21:40:19 +05:30
Deepesh Garg
d96bfe13a8
Merge pull request #30721 from ruthra-kumar/bug_so_analysis_report
...
fix: SO's without delivery note will also be fetched
2022-04-18 19:58:37 +05:30
marination
1e80b97915
refactor: Change Filter Fields table fieldtype to Autocomplete
...
- Remove dynamic js fieldtype change to `Select`
2022-04-18 19:01:43 +05:30
marination
d35b37881b
fix: Validate field filter wrt to Website Item & re-use validation in Item Group
2022-04-18 18:51:48 +05:30
Marica
8a366309e1
Merge branch 'develop' into field-filters-e-com
2022-04-18 18:11:25 +05:30
marination
c993ac09df
fix: Query filter fields from Website Item instead of Item master
...
- tweak `filters.py` to correctly query filter field values from Website Item
- Use Website Item for filter field options in Settings and Item Group Field Filter table
2022-04-18 18:01:48 +05:30
rahib-hassan
bcfbb3e9c8
fix: code formatting
2022-04-18 15:04:47 +05:30
rahib-hassan
ebb7bc201b
fix: library import formatting
2022-04-18 14:53:45 +05:30
Deepesh Garg
264ec65255
Merge pull request #30728 from deepeshgarg007/pricing_rule_apply_mapped_doc
...
fix: Price changing on creating Sales return from Delivery Note
2022-04-18 14:34:28 +05:30
rahib-hassan
52fd804aed
Merge branch 'develop' of github.com:rahib-hassan/erpnext into separate-discount-account
2022-04-18 14:13:46 +05:30
Deepesh Garg
9c081947ec
fix: Price changing on creating Sales retrun from Delivery Note
2022-04-18 10:21:15 +05:30
Deepesh Garg
5cdd0d6719
fix: Move tax withholding category field
2022-04-16 20:34:56 +05:30
Deepesh Garg
0a67b0239e
fix: Consistent customer and supplier forms
2022-04-16 19:43:59 +05:30
ruthra kumar
13487e2408
test: Sales order analysis report
2022-04-16 12:02:32 +05:30
Bhavesh Maheshwari
72757994f8
fix: process statement to_date override
...
(cherry picked from commit 378d15d388ae9cac7a5f897af83c99605403503a)
2022-04-14 13:14:11 +00:00
ruthra kumar
e28e6726f1
fix: SO analysis rpt will fetch SO's without Delivery note as well
2022-04-14 18:37:46 +05:30
Ankush Menat
9af2d68945
refactor: convert queries to ORM/QB, add types
2022-04-14 18:05:38 +05:30
Ankush Menat
ba29323e11
test: increase assertions to cover all cases
2022-04-14 18:05:38 +05:30
Ankush Menat
e278ee359a
test: item attribute columns
2022-04-14 18:05:38 +05:30
Ankush Menat
febc74a21b
refactor: rewrite stock balance query to QB
2022-04-14 18:05:35 +05:30
Ankush Menat
8a499e95d3
test: uom conversion in stock balance report
2022-04-14 18:01:43 +05:30
Ankush Menat
af0ea7b532
test: assert balanaces against SLE
2022-04-14 18:01:42 +05:30
Ankush Menat
f4766ae4eb
test: opening balance in stock balance report
2022-04-14 18:01:42 +05:30
Ankush Menat
8b2432dfa0
test: stock balance report tests
2022-04-14 18:01:42 +05:30
Ankush Menat
64ac22af82
refactor: add filter type info
2022-04-14 18:01:42 +05:30
HENRY Florian
e6aa28ea14
fix: update translation ( #30716 )
...
* fix: update translation
* fix: update translation
* fix: update translation
* fix: update translation
2022-04-14 17:46:47 +05:30
Ankush Menat
15576c1ce8
Merge pull request #30707 from marination/values-out-of-sync-jv
...
fix: Remove "Values Out of Sync" validation
2022-04-14 17:39:18 +05:30
Ankush Menat
0d64349142
Merge branch 'develop' into separate-discount-account
2022-04-14 17:29:28 +05:30
rahib-hassan
4130493b58
fix: Label typo
2022-04-14 16:03:08 +05:30
rahib-hassan
01fde15bd5
fix: dependent codes updated
2022-04-14 15:48:55 +05:30
rahib-hassan
0eff74c650
fix: tabspacing
2022-04-14 15:42:16 +05:30
Deepesh Garg
1659f1eb6d
Merge pull request #29963 from nabinhait/income-tax-computation
...
feat: Income tax computation Report
2022-04-14 15:31:17 +05:30
Deepesh Garg
e2fa9f708e
Merge pull request #30710 from deepeshgarg007/advance_jv_allocation
...
fix: Exchange gain and loss on advance Journal Entry allocation
2022-04-14 15:10:04 +05:30
Nabin Hait
cd2ab32242
fix: orginised code
2022-04-14 14:05:21 +05:30
Nabin Hait
bc7007d588
fix: get enabled deduction components
...
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
2022-04-14 14:02:01 +05:30
Nabin Hait
d06b7378f8
fix: get enabled and submitted income tax slab
...
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
2022-04-14 14:01:44 +05:30
Nabin Hait
67086e618d
fix: get enabled earning components
...
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
2022-04-14 14:00:28 +05:30
Marica
87117313a1
Merge branch 'develop' into values-out-of-sync-jv
2022-04-14 13:41:27 +05:30
Deepesh Garg
c38be53ce8
test: Update customer in Sales Invoice
2022-04-14 13:26:47 +05:30
Suraj Shetty
11fa187263
Merge pull request #30715 from surajshetty3416/fix-exotel-call-log
2022-04-14 12:45:15 +05:30
Suraj Shetty
77599fe443
fix: Set correct options for link field
...
issue introduced via https://github.com/frappe/erpnext/pull/30711
2022-04-14 12:32:31 +05:30
Deepesh Garg
86cfa3a53f
Merge pull request #30712 from frappe/mergify/bp/develop/pr-30700
...
fix: Payment reco query with max invoice and payment amount limit (backport #30700 )
2022-04-14 12:32:11 +05:30
marination
d75d5ebe8d
chore: Remove Values Out of Sync from Repost hourly job
...
- It runs after repost (after commiting), so it has 0 impact on repost itself
- Just that scheduled job log shows up as failed, while actually repost is done and repost document is "Completed"
- The check is inaccurate also, so best to remove this
- Users cant do anything about it anyway. This just piles up phantom failed jobs unneccessarily
2022-04-14 12:30:06 +05:30
Deepesh Garg
065c38152a
Merge branch 'develop' of https://github.com/frappe/erpnext into item_wise_provisional_accounting
2022-04-14 12:04:21 +05:30
Deepesh Garg
ad171c6225
test: Update test case
2022-04-14 12:03:12 +05:30
Deepesh Garg
e6cb948a96
fix: Payment reco query with max invocie and payment amount limit
...
(cherry picked from commit 4008c95ac6afc3b06a0a602e3f469db61e1f0453)
2022-04-14 05:42:17 +00:00
Deepesh Garg
972d9ec5b4
test: Update customer
2022-04-14 11:10:41 +05:30
Suraj Shetty
6e837bcdfc
style: Fix linter warning
2022-04-14 10:02:15 +05:30
Suraj Shetty
c272170b86
fix(call log): Convert Data to Link for type_of_call
...
Convert `Data` to `Link` for type_of_call,
employee_user_id and call_received_by fields
2022-04-14 09:51:54 +05:30
Deepesh Garg
31883b699d
fix: Exchange gain and loss on advance jv allocation
2022-04-13 20:52:25 +05:30
Ankush Menat
79fbc2c504
test: flaky PR close test ( #30709 )
2022-04-13 20:42:25 +05:30
Suraj Shetty
d890ee9495
Merge pull request #29962 from nemesis189/exotel-fixes
...
fix: Exotel Call Log fixes
2022-04-13 20:36:03 +05:30
Suraj Shetty
ff41b8da4e
fix: Update received_by if "to" is changed
2022-04-13 20:12:08 +05:30
Suraj Shetty
cef28df8db
test: Do not overwrite frappe.form_dict to retain proxy reference
...
Set frappe.local.form_dict instead
2022-04-13 19:10:19 +05:30
marination
89fab78027
fix: Remove "Values Out of Sync" validation from Journal Entry
...
- Even if there is a difference there's not much a user can do
- Checking it at the JV level is senseless. Blindly making users post another JV will lead to more error.
- Users making JV are usually accountants who know what they are doing
- The validation computes incorrect values for an account that contributes partially to warehouse's value.
2022-04-13 18:44:50 +05:30
Raffael Meyer
6453fb4cea
refactor!: remove DATEV integration ( #30584 )
...
The DATEV integration follows the trend and moves into a separate app.
- the DATEV Integration will be maintained at https://github.com/alyf-de/erpnext_datev (version-14 branch)
- the German Compliance and Localization will be maintained at https://github.com/alyf-de/erpnext_germany
2022-04-13 09:24:19 +00:00
Marica
c5247a0767
Merge branch 'develop' into pp-wo-company
2022-04-13 11:52:15 +05:30
marination
6315acc450
fix: Map correct company to PO made via Prod Plan (subcontract)
2022-04-13 11:47:58 +05:30
Ankush Menat
bfaaebde0d
Merge branch 'develop' into separate-discount-account
2022-04-12 18:38:23 +05:30
Deepesh Garg
228195ba74
Merge pull request #30689 from deepeshgarg007/disabled_gl_dimensions
...
fix: Do not show disabled dimensions in reports
2022-04-12 16:11:07 +05:30
Deepesh Garg
4f9b38a591
Merge pull request #30686 from nabinhait/ignore-permlevel-for-fields
...
feat: Ignore permlevel for specific fields
2022-04-12 15:55:28 +05:30
Noah Jacob
8261b2bb4f
refactor: trigger generate schedule when any change made in items table ( #29874 )
...
* refactor: trigger generate schedule when any change made in items table
* chore: added serial validation on server side
* test: serials updated in schedules after save
* fix: schedule not generating after updating some fields
* feat: generate_schedule is triggered on_save when items table is changed
* test: updated tests to check other field changes on save
* chore: removed serial validation function for schedules table and added no_of_visits validation function
* test: updated for manually deleted schedele rows
* refactor: updated validate_items_table_change to return bool
* test: updated test_schedule_with_serials to cover validate_items_table_change
* fix: linting
2022-04-12 15:30:49 +05:30
Deepesh Garg
9a1c560c82
fix: Do not show disabled dimensions in reports
2022-04-12 15:27:08 +05:30
marination
2777c5c67c
fix: Map Production Plan company in subassembly WO created from it
2022-04-12 14:30:01 +05:30
Nabin Hait
993c6c0de9
feat: Ignore permlevel for specific fields
2022-04-12 12:24:47 +05:30
Ankush Menat
60fb71bd2a
fix: ignore item-less maintenance visit for sr no ( #30684 )
2022-04-12 11:14:02 +05:30
Deepesh Garg
7d263e9ecf
Merge pull request #30651 from deepeshgarg007/gst_download_json_key_error
...
fix: Download JSON for GSTR-1 report
2022-04-12 00:06:25 +05:30
Marica
014298a867
Merge pull request #30674 from marination/work-order-partial-transfer
...
fix: Handle multiple item transfer in separate SEs against WO
2022-04-11 17:23:57 +05:30
Deepesh Garg
79b90118e1
Merge branch 'develop' into gst_download_json_key_error
2022-04-11 17:15:04 +05:30
