Deepesh Garg
7205fb9b97
chore: convert sales common to utils
2023-07-23 12:07:21 +05:30
ruthra kumar
ec7558b9e0
refactor: handle references without any template and payment_term
2023-07-23 11:55:16 +05:30
ruthra kumar
662ccd467c
fix: allocation logic on 'Get Outstanding Invoices' btn in PE
...
1. fixed broken `payment_term` filter in Payment References section
2. Throw error if user fails to select 'Payment Term' for an invoice
with 'Payment Term based allocation' enabled.
2023-07-23 11:37:27 +05:30
Deepesh Garg
4077254b01
chore: resolve undefined variables issue
2023-07-22 23:07:18 +05:30
Deepesh Garg
6b2dbdd394
Merge branch 'develop' into skip_tcs
2023-07-22 18:38:45 +05:30
ruthra kumar
e6abe1b77f
Merge pull request #36206 from ruthra-kumar/test_cases_for_payment_term_overallocation
...
test: overallocation validation in payment entry
2023-07-22 10:41:01 +05:30
ruthra kumar
93246043ec
chore(test): enable multi-currency party for testing
2023-07-22 10:01:59 +05:30
ruthra kumar
8f9ef4ef5b
chore: validation on multi-currency tran on company curtency account
2023-07-22 09:20:55 +05:30
ruthra kumar
5b37919574
chore: use flt for currency
2023-07-22 09:20:55 +05:30
ruthra kumar
6b4a81ee48
chore: test more scenarios
2023-07-22 09:20:44 +05:30
DaizyModi
653117c2a9
test: fix test case for itemised tax breakup
2023-07-21 17:56:33 +05:30
Ritvik Sardana
7069e2a5a0
fix: removed validate_item_code function in sales_invoice
2023-07-21 17:18:35 +05:30
Deepesh Garg
cc36af57bd
Merge pull request #36229 from deepeshgarg007/naming_in_order
...
fix: FY in naming series variable for orders
2023-07-21 16:05:31 +05:30
Deepesh Garg
7a7d32db81
fix: FY in naming series variable for orders
2023-07-21 16:03:17 +05:30
Gursheen Anand
ec80dc6f09
fix: make column names more general
2023-07-21 15:55:31 +05:30
Gursheen Anand
1c5c310f5a
fix: fetch acc dimension fieldname
2023-07-21 13:37:48 +05:30
Gursheen Anand
59a2a04fcc
fix: check gl entry status using is_cancelled
2023-07-21 13:22:01 +05:30
Gursheen Anand
1c033ce635
chore: change column format for report
2023-07-21 11:00:19 +05:30
Gursheen Anand
33f8f7d7b3
fix: exclude cancelled gl entries for opening balance
2023-07-21 10:57:55 +05:30
Deepesh Garg
76db0b63ba
Merge pull request #36214 from deepeshgarg007/tb_cancelled_entries
...
fix: Trial Balance report considering cancelled entries
2023-07-20 18:48:03 +05:30
Deepesh Garg
fd58bbff6b
fix: Trial Balance report considering cancelled entries
2023-07-20 17:51:54 +05:30
Deepesh Garg
3bc79eebe3
Merge pull request #35689 from marination/payments-based-dunning
...
feat: Payments based dunning
2023-07-20 12:06:36 +05:30
ruthra kumar
e7e3853f81
test: overallocation validation in payment entry
2023-07-20 09:08:55 +05:30
Gursheen Anand
3f5afb9cac
fix: reset dimension defaults when company changedin test
2023-07-19 18:15:59 +05:30
Gursheen Anand
23e56d3ec1
fix: clear dimension defaults after test
2023-07-19 16:07:32 +05:30
Deepesh Garg
3759a41b83
fix: Default fiscal year in accounting, buying and sellingcharts
2023-07-19 13:17:12 +05:30
Gursheen Anand
2f7b112736
fix: filter by party in opening row calculation
2023-07-19 12:36:44 +05:30
Gursheen Anand
e19a6f5dcb
fix: fetch acc dimensions correctly when fieldname is different from name
2023-07-19 12:26:57 +05:30
Gursheen Anand
b3f6d991b5
fix: duplicate acc dimension in test
2023-07-19 12:02:26 +05:30
Gursheen Anand
dd37f6cbd6
fix: show tax withholding category details for customers
2023-07-19 11:51:45 +05:30
ruthra kumar
bccfd22fc0
Merge pull request #36181 from ruthra-kumar/fix_broken_overallocation_validation_on_multi_term_payment_against_invoice
...
fix: broken overallocation validation in payment entry
2023-07-19 10:46:41 +05:30
ruthra kumar
ee83f94bb0
refactor: payment term outstanding in party account currency
2023-07-19 10:06:49 +05:30
ruthra kumar
f8d4b19cb9
fix: broken overallocation validation in payment entry
...
In a multi term payment schedule, overallocation logic broke. Fixing
it using individual term outstanding amount in references. this should
work for the simple, one term payment schedule as well
2023-07-18 21:04:13 +05:30
mergify[bot]
b4db5e9561
fix: validate docs in closed accounting period on save ( #36157 )
...
fix: validate docs in closed accounting period on save (#36157 )
(cherry picked from commit 5985e02574e387ef92a2bf0a9d2d1b49ad57cdd3)
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
2023-07-18 17:40:49 +05:30
Gursheen Anand
77deac4fb9
test: PI offsetting entry for accounting dimension
2023-07-18 15:51:01 +05:30
Deepesh Garg
fbea61bbc6
fix: Trailing opening entries in Accounts closing balance ( #36175 )
2023-07-18 15:16:52 +05:30
Gursheen Anand
3a3ffa2307
fix: divide offsetting amount only when account exists
2023-07-18 12:51:09 +05:30
Deepesh Garg
cfae52a40a
fix: Opening balance in TB report ( #36171 )
2023-07-18 12:26:19 +05:30
Gursheen Anand
1e1e4b93c1
fix: divide offsetting amount for multiple dimensions
2023-07-18 12:12:24 +05:30
Deepesh Garg
9e791efc82
refactor: client side accounts controller
2023-07-17 21:44:43 +05:30
Gursheen Anand
ed3bef1840
fix: dict value for dimension for gl entries defined without the dimension
2023-07-17 18:40:52 +05:30
Gursheen Anand
4004427892
test: TB report balanced whenfiltered using acc dimension
2023-07-17 17:57:03 +05:30
Gursheen Anand
22ba12172f
fix: make offsetting entry for all doctypes
2023-07-17 15:17:53 +05:30
Marica
1c1e7380e3
Merge branch 'develop' into payments-based-dunning
2023-07-17 12:33:19 +05:30
Gursheen Anand
4e09de4db2
fix: fetch accounting dimension details specific to company
2023-07-17 11:47:33 +05:30
Anand Baburajan
305c37917f
chore: add validation for account type of party type and account ( #36141 )
...
chore: add validation to check if account type of party type and account match
2023-07-17 11:00:19 +05:30
Deepesh Garg
6270607c6d
fix: Remove current fiscal year from Global Defaults ( #35960 )
...
* fix: Remove current fiscal year from Global Defaults
* fix: Remove button to set default
* fix: Add utils to get fiscal year
* fix: Incorrect import
* feat: Add hook for naming series parser
2023-07-16 12:58:42 +05:30
Deepesh Garg
f0d4c4c180
Merge branch 'develop' of https://github.com/frappe/erpnext into eslint
2023-07-15 20:29:14 +05:30
Gursheen Anand
d3759b3971
fix: make offsetting entry for acc dimensions
2023-07-15 19:32:56 +05:30
Deepesh Garg
3fa2a8c2d8
chore: fix linting issues
2023-07-15 18:03:16 +05:30
