Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: resolve undefined variables issue

Browse Source
This commit is contained in:
Deepesh Garg 2023-07-22 23:07:18 +05:30
parent 0b1e78e127
commit 4077254b01
11 changed files with 17 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.pre-commit-config.yaml
View File

@ -29,7 +29,8 @@ repos:
cypress/.*|
.*node_modules.*|
.*boilerplate.*|
erpnext/public/js/controllers/.*
erpnext/public/js/controllers/.*|
erpnext/templates/pages/order.js
)$
- repo: https://github.com/PyCQA/flake8

6
erpnext/accounts/doctype/cost_center/cost_center.js
View File

@ -70,7 +70,7 @@ frappe.ui.form.on('Cost Center', {
}
],
primary_action: function() {
var data = d.get_values();
let data = d.get_values();
if(data.cost_center_name === frm.doc.cost_center_name && data.cost_center_number === frm.doc.cost_center_number) {
d.hide();
return;
@ -91,8 +91,8 @@ frappe.ui.form.on('Cost Center', {
if(r.message) {
frappe.set_route("Form", "Cost Center", r.message);
} else {
me.frm.set_value("cost_center_name", data.cost_center_name);
me.frm.set_value("cost_center_number", data.cost_center_number);
frm.set_value("cost_center_name", data.cost_center_name);
frm.set_value("cost_center_number", data.cost_center_number);
}
d.hide();
}

2
erpnext/accounts/doctype/payment_term/payment_term.js
View File

@ -14,7 +14,7 @@ frappe.ui.form.on('Payment Term', {
if (frm.doc.discount) {
let description = __("{0}% of total invoice value will be given as discount.", [frm.doc.discount]);
if (frm.doc.discount_type == 'Amount') {
description = __("{0} will be given as discount.", [fmt_money(frm.doc.discount)]);
description = __("{0} will be given as discount.", [frm.doc.discount]);
}
frm.set_df_property("discount", "description", description);
}

4
erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.js
View File

@ -1,8 +1,6 @@
// Copyright (c) 2017, Frappe Technologies Pvt. Ltd. and contributors
// For license information, please see license.txt
/* global frappe, refresh_field */
frappe.ui.form.on("Supplier Scorecard", {
setup: function(frm) {
if (frm.doc.indicator_color !== "") {
@ -79,7 +77,7 @@ var loadAllStandings = function(frm) {
callback: function(r) {
for (var j = 0; j < frm.doc.standings.length; j++)
{
if(!frm.doc.standings[j].hasOwnProperty("standing_name")) {
if(!Object.prototype.hasOwnProperty.call(frm.doc.standings[j], "standing_name")) {
frm.get_field("standings").grid.grid_rows[j].remove();
}
}

3
erpnext/buying/doctype/supplier_scorecard/supplier_scorecard_list.js
View File

@ -1,7 +1,6 @@
// Copyright (c) 2017, Frappe Technologies Pvt. Ltd. and contributors
// For license information, please see license.txt
/* global frappe, __ */
frappe.listview_settings["Supplier Scorecard"] = {
add_fields: ["indicator_color", "status"],
@ -14,4 +13,4 @@ frappe.listview_settings["Supplier Scorecard"] = {
}
},
};
}

2
erpnext/buying/doctype/supplier_scorecard_criteria/supplier_scorecard_criteria.js
View File

@ -1,8 +1,6 @@
// Copyright (c) 2017, Frappe Technologies Pvt. Ltd. and contributors
// For license information, please see license.txt
/* global frappe */
frappe.ui.form.on("Supplier Scorecard Criteria", {
refresh: function() {}
});

2
erpnext/public/js/controllers/accounts.js
View File

@ -208,7 +208,7 @@ erpnext.accounts.taxes = {
erpnext.accounts.payment_triggers = {
setup: function(doctype) {
frappe.form.ui.on(doctype, {
frappe.ui.form.on(doctype, {
allocate_advances_automatically(frm) {
frm.trigger('fetch_advances');
},

6
erpnext/public/js/utils.js
View File

@ -637,7 +637,7 @@ erpnext.utils.update_child_items = function(opts) {
})
}
new frappe.ui.Dialog({
let dialog = new frappe.ui.Dialog({
title: __("Update Items"),
size: "extra-large",
fields: [
@ -674,7 +674,9 @@ erpnext.utils.update_child_items = function(opts) {
refresh_field("items");
},
primary_action_label: __('Update')
}).show();
})
dialog.show();
}
erpnext.utils.map_current_doc = function(opts) {

2
erpnext/public/js/utils/serial_no_batch_selector.js
View File

@ -382,7 +382,7 @@ erpnext.SerialBatchPackageSelector = class SerialNoBatchBundleUpdate {
edit_full_form() {
let bundle_id = this.item.serial_and_batch_bundle
if (!bundle_id) {
_new = frappe.model.get_new_doc(
let _new = frappe.model.get_new_doc(
"Serial and Batch Bundle", null, null, true
);

2
erpnext/stock/dashboard/item_dashboard.js
View File

@ -129,8 +129,6 @@ erpnext.stock.ItemDashboard = class ItemDashboard {
context = this.get_item_dashboard_data(data, this.max_count, true);
}
this.max_count = this.max_count;
// show more button
if (data && data.length === (this.page_length + 1)) {
this.content.find('.more').removeClass('hidden');

6
erpnext/stock/doctype/delivery_note/delivery_note_list.js
View File

@ -24,7 +24,7 @@ frappe.listview_settings['Delivery Note'] = {
if (!doc.docstatus) {
frappe.throw(__("Cannot create a Delivery Trip from Draft documents."));
}
};
}
frappe.new_doc("Delivery Trip")
.then(() => {
@ -51,7 +51,7 @@ frappe.listview_settings['Delivery Note'] = {
}
});
})
};
}
};
// doclist.page.add_actions_menu_item(__('Create Delivery Trip'), action, false);
@ -66,4 +66,4 @@ frappe.listview_settings['Delivery Note'] = {
erpnext.bulk_transaction_processing.create(doclist, "Delivery Note", "Packing Slip");
});
}
};
}