Ankush Menat
98468fab18
fix: ignore circular dependencies on barcode scan
2022-03-28 12:07:00 +05:30
Ankush Menat
806f420ddd
fix: revert global flag added for erasing barcode
...
This looked like a hack and doesn't even work anyway! how can row level
barcode-item relation be maitnained on entire form?
2022-03-28 12:07:00 +05:30
Ankush Menat
17a2ceb5d1
style: prettier js
2022-03-28 12:07:00 +05:30
Ankush Menat
9f0e7949aa
fix: clean up if item is not found
2022-03-28 12:07:00 +05:30
Ankush Menat
32e44f5121
fix: correctly capture first serial no
2022-03-28 12:07:00 +05:30
Ankush Menat
b3c604d679
refactor: dont hardcode child table name
2022-03-28 12:07:00 +05:30
Ankush Menat
3a8656b3c8
refactor: split data update responsibilty to multiple functions
...
Apply "single responsibilty principle"
2022-03-28 12:07:00 +05:30
Ankush Menat
c34847e801
refactor: dont hardcode child table "items"
2022-03-28 12:07:00 +05:30
Ankush Menat
893139f963
refactor: dont hardcode "scan_barcode" field
2022-03-28 12:07:00 +05:30
Ankush Menat
bd06ffab00
refactor: store scannned field as attr
2022-03-28 12:07:00 +05:30
Ankush Menat
2d15413c9e
refactor: transaction.js -> barcode_scanner.js
2022-03-28 12:07:00 +05:30
Ankush Menat
18abb28744
fix(barcode_scan): dont add duplicate serial nos
2022-03-28 12:07:00 +05:30
Ankush Menat
b06123bc65
fix: trigger table_add
on new row
2022-03-28 12:07:00 +05:30
Ankush Menat
a270f12855
fix(UX): reduce duration of barcode scan toasts
...
default is 7 which is bit too much when you're scanning lots of items,
switched to 5 sec delay
2022-03-28 12:07:00 +05:30
Ankush Menat
69ae2661d2
fix: update picked qty on cancellation
2022-03-28 10:43:32 +05:30
Ankush Menat
e401ad3f90
refactor: replace dead duplicate code
2022-03-26 19:33:00 +05:30
Ankush Menat
9daea6fa6c
perf: slimmer and faster before_tests
2022-03-26 19:33:00 +05:30
Saqib Ansari
8e7c214e9e
Merge branch 'develop' into fix-minor-custom-cash-flow
2022-03-26 11:48:40 +05:30
Deepesh Garg
2e9648538e
fix: Check for onload property
...
(cherry picked from commit 71402b43a776d4af98912223c8299c4fd8bfbbfe)
2022-03-25 16:23:44 +00:00
Rucha Mahabal
ffec9516fa
fix: do not update status to Paid if sanctioned amount is 0
2022-03-25 21:41:48 +05:30
Rucha Mahabal
2d915782cb
chore: sort imports
2022-03-25 21:41:48 +05:30
Rucha Mahabal
edf0c0030e
test: expense claim against fully and partially paid advances
2022-03-25 21:41:48 +05:30
Rucha Mahabal
0461223627
fix: Expense Claim conditions for Paid status
...
- status doesn't change to Paid if the entire required amount is already covered via linked advances
- status doesn't change to Paid if the claim is partially paid via advances
- patch to update such uncancelled claims to Paid
2022-03-25 21:41:48 +05:30
Ankush Menat
0534cf6c9c
fix: show subassembly table always ( #30422 )
...
[skip ci]
2022-03-25 19:03:33 +05:30
Saqib Ansari
80c7d7064b
Merge branch 'develop' into fix-minor-custom-cash-flow
2022-03-25 17:16:42 +05:30
Saqib Ansari
5450542fdb
fix: unsupported operand type(s) for +=: 'int' and 'NoneType'
2022-03-25 16:44:37 +05:30
Wolfram Schmidt
85b0d5fc77
fix: translations ( #30387 )
...
fixed and added translation
2022-03-25 16:22:23 +05:30
Ankush Menat
f06ef17b5d
fix: copy has_batch_no and has_serial_no while duplicating
2022-03-25 16:18:58 +05:30
Ankush Menat
f4b39b87e3
fix(UX): use autocomplete for variant fields
2022-03-25 16:18:58 +05:30
Saqib Ansari
33863cd6ab
Merge pull request #30324 from nextchamp-saqib/fix-pos-issues-again
...
fix: multiple pos issues
2022-03-25 15:34:54 +05:30
Deepesh Garg
a9d992ac9f
Merge pull request #30338 from deepeshgarg007/bank_transaction_currency_symbol_fixes
...
fix: Currency symbol in bank transactions
2022-03-25 14:39:01 +05:30
Deepesh Garg
97e102ceef
fix: Condition
...
(cherry picked from commit 2e0e6ca6b177043f673c05472ac3069f060d1563)
2022-03-25 07:30:41 +00:00
Deepesh Garg
a83a0a03b1
fix: Revert rate calculation
...
(cherry picked from commit 6937a498e71cffc56cad65141f561b4c8785d185)
2022-03-25 07:30:40 +00:00
Deepesh Garg
54cdff7947
fix: Add back calculation for discount
...
(cherry picked from commit 067564bd260437290b7cb190fb1cdc02eb658d0a)
2022-03-25 07:30:40 +00:00
Deepesh Garg
174a6ec398
fix: Rate change issue on save and mapping from other doc
...
(cherry picked from commit 13fcda57767c456dfca4c064c41ca4f80a1898b2)
2022-03-25 07:30:40 +00:00
Shadrak Gurupnor
c4854bb1b1
fix: failing broken patches ( #30409 )
...
* fix: failing broken patches
* refactor: simpler conditions
[skip ci]
2022-03-25 12:49:37 +05:30
Saqib Ansari
9a0f5bff65
Merge branch 'develop' into fix-pos-issues-again
2022-03-25 10:52:08 +05:30
Saqib Ansari
16253a2f72
fix: set is_return & return_against in POS Invoice Reference table
2022-03-25 10:51:30 +05:30
Ankush Menat
788d492757
test: basic item and wh capacity dashboard tests
2022-03-25 10:51:19 +05:30
Ankush Menat
10d5fb8cd1
test: check printviews for all docs
2022-03-25 10:51:19 +05:30
Saqib Ansari
1b556d1c53
fix: test cases
2022-03-24 17:59:34 +05:30
Ankush Menat
d4ee31dc8f
fix: consider all existing PO items
...
When this is sent from API/client side doesn't send temporary_name it
can be flaky. Hence, use all available names for validation.
2022-03-24 17:58:22 +05:30
Saqib Ansari
cb4873c019
fix: sider issues
2022-03-24 17:56:27 +05:30
Saqib Ansari
cf51a0a1b8
fix(pos): cannot close the pos if sr. no. is sold & returned
2022-03-24 16:22:36 +05:30
Ankush Menat
5b1d6055e6
fix: subassembly items linked to temporary name
...
Production Plan tables for po_items and sub_assembly_items are prepared
client side so both dont exist at time of first save or modifying and
hence any "links" created are invalid. This change retains temporary
name so it can be relinked server side after naming is performed.
Co-Authored-By: Marica <maricadsouza221197@gmail.com>
2022-03-24 15:00:05 +05:30
Ankush Menat
3d43c437ad
fix: only validate qty for main non-subassy items
2022-03-24 15:00:05 +05:30
Marica
d24458ab77
fix: (ux) Add is_group=0 filter on website warehouse ( #30396 )
...
- It does not support group warehouses right now and it is misleading
2022-03-24 12:56:57 +05:30
Saqib Ansari
4aabe97565
Merge branch 'develop' into fix-pos-issues-again
2022-03-24 11:18:13 +05:30
Deepesh Garg
07c7ebfd99
Merge branch 'develop' into gst_state_number_unsetting
2022-03-23 22:04:13 +05:30
Ankush Menat
c9dcf31cf7
test: ensure super()setUpClass is called
2022-03-23 19:46:50 +05:30