Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(barcode_scan): dont add duplicate serial nos

Browse Source
This commit is contained in:
Ankush Menat 2022-03-27 18:43:36 +05:30 committed by Ankush Menat
parent b06123bc65
commit 18abb28744
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
erpnext/public/js/controllers/transaction.js
View File

@ -390,6 +390,11 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
this.frm.script_manager.trigger("items_add", row_to_modify.doctype, row_to_modify.name);
}
if (this.is_duplicate_serial_no(row_to_modify, data.serial_no)) {
scan_barcode_field.set_value("");
return;
};
this.show_scan_message(row_to_modify.idx, row_to_modify.item_code);
this.set_scanned_values(row_to_modify, data, scan_barcode_field);
}
@ -439,6 +444,18 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
return existing_batch_row || null;
}
is_duplicate_serial_no(row, serial_no) {
const is_duplicate = !!serial_no && !!row.serial_no && row.serial_no.includes(serial_no);
if (is_duplicate) {
frappe.show_alert({
message: __('Serial No {0} is already added', [serial_no]),
indicator: 'orange'
}, 5);
}
return is_duplicate;
}
show_scan_message (idx, exist = null) {
// show new row or qty increase toast
if (exist) {