Ankush Menat
c64d5028b4
fix: deduplicate after finishing the repost ( #28803 )
...
Not really a bug but avoids potential of prematurely skipping something
if failure occurs and failure isn't resolved.
2021-12-09 13:45:44 +05:30
Michael Köller
f043f59324
fix: wrong german translation of abbreviation PAN
...
Wrong german translation of abbreviation: PAN
2021-12-09 11:31:25 +05:30
Deepesh Garg
121f8ae865
Merge pull request #28776 from rtdany10/ksa-vat-updates
...
feat(Regional): KSA E-Invoing optimizations and POS support
2021-12-08 22:32:24 +05:30
Ganga Manoj
51c707a0ce
Merge branch 'develop' into fix-adjust-asset-value
2021-12-08 19:20:23 +05:30
Ganga Manoj
539cba1b15
Merge branch 'develop' into fix-clear-depr-schedule
2021-12-08 19:19:33 +05:30
Ankush Menat
96a019ec49
test: add multi-batch negative qty test
2021-12-08 15:52:40 +05:30
Ankush Menat
f0152d03a4
test: simplfy test and expect specific exception
2021-12-08 15:52:40 +05:30
Ankush Menat
9c90b7a40d
refactor: remove redundant batch qty validation
...
This check was only checking total sum, which is problamatic when making
backdated entries that can cause intermediate values to go negative
while overall values stay positive.
2021-12-08 15:52:40 +05:30
Ankush Menat
5eba57528c
fix: check future negative stock for batches
...
batch's ledger is only maintained in form of `actual_qty` on batch's
SLEs. To validate if batch has any negative qty in future, cumulative
total of `actual_qty` is required to ensure it never goes negative.
2021-12-08 15:52:40 +05:30
18alantom
1cbeba5f1d
test: check execution of illegal stock entry seq
2021-12-08 15:52:40 +05:30
aaronmenezes
90b98440e2
fix: Maintenence Visit -Purpose (item ) tables is not visible on submitted or saved entries ( #28792 )
2021-12-08 14:48:19 +05:30
Deepesh Garg
d5380dd716
fix: Error on Invoice generation
...
(cherry picked from commit 82255293c4eb8a9f586db083d19d63c1ea435fb9)
2021-12-08 08:42:29 +00:00
Dany Robert
4a316550f4
chore: POS invoice format changes
2021-12-08 07:25:41 +00:00
Deepesh Garg
948b67b744
Merge branch 'develop' into ksa-vat-updates
2021-12-08 09:38:11 +05:30
Dany Robert
3e97492da4
fix: replace frappe.get_all
2021-12-08 08:03:30 +05:30
Dany Robert
5b20746311
chore: switch to ORM method
2021-12-08 07:53:45 +05:30
Dany Robert
ca85094728
chore: switch to frappe.db.set_value
2021-12-08 07:52:06 +05:30
Rucha Mahabal
dcbf0c9eca
fix: tests and sider issues
2021-12-07 23:40:10 +05:30
Deepesh Garg
cb21dff882
fix: Error on creating invoice
...
(cherry picked from commit e11515a3561eac6d33d21190cac2db112ae301fb)
2021-12-07 16:51:02 +00:00
Dany Robert
15373f1b2d
fix: intendation error
2021-12-07 18:34:34 +05:30
Dany Robert
45fce5a64b
chore: linters
2021-12-07 18:29:16 +05:30
Dany Robert
2df641eb54
feat(Regional): rename qr field and disable print formats
2021-12-07 18:13:35 +05:30
Dany Robert
9c68d8e35c
Merge branch 'frappe:develop' into ksa-vat-updates
2021-12-07 18:10:26 +05:30
Dany Robert
a0aeacee8e
fix: reload doc
2021-12-07 12:39:39 +00:00
Dany Robert
bb3119cd1f
feat(Regional): enable KSA print formats on setup
2021-12-07 11:05:41 +00:00
Dany Robert
293d981af9
feat(Regional): POS Invoice format for KSA
2021-12-07 11:03:22 +00:00
Dany Robert
2256155e80
feat(Regional): patch to disable ksa print formats for other countries
2021-12-07 11:02:28 +00:00
Dany Robert
09f178ceee
fix: disable ksa vat invoice by default
2021-12-07 11:01:37 +00:00
Dany Robert
c5c47e9fad
feat: generate QR Code for POS transactions
2021-12-07 11:01:02 +00:00
Ankush Menat
6efbbb1058
fix: ignore mandatory fields while creating WO from SO ( #28772 )
...
If fields are made mandatory from customizations the WO creation simply
fails.
2021-12-07 16:26:14 +05:30
Rucha Mahabal
4686527928
Merge branch 'develop' into exit-interview
2021-12-07 16:23:31 +05:30
Rucha Mahabal
c305ff911f
test: Employee Exits Report
2021-12-07 16:22:17 +05:30
Deepesh Garg
3e1591c145
Merge pull request #28731 from deepeshgarg007/better_deferred_revenue_error_logging
...
fix: Better Error logging for deferred revenue/expense booking
2021-12-07 15:42:05 +05:30
Dany Robert
b3bd14fcfa
Merge branch 'frappe:develop' into ksa-vat-updates
2021-12-07 15:33:27 +05:30
Dany Robert
811e51fb50
fix: reload SI meta before checking
2021-12-07 15:21:51 +05:30
Ankush Menat
ca230e4267
test: index test should pass without calling function #28771
...
test: index test should pass without calling function
[skip ci]
2021-12-07 15:11:31 +05:30
Rucha Mahabal
ef38b127ae
chore: fix report column widths
2021-12-07 15:02:00 +05:30
Rucha Mahabal
8db21e065c
test: Exit Interview
2021-12-07 14:55:17 +05:30
Dany Robert
848b641d7b
fix: rename KSA QR field to match localisation
2021-12-07 14:51:05 +05:30
Rucha Mahabal
0a937dc050
fix: show Exit Questionnaire button only to the users with write access
...
- fix linter issues
2021-12-07 13:04:23 +05:30
Dany Robert
d06c4b50cd
feat: create QR field in POS Invoice
2021-12-07 12:29:59 +05:30
Dany Robert
f0fee5672f
chore: change QR field label
2021-12-07 12:18:32 +05:30
Dany Robert
6a6d6f7f8b
fix: localize QR fieldname
2021-12-07 12:17:45 +05:30
Dany Robert
ebd4179295
fix: get doctype from doc instead of hardcoding SI
2021-12-07 12:15:58 +05:30
Dany Robert
276bf73974
feat: create QR Code field if not existing
2021-12-07 12:11:43 +05:30
Deepesh Garg
d106d59c3f
fix: TDS Monthly payable report
2021-12-06 20:36:48 +05:30
Saqib Ansari
2f7d8ac29e
fix: indentation
2021-12-06 19:19:34 +05:30
Saqib Ansari
3446f7545f
fix: remove 'ongoing' status from issue summary report
2021-12-06 19:17:38 +05:30
Saqib Ansari
91aa78707c
fix: remove missed 'ongoing' references
2021-12-06 19:13:31 +05:30
Saqib Ansari
476e81a631
fix: time to respond & resolve indicators
2021-12-06 18:55:30 +05:30
Saqib Ansari
1a76b3801a
fix: test
2021-12-06 17:06:20 +05:30
Saqib Ansari
10b87e081c
fix: sider issues
2021-12-06 15:38:19 +05:30
Saqib Ansari
32c81818f6
fix: transalations
2021-12-06 15:38:01 +05:30
Deepesh Garg
3dabac15ed
fix: Ageing in AR/AP report for advances
2021-12-06 15:05:20 +05:30
Saqib
8e5b793a0a
Merge branch 'develop' into fix-sla
2021-12-06 14:48:09 +05:30
Saqib Ansari
812572d250
feat: record assignment on first response failure
2021-12-06 14:46:51 +05:30
Saqib Ansari
c1d8877a83
refactor: handle special cases on communication creation
2021-12-06 14:34:59 +05:30
Ankush Menat
ef53eb7fcd
Merge pull request #28745 from noahjacob/maint_batch_map
...
refactor: map serial from schedule if only one
2021-12-06 14:34:06 +05:30
Anupam Kumar
3928a402d4
feat: CRM Settings ( #27788 )
...
* feat: crm settings
* feat: CRM Settings
* feat: lead and opprtunity section
* feat: added CRM Settings in ERPNext Settings workspace
* fix: review chnages
* added patch
* fix: linter issues
* fix: linter issues
* fix: linter issues
* fix: removed crm settings from selling module
* fix: raw query to frappe.qb
* fix: removed hardcoded value
* fix: linter issue
* fix: simplify CRM Settings migration patch
Co-authored-by: Anupam Kumar <anupam@Anupams-MacBook-Air.local>
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
2021-12-06 13:52:00 +05:30
Noah Jacob
eb522a3746
refactor: map serial from schedule if only one
2021-12-06 13:43:02 +05:30
Saqib Ansari
f9408d170a
patch: split 'ongoing' sla status
2021-12-06 12:38:25 +05:30
Deepesh Garg
c56a450474
Merge pull request #28656 from nemesis189/taxjar-nexus-display-condition
...
fix: Taxjar Nexus list visible only if child table is visible
2021-12-06 11:44:11 +05:30
Saqib
b1ba98c129
feat: Make Depreciation Entry posting more flexible ( #28421 )
2021-12-06 11:43:09 +05:30
Saqib Ansari
56df646067
fix(test): test_depr_entry_posting_with_income_account
2021-12-06 11:19:58 +05:30
Ankush Menat
a8375239eb
test: set customer group and territory defaults
2021-12-06 11:07:24 +05:30
Ankush Menat
bdf7b8d379
fix: patch to remove default item group and territory
2021-12-06 11:07:24 +05:30
Ankush Menat
105b6d498c
fix: remove bad defaults from selling settings
...
"All cusotmer groups" and "All territories" are pointless defaults, not
sure why these are made default. They don't help you track anything.
"All" might as well be `Null`.
Even the filters for customer_group suggest it shouldn't be group then
having the root as default makes no sense.
2021-12-06 11:07:24 +05:30
Rucha Mahabal
3230741cde
fix: email summary
2021-12-06 10:08:51 +05:30
Rucha Mahabal
b69e0d2c63
feat: default Notification - a day before Exit Interview
2021-12-05 22:28:22 +05:30
Rucha Mahabal
1c09439d03
chore: update HR workspace
2021-12-05 22:06:19 +05:30
Rucha Mahabal
3437f568be
feat: Employee Exits report
2021-12-05 21:55:13 +05:30
Rucha Mahabal
d67536cc8d
feat: update Exit Interview date in employee master on submission
2021-12-05 19:55:25 +05:30
Rucha Mahabal
e30187f246
feat: bulk questionnaire sending
2021-12-05 19:32:33 +05:30
Rucha Mahabal
09fdfed163
fix: make Exit Interview submittable
2021-12-05 18:28:23 +05:30
Rucha Mahabal
1347187a30
feat: track status and final decision (Retained/Exit Confirmed)
2021-12-05 17:20:39 +05:30
Rucha Mahabal
235b707417
feat: add default Exit Questionnaire email template
2021-12-05 17:06:29 +05:30
Rucha Mahabal
7412accf6d
feat: sending Exit Questionnaire
2021-12-05 17:02:19 +05:30
Rucha Mahabal
36a2d8ee0d
feat: Exit Interview
2021-12-05 14:42:27 +05:30
Rucha Mahabal
0ef42d1000
fix(patch): create only component type field instead of running the whole setup ( #28734 )
2021-12-05 12:44:20 +05:30
Deepesh Garg
3c64e201cc
fix: Log error before throwing exception
2021-12-04 20:05:37 +05:30
Deepesh Garg
0ba4fcee2a
fix: Commit joural entries
2021-12-04 19:25:44 +05:30
Deepesh Garg
67a001d876
fix: Better Error logging fordeferred revenue/expense booking
2021-12-04 19:19:03 +05:30
rohitwaghchaure
fc4e6a2bed
Merge pull request #28710 from noahjacob/calc_outgoing_stock_entry
...
fix: incorrect outgoing rates when material_consumption enabled
2021-12-04 12:34:33 +05:30
Ankush Menat
ba5a7ffd60
fix: weird item sorting by idx
2021-12-03 19:08:06 +05:30
Ankush Menat
5caf411be3
fix: remove autocommit from item rename
2021-12-03 18:47:53 +05:30
Ankush Menat
72dbc3d6b8
fix!: dont allow renaming warehouse primary key
2021-12-03 18:47:53 +05:30
Noah Jacob
35346de162
test: added tests for manufacture stock entry when material_consumption is enabled
2021-12-03 17:21:49 +05:30
Saqib Ansari
defa01edac
fix: undo removing of resolution_time fields
2021-12-03 16:22:10 +05:30
Saqib
7511a9ed31
fix(ksa): qrcode for invoices with special chars ( #28715 )
2021-12-03 16:13:44 +05:30
Deepesh Garg
a8f283bb20
Merge pull request #28708 from deepeshgarg007/ksa_qr_invoice_total
...
fix: Invoice amount in KSA E Invoice QR Code
2021-12-03 15:18:15 +05:30
Noah Jacob
7f3e6d149a
fix: incorrect outgoing rates when material_consumption enabled
2021-12-03 15:11:18 +05:30
Ankush Menat
cef84c25a7
refactor: simplify the way SLEs are submitted
2021-12-03 14:51:25 +05:30
Ankush Menat
97060c45e9
refactor: replace misleading variable name
2021-12-03 14:51:25 +05:30
Deepesh Garg
f2ffddf059
fix: Invocie amount in KSA E Invoice QR Code
2021-12-03 14:32:52 +05:30
Deepesh Garg
c339240250
Merge pull request #28698 from frappe/mergify/bp/develop/pr-28654
...
fix: Taxes and Charges template not getting copied from Purchase Order/Receipt to Invoice (backport #28654 )
2021-12-03 14:26:43 +05:30
Saqib
7091ca6812
Merge branch 'develop' into fix-sla
2021-12-03 11:53:25 +05:30
Rucha Mahabal
0b1808e1ee
fix(Non Profit): fetch memberships for 80G certificate by from date only ( #28700 )
2021-12-03 11:46:14 +05:30
Saqib Ansari
1e550d3e46
fix: failing tests
2021-12-03 11:36:53 +05:30
Saqib
9c60c45acf
fix: Create Depreciation Schedules for existing Assets accurately ( #28675 )
2021-12-03 11:30:47 +05:30
Saqib
7314aee394
fix: qrcode image name for invoices with special chars ( #28699 )
2021-12-03 11:29:51 +05:30
