make_advance_gl_entries -> add_advance_gl_entries -> add_advance_gl_for_reference
'make_advance_gl_entries' - main method thats builds and post GL
entries for all or one specific reference based on parameters
'add_advance_gl_entries' - build GL map for all or one specific
reference. Return an array of dict.
'add_advance_gl_for_reference' - utility function to build gl
entries. returns dict.
(cherry picked from commit 5fc19dab54a2672ec131dbf97974b2bde277aa76)
with `Advance as Liability`, partial reconciliation should not post
duplicate ledger entries for same reference
(cherry picked from commit 3263f2023c0a6ceabfbdd1eeb5202843d4532b76)
add supplier group filter in purchase register (#38421)
* add supplier group field in purchase register
* Update purchase_register.js
(cherry picked from commit e2a519464b3214b0a6594498dc86bc3af15197c3)
Co-authored-by: NandhiniDevi <95607404+Nandhinidevi123@users.noreply.github.com>
fix: show item name as title instead of item group in BOM (#38478)
Item fields in BOM used to show Item Group when Items were set to show title as link fields. Now they show Item Name instead
(cherry picked from commit 3a66aefd2c6aedc1b7b6017c174261c1ed4c2907)
Co-authored-by: Gughan Ravikumar <gughanrk@gmail.com>
* fix(ux): make `basic_rate` field read-only based on purpose
(cherry picked from commit abc7d3002467946984be5b41d79024da92047dd3)
* fix(ux): make PR `rate` field read-only having PO ref
(cherry picked from commit ae294ee4702fa8e0367c07c881d632811beb67ae)
* fix(ux): make PI `rate` field read-only having PR ref
(cherry picked from commit 3d4156cc7d90522f37f4c91e4ccf4145412109a9)
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
fix: use `docstatus` instead of `status`
(cherry picked from commit 1423b38d50faa8b2f44cab9626a837037e1d0570)
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
* feat: add field `Action on Purchase Order Submission`
(cherry picked from commit 628ea42b63217fcf64c9803fdfdad09c610b00c3)
# Conflicts:
# erpnext/buying/doctype/buying_settings/buying_settings.json
* feat: auto create SCO on PO submission
(cherry picked from commit 9ec6f1e1d63ccb8087cb3f95c6a100b02d22ba79)
# Conflicts:
# erpnext/buying/doctype/buying_settings/buying_settings.json
* feat: add field `Action on Subcontracting Receipt Submission`
(cherry picked from commit 762906f24023af3f0fdba70c5dbf61951f45dd68)
# Conflicts:
# erpnext/buying/doctype/buying_settings/buying_settings.json
* chore: notify user on SCO creation
(cherry picked from commit 745e3bfb733bdbce034b9b1fb3cd83a502a423a7)
* feat: add field `Purchase Order Item` in SCO Service Item
(cherry picked from commit 45d5cff47d7fc53fcf710afac281907ba9ab9e00)
* fix: hold PO item ref in SCO Service Item
(cherry picked from commit 7e4dd33ab0da2800fdb4aeb89ef9d183bff19d4d)
* feat: add field `Purchase Order Item` in SCO Item
(cherry picked from commit a2ede7d6d5241665d996447a1c9e2d1447190066)
* fix: maintain PO and PO Item ref in SCR Item
(cherry picked from commit e1cea2578151ee0f43e1809a7f99d2e90bf774a6)
* feat: auto create PR on SCR submission
(cherry picked from commit 040cc8d22f700a1823425d1534b91d50289d2489)
* feat: add `Purchase Order` link in SCR connections
(cherry picked from commit ca8a5b45ba58b62cd661dae508af9b0e26ff7973)
* feat: add `Subcontracting Receipt` link in PO connections
(cherry picked from commit 98cba5ed30ed2c8f5191d7cfaac54b16997cf09e)
* fix: dont show `View` button on cancelled SCR
(cherry picked from commit dd80d3b9b94c970d5070e1a5fac03cf9f1fbc455)
* fix: use checkbox instead of select field
(cherry picked from commit d366a91d9eae52175cd7f10f8a77b96dc09bfd00)
# Conflicts:
# erpnext/buying/doctype/buying_settings/buying_settings.json
* feat: Subcontracting Receipt ref in Purchase Receipt
(cherry picked from commit d891bd7fac1ab9e46a94959dedcc45e18ac69de5)
* feat: SCR Item ref in PR Item
(cherry picked from commit 37b3ac795284c0ee9593753ececcfe4871e538a4)
* feat: provision to create PR from SCR
(cherry picked from commit 8052103197112d2e1abe7ac35a831267ad9549b7)
* chore: PR ref in SCR connections
(cherry picked from commit 096a2c8cd0afafb28e916a5c9e92ef1eb041e0a3)
* fix: map warehouses in return SCR
(cherry picked from commit 874766a82f1b31a55b8d5c9c998896748ad49cdf)
* fix(ux): hide `Create Purchase Receipt` button for Subcontract Return
(cherry picked from commit 7145b040f12a62be9f0ac945c69ac221debd7c03)
* chore: `linter`
(cherry picked from commit 857f2b5a014b4d14d21bca793ea569f8bdc1c398)
* test: auto create SCO on PO submit
(cherry picked from commit 68585f6f2b05e0b8dc3429741950ef31bbc42e17)
* test: auto create PR on SCR submit
(cherry picked from commit 7b0cd03f88a7052460438ee70390799fae5c336c)
* fix(test): `test_auto_create_purchase_receipt`
(cherry picked from commit 3da0aa6a0b21c775e5356ae7d359f7378f190d92)
* chore: `conflicts`
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
feat: shift depreciation for assets (#38327)
* feat: shift depreciation for assets
* chore: create new asset depr schedule on shift change
* refactor: move create_depr_schedule to after_insert
* fix: args in get_depreciation_amount test
* refactor: rename shift adjustment to shift allocation
* chore: asset shift factor doctype and auto allocate shift diff
* chore: use check instead of depr type, and add tests
* chore: make linter happy
* chore: give permissions to accounts users
(cherry picked from commit fe5fc5bd3abfff57f85f62eac18f3ffc242baa4b)
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
* refactor: use arrow function
(cherry picked from commit 1763824e5f7ccaefb83aea84db47c92f9e4c9417)
* refactor: use DocType `Fetch From` instead of `frm.add_fetch`
(cherry picked from commit 01044ca8e95ec4e84e63fcfe4928ca111cf3a75b)
* refactor: use `frm.set_query` to add filters
(cherry picked from commit 640dfab827f2e83b9c3ae7ff839c6f94b63b71b2)
* refactor: don't use `cur_frm`
(cherry picked from commit 9fadf5f42678736567160bb2b06619383146d4ca)
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
fix(regional): use net figures for sales calc (#38260)
(cherry picked from commit 663bb8726c25005ab83a6ca4c82814b82a98a1e2)
Co-authored-by: Dany Robert <danyrt@wahni.com>
fix: no fstring in translation (#38381)
(cherry picked from commit 8f00481c5f7742b120a232622fae7b3f7e3d2e86)
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
fix: serial no status (#38391)
(cherry picked from commit 592fc81260779ec42b35c88c6b8de19a598911d0)
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
chore: fix flaky test case (#38369)
(cherry picked from commit ad3634be7c2607ab5c9c831ae01e5ddff7c9ba8b)
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
fix: Negative Qty and Rates in SO/PO (#38252)
* fix: Don't allow negative qty in SO/PO
* fix: Type casting for safe comparisons
* fix: Grammar in error message
* fix: Negative rates should be allowed via Update Items in SO/PO
* fix: Use `non_negative` property in docfield & emove code validation
(cherry picked from commit b9f5a1c85dc29acc22e704d866178a98f3035c1d)
Co-authored-by: Marica <maricadsouza221197@gmail.com>