Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: task should explicitly call commit and rollback if error

Browse Source
This commit is contained in:
tundebabzy 2018-03-01 17:06:39 +01:00
parent 36c18c913e
commit ca5cf35a99
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/accounts/doctype/subscriptions/subscriptions.py
View File

@ -424,8 +424,15 @@ def process(data):
Checks a `Subscription` and updates it status as necessary Checks a `Subscription` and updates it status as necessary
""" """
if data: if data:
try:
subscription = frappe.get_doc('Subscriptions', data['name']) subscription = frappe.get_doc('Subscriptions', data['name'])
subscription.process() subscription.process()
frappe.db.commit()
except frappe.ValidationError:
frappe.db.rollback()
frappe.db.begin()
frappe.log_error(frappe.get_traceback())
frappe.db.commit()
@frappe.whitelist() @frappe.whitelist()