From ca5cf35a99bad1fd93a51f687e06ae0c04ff7974 Mon Sep 17 00:00:00 2001 From: tundebabzy Date: Thu, 1 Mar 2018 17:06:39 +0100 Subject: [PATCH] fix: task should explicitly call `commit` and rollback if error --- .../accounts/doctype/subscriptions/subscriptions.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/doctype/subscriptions/subscriptions.py b/erpnext/accounts/doctype/subscriptions/subscriptions.py index 8f5c4f4e47..ac0310ae10 100644 --- a/erpnext/accounts/doctype/subscriptions/subscriptions.py +++ b/erpnext/accounts/doctype/subscriptions/subscriptions.py @@ -424,8 +424,15 @@ def process(data): Checks a `Subscription` and updates it status as necessary """ if data: - subscription = frappe.get_doc('Subscriptions', data['name']) - subscription.process() + try: + subscription = frappe.get_doc('Subscriptions', data['name']) + subscription.process() + frappe.db.commit() + except frappe.ValidationError: + frappe.db.rollback() + frappe.db.begin() + frappe.log_error(frappe.get_traceback()) + frappe.db.commit() @frappe.whitelist()