Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: codacy

Browse Source
This commit is contained in:
Himanshu Warekar 2019-06-02 20:47:23 +05:30
parent 4a7a380f0c
commit 9f458e3413
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/quality_management/doctype/quality_action/quality_action.js
View File

@ -16,11 +16,11 @@ frappe.ui.form.on('Quality Action', {
callback: function(data){ callback: function(data){
frm.fields_dict.resolutions.grid.remove_all(); frm.fields_dict.resolutions.grid.remove_all();
let objectives = []; let objectives = [];
let i = 0;
if(frm.doc.document_type === "Quality Review"){ if(frm.doc.document_type === "Quality Review"){
for(i in data.message.reviews) objectives.push(data.message.reviews[i].review); for(let i in data.message.reviews) objectives.push(data.message.reviews[i].review);
} else { } else {
for(i in data.message.parameters) objectives.push(data.message.parameters[i].feedback); for(let j in data.message.parameters) objectives.push(data.message.parameters[j].feedback);
} }
for (var objective in objectives){ for (var objective in objectives){
frm.add_child("resolutions"); frm.add_child("resolutions");