From 9f458e3413e5ef29b2f18bd588c86d1096b29912 Mon Sep 17 00:00:00 2001 From: Himanshu Warekar Date: Sun, 2 Jun 2019 20:47:23 +0530 Subject: [PATCH] fix: codacy --- .../doctype/quality_action/quality_action.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/quality_management/doctype/quality_action/quality_action.js b/erpnext/quality_management/doctype/quality_action/quality_action.js index af051d971e..70782477f0 100644 --- a/erpnext/quality_management/doctype/quality_action/quality_action.js +++ b/erpnext/quality_management/doctype/quality_action/quality_action.js @@ -16,11 +16,11 @@ frappe.ui.form.on('Quality Action', { callback: function(data){ frm.fields_dict.resolutions.grid.remove_all(); let objectives = []; - let i = 0; + if(frm.doc.document_type === "Quality Review"){ - for(i in data.message.reviews) objectives.push(data.message.reviews[i].review); + for(let i in data.message.reviews) objectives.push(data.message.reviews[i].review); } else { - for(i in data.message.parameters) objectives.push(data.message.parameters[i].feedback); + for(let j in data.message.parameters) objectives.push(data.message.parameters[j].feedback); } for (var objective in objectives){ frm.add_child("resolutions");