Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent creation of more than 500 item variants (#14790)

Browse Source
This commit is contained in:
Ameya Shenoy 2018-07-03 10:48:59 +05:30 committed by Nabin Hait
parent aa62a62bb0
commit 935f4a474b
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/controllers/item_variant.py
View File

@ -176,6 +176,14 @@ def create_variant(item, args):
@frappe.whitelist() @frappe.whitelist()
def enqueue_multiple_variant_creation(item, args): def enqueue_multiple_variant_creation(item, args):
# There can be innumerable attribute combinations, enqueue # There can be innumerable attribute combinations, enqueue
if isinstance(args, basestring):
variants = json.loads(args)
total_variants = 1
for key in variants:
total_variants *= len(variants[key])
if total_variants >= 600:
frappe.msgprint("Please do not create more than 500 items at a time", raise_exception=1)
return
frappe.enqueue("erpnext.controllers.item_variant.create_multiple_variants", frappe.enqueue("erpnext.controllers.item_variant.create_multiple_variants",
item=item, args=args, now=frappe.flags.in_test); item=item, args=args, now=frappe.flags.in_test);