Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[fix] [minor] SO/DN required validation and get_single_value deprecated

Browse Source
This commit is contained in:
Nabin Hait 2013-08-05 12:44:10 +05:30
parent 6cd2ed88bb
commit 7895d34d41
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
accounts/doctype/purchase_invoice/purchase_invoice.py
View File

@ -252,14 +252,14 @@ class DocType(BuyingController):
self.doc.against_expense_account = ",".join(against_accounts) self.doc.against_expense_account = ",".join(against_accounts)
def po_required(self): def po_required(self):
if webnotes.conn.get_single_value("Buying Settings", "po_required") == 'Yes': if webnotes.conn.get_value("Buying Settings", None, "po_required") == 'Yes':
for d in getlist(self.doclist,'entries'): for d in getlist(self.doclist,'entries'):
if not d.purchase_order: if not d.purchase_order:
msgprint("Purchse Order No. required against item %s"%d.item_code) msgprint("Purchse Order No. required against item %s"%d.item_code)
raise Exception raise Exception
def pr_required(self): def pr_required(self):
if webnotes.conn.get_single_value("Buying Settings", "pr_required") == 'Yes': if webnotes.conn.get_value("Buying Settings", None, "pr_required") == 'Yes':
for d in getlist(self.doclist,'entries'): for d in getlist(self.doclist,'entries'):
if not d.purchase_receipt: if not d.purchase_receipt:
msgprint("Purchase Receipt No. required against item %s"%d.item_code) msgprint("Purchase Receipt No. required against item %s"%d.item_code)

4
accounts/doctype/sales_invoice/sales_invoice.py
View File

@ -430,8 +430,8 @@ class DocType(SellingController):
def so_dn_required(self): def so_dn_required(self):
"""check in manage account if sales order / delivery note required or not.""" """check in manage account if sales order / delivery note required or not."""
dic = {'Sales Order':'so_required','Delivery Note':'dn_required'} dic = {'Sales Order':'so_required','Delivery Note':'dn_required'}
for i in dic: for i in dic:
if webnotes.conn.get_single_value('Selling Settings', dic[i]) == 'Yes': if webnotes.conn.get_value('Selling Settings', None, dic[i]) == 'Yes':
for d in getlist(self.doclist,'entries'): for d in getlist(self.doclist,'entries'):
if webnotes.conn.get_value('Item', d.item_code, 'is_stock_item') == 'Yes' \ if webnotes.conn.get_value('Item', d.item_code, 'is_stock_item') == 'Yes' \
and not d.fields[i.lower().replace(' ','_')]: and not d.fields[i.lower().replace(' ','_')]:

2
stock/doctype/delivery_note/delivery_note.py
View File

@ -85,7 +85,7 @@ class DocType(SellingController):
def so_required(self): def so_required(self):
"""check in manage account if sales order required or not""" """check in manage account if sales order required or not"""
if webnotes.conn.get_single_value("Selling Settings", 'so_required') == 'Yes': if webnotes.conn.get_value("Selling Settings", None, 'so_required') == 'Yes':
for d in getlist(self.doclist,'delivery_note_details'): for d in getlist(self.doclist,'delivery_note_details'):
if not d.prevdoc_docname: if not d.prevdoc_docname:
msgprint("Sales Order No. required against item %s"%d.item_code) msgprint("Sales Order No. required against item %s"%d.item_code)

2
stock/doctype/purchase_receipt/purchase_receipt.py
View File

@ -118,7 +118,7 @@ class DocType(BuyingController):
def po_required(self): def po_required(self):
if webnotes.conn.get_single_value("Buying Settings", "po_required") == 'Yes': if webnotes.conn.get_value("Buying Settings", None, "po_required") == 'Yes':
for d in getlist(self.doclist,'purchase_receipt_details'): for d in getlist(self.doclist,'purchase_receipt_details'):
if not d.prevdoc_docname: if not d.prevdoc_docname:
msgprint("Purchse Order No. required against item %s"%d.item_code) msgprint("Purchse Order No. required against item %s"%d.item_code)