From 7895d34d4166650c15f7c3ecf838ad8d80f14e66 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Mon, 5 Aug 2013 12:44:10 +0530 Subject: [PATCH] [fix] [minor] SO/DN required validation and get_single_value deprecated --- accounts/doctype/purchase_invoice/purchase_invoice.py | 4 ++-- accounts/doctype/sales_invoice/sales_invoice.py | 4 ++-- stock/doctype/delivery_note/delivery_note.py | 2 +- stock/doctype/purchase_receipt/purchase_receipt.py | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/accounts/doctype/purchase_invoice/purchase_invoice.py b/accounts/doctype/purchase_invoice/purchase_invoice.py index 9e220fd30c..693ed844f6 100644 --- a/accounts/doctype/purchase_invoice/purchase_invoice.py +++ b/accounts/doctype/purchase_invoice/purchase_invoice.py @@ -252,14 +252,14 @@ class DocType(BuyingController): self.doc.against_expense_account = ",".join(against_accounts) def po_required(self): - if webnotes.conn.get_single_value("Buying Settings", "po_required") == 'Yes': + if webnotes.conn.get_value("Buying Settings", None, "po_required") == 'Yes': for d in getlist(self.doclist,'entries'): if not d.purchase_order: msgprint("Purchse Order No. required against item %s"%d.item_code) raise Exception def pr_required(self): - if webnotes.conn.get_single_value("Buying Settings", "pr_required") == 'Yes': + if webnotes.conn.get_value("Buying Settings", None, "pr_required") == 'Yes': for d in getlist(self.doclist,'entries'): if not d.purchase_receipt: msgprint("Purchase Receipt No. required against item %s"%d.item_code) diff --git a/accounts/doctype/sales_invoice/sales_invoice.py b/accounts/doctype/sales_invoice/sales_invoice.py index 09df5f6512..bf5e201f6b 100644 --- a/accounts/doctype/sales_invoice/sales_invoice.py +++ b/accounts/doctype/sales_invoice/sales_invoice.py @@ -430,8 +430,8 @@ class DocType(SellingController): def so_dn_required(self): """check in manage account if sales order / delivery note required or not.""" dic = {'Sales Order':'so_required','Delivery Note':'dn_required'} - for i in dic: - if webnotes.conn.get_single_value('Selling Settings', dic[i]) == 'Yes': + for i in dic: + if webnotes.conn.get_value('Selling Settings', None, dic[i]) == 'Yes': for d in getlist(self.doclist,'entries'): if webnotes.conn.get_value('Item', d.item_code, 'is_stock_item') == 'Yes' \ and not d.fields[i.lower().replace(' ','_')]: diff --git a/stock/doctype/delivery_note/delivery_note.py b/stock/doctype/delivery_note/delivery_note.py index 25a70b6c66..5df531ea10 100644 --- a/stock/doctype/delivery_note/delivery_note.py +++ b/stock/doctype/delivery_note/delivery_note.py @@ -85,7 +85,7 @@ class DocType(SellingController): def so_required(self): """check in manage account if sales order required or not""" - if webnotes.conn.get_single_value("Selling Settings", 'so_required') == 'Yes': + if webnotes.conn.get_value("Selling Settings", None, 'so_required') == 'Yes': for d in getlist(self.doclist,'delivery_note_details'): if not d.prevdoc_docname: msgprint("Sales Order No. required against item %s"%d.item_code) diff --git a/stock/doctype/purchase_receipt/purchase_receipt.py b/stock/doctype/purchase_receipt/purchase_receipt.py index 703929ce81..9daff8faaf 100644 --- a/stock/doctype/purchase_receipt/purchase_receipt.py +++ b/stock/doctype/purchase_receipt/purchase_receipt.py @@ -118,7 +118,7 @@ class DocType(BuyingController): def po_required(self): - if webnotes.conn.get_single_value("Buying Settings", "po_required") == 'Yes': + if webnotes.conn.get_value("Buying Settings", None, "po_required") == 'Yes': for d in getlist(self.doclist,'purchase_receipt_details'): if not d.prevdoc_docname: msgprint("Purchse Order No. required against item %s"%d.item_code)