[fix] [minor] SO/DN required validation and get_single_value deprecated
This commit is contained in:
parent
6cd2ed88bb
commit
7895d34d41
@ -252,14 +252,14 @@ class DocType(BuyingController):
|
||||
self.doc.against_expense_account = ",".join(against_accounts)
|
||||
|
||||
def po_required(self):
|
||||
if webnotes.conn.get_single_value("Buying Settings", "po_required") == 'Yes':
|
||||
if webnotes.conn.get_value("Buying Settings", None, "po_required") == 'Yes':
|
||||
for d in getlist(self.doclist,'entries'):
|
||||
if not d.purchase_order:
|
||||
msgprint("Purchse Order No. required against item %s"%d.item_code)
|
||||
raise Exception
|
||||
|
||||
def pr_required(self):
|
||||
if webnotes.conn.get_single_value("Buying Settings", "pr_required") == 'Yes':
|
||||
if webnotes.conn.get_value("Buying Settings", None, "pr_required") == 'Yes':
|
||||
for d in getlist(self.doclist,'entries'):
|
||||
if not d.purchase_receipt:
|
||||
msgprint("Purchase Receipt No. required against item %s"%d.item_code)
|
||||
|
@ -430,8 +430,8 @@ class DocType(SellingController):
|
||||
def so_dn_required(self):
|
||||
"""check in manage account if sales order / delivery note required or not."""
|
||||
dic = {'Sales Order':'so_required','Delivery Note':'dn_required'}
|
||||
for i in dic:
|
||||
if webnotes.conn.get_single_value('Selling Settings', dic[i]) == 'Yes':
|
||||
for i in dic:
|
||||
if webnotes.conn.get_value('Selling Settings', None, dic[i]) == 'Yes':
|
||||
for d in getlist(self.doclist,'entries'):
|
||||
if webnotes.conn.get_value('Item', d.item_code, 'is_stock_item') == 'Yes' \
|
||||
and not d.fields[i.lower().replace(' ','_')]:
|
||||
|
@ -85,7 +85,7 @@ class DocType(SellingController):
|
||||
|
||||
def so_required(self):
|
||||
"""check in manage account if sales order required or not"""
|
||||
if webnotes.conn.get_single_value("Selling Settings", 'so_required') == 'Yes':
|
||||
if webnotes.conn.get_value("Selling Settings", None, 'so_required') == 'Yes':
|
||||
for d in getlist(self.doclist,'delivery_note_details'):
|
||||
if not d.prevdoc_docname:
|
||||
msgprint("Sales Order No. required against item %s"%d.item_code)
|
||||
|
@ -118,7 +118,7 @@ class DocType(BuyingController):
|
||||
|
||||
|
||||
def po_required(self):
|
||||
if webnotes.conn.get_single_value("Buying Settings", "po_required") == 'Yes':
|
||||
if webnotes.conn.get_value("Buying Settings", None, "po_required") == 'Yes':
|
||||
for d in getlist(self.doclist,'purchase_receipt_details'):
|
||||
if not d.prevdoc_docname:
|
||||
msgprint("Purchse Order No. required against item %s"%d.item_code)
|
||||
|
Loading…
x
Reference in New Issue
Block a user